From: Cheng Yongkang <teel4res@gmail.com>
To: Nikolay Aleksandrov <razor@blackwall.org>,
Ido Schimmel <idosch@nvidia.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
bridge@lists.linux.dev, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [BUG] net: bridge: received STP timer fields need range validation
Date: Thu, 22 Oct 2026 02:15:33 -0700 [thread overview]
Message-ID: <20261022091533.3651250-1-teel4res@gmail.com> (raw)
Hi all,
br_stp_rcv() copies peer-controlled max_age, hello_time and
forward_delay after checking only message_age <= max_age. It does not
apply the ranges enforced by br_set_max_age(), br_set_hello_time() and
br_set_forward_delay().
Zero and oversized values have several externally visible consequences:
max_age=0: br_transmit_config() cannot emit configuration BPDUs while
non-root, while a zero-delay message-age timer forces rapid
root/designated-port recomputation
forward_delay=0: a later BLOCKING-port transition uses the zero
shortcut and skips LISTENING/LEARNING
hello_time=0: once the non-root retained value becomes active, the
hello timer repeatedly re-arms at the rounded minimum
interval
Observed on Linux v7.3, commit
08ab31164c55f20c7a2653de3186ae333470e2c1. A superior-BPDU flood with
max_age=0 and message_age=0 produced:
max_age=0 in 904/1000 sampled intervals
attacker root_id in 897/1000 intervals
68 non-root-to-root restorations
122 message-age timer expiries
The bridge returned to its configured 600 jiffy max_age and own root ID
after the flood; the impact is rapid flapping and transient suppression
of valid configuration BPDUs, not a permanent takeover.
Received timer fields should be range-checked before they become bridge
or port state. Candidate BR-035 is canonical; BR-036, BR-037 and
BR-041 are different consequences of the same missing validation.
I found no matching upstream validation patch or CVE.
The BPDU reproducer, verifier, and complete serial log are available on
request.
This was found with a multi-agent workflow; the full
state transition pattern was reproduced in QEMU.
Thanks,
Cheng Yongkang
reply other threads:[~2026-10-22 9:15 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261022091533.3651250-1-teel4res@gmail.com \
--to=teel4res@gmail.com \
--cc=bridge@lists.linux.dev \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®