mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Cheng Yongkang <teel4res@gmail.com>
To: Nikolay Aleksandrov <razor@blackwall.org>,
	Ido Schimmel <idosch@nvidia.com>
Cc: "David S . Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@kernel.org>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Simon Horman <horms@kernel.org>,
	bridge@lists.linux.dev, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [BUG] net: bridge: failed VLAN tunnel update suppresses state notification
Date: Thu, 22 Oct 2026 02:16:05 -0700	[thread overview]
Message-ID: <20261022091605.3651677-1-teel4res@gmail.com> (raw)

Hi all,

br_vlan_process_one_opts() commits BRIDGE_VLANDB_ENTRY_STATE before it
attempts BRIDGE_VLANDB_ENTRY_TUNNEL_INFO.  If tunnel insertion fails,
the option loop exits before that VID's changed flag is included in the
notification range.

The new VLAN state remains active, the request returns an error, and no
RTM_NEWVLAN reports the state transition.  This makes netlink listeners
disagree with the kernel VLAN database.

Observed on Linux v7.3, commit
08ab31164c55f20c7a2653de3186ae333470e2c1.  A range request for
VID 10..12 set state BLOCKING and tunnel IDs starting at 100.  VID 11's
tunnel ID 101 collided with an existing mapping:

  request result:          -EEXIST
  VID 11 kernel state:     BLOCKING
  VID 11 tunnel mapping:   absent
  VID 12 kernel state:     FORWARDING
  RTM_NEWVLAN for VID 11:  absent
  RTM_NEWLINK for the port: absent

The listener was opened after setup and pre-existing multicast events
were drained.

Correct behavior is per-VID atomicity: validate/prepare all options
that can fail before committing state, and roll back any earlier
successful option writes on failure.  If partial commits are
intentional, the failing VID must still be notified before returning
the error.

CVE-2026-90114 covers a different defect in the same batched range code
(descending ranges and an uninitialized error value).  I found no
matching fix for this state/notification loss.

The PoC and two independent logs are available on request.

This was found with a multi-agent workflow; the exact
notification/state divergence was reproduced in QEMU/KVM.

Thanks,
Cheng Yongkang

                 reply	other threads:[~2026-10-22  9:16 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261022091605.3651677-1-teel4res@gmail.com \
    --to=teel4res@gmail.com \
    --cc=bridge@lists.linux.dev \
    --cc=davem@davemloft.net \
    --cc=edumazet@kernel.org \
    --cc=horms@kernel.org \
    --cc=idosch@nvidia.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=razor@blackwall.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®