From: Hugo Sales <hugo@hsal.es>
To: dri-devel@lists.freedesktop.org
Cc: linux-kernel@vger.kernel.org,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Hugo Sales <hugo@hsal.es>
Subject: [PATCH] drm/client: Don't print a NULL firmware config mode
Date: Thu, 22 Oct 2026 12:43:56 +0100 [thread overview]
Message-ID: <20261022114356.669988-1-hugo@hsal.es> (raw)
When some tiles of a tiled display are missing,
drm_client_firmware_config() replaces the connector's mode with
drm_connector_fallback_non_tiled_mode(). That returns NULL when
connector->modes has no mode other than the tile size, but the debug
message after it still reads modes[i]->name. Accessing a member through
a NULL pointer is undefined behaviour. Today printk happens to get an
address below PAGE_SIZE and prints "(efault)"
Print which step found no mode instead, "no non tiled mode found" in
this case, from the mode_type the function already tracks. A connector
whose mode is NULL is skipped by drm_client_modeset_probe(), so it is
left off, as before
Sashiko found this while reviewing a series that makes the fallback
return NULL more often, by also skipping modes larger than the client
Fixes: cf1d0180f571 ("drm/fbdev: Fallback to non tiled mode if all tiles not present")
Link: https://lore.kernel.org/all/sashiko-outbox-173425@kernel.org/
Signed-off-by: Hugo Sales <hugo@hsal.es>
---
Sashiko found this while reviewing my fbdev probe series:
https://lore.kernel.org/all/20261015212545.1989962-1-hugo@hsal.es/
That series makes the fallback return NULL more often
I ran checkpatch and built drm_client_modeset.o with W=1
drivers/gpu/drm/drm_client_modeset.c | 13 +++++++++----
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/drm_client_modeset.c b/drivers/gpu/drm/drm_client_modeset.c
index 0080a8e9556a..a8cbe4c0e166 100644
--- a/drivers/gpu/drm/drm_client_modeset.c
+++ b/drivers/gpu/drm/drm_client_modeset.c
@@ -754,10 +754,15 @@ static bool drm_client_firmware_config(struct drm_client_dev *client,
}
crtcs[i] = crtc;
- drm_dbg_kms(dev, "[CONNECTOR::%d:%s] on [CRTC:%d:%s] using %s mode: %s\n",
- connector->base.id, connector->name,
- crtc->base.id, crtc->name,
- mode_type, modes[i]->name);
+ if (modes[i])
+ drm_dbg_kms(dev, "[CONNECTOR::%d:%s] on [CRTC:%d:%s] using %s mode: %s\n",
+ connector->base.id, connector->name,
+ crtc->base.id, crtc->name,
+ mode_type, modes[i]->name);
+ else
+ drm_dbg_kms(dev, "[CONNECTOR:%d:%s] on [CRTC:%d:%s] no %s mode found\n",
+ connector->base.id, connector->name,
+ crtc->base.id, crtc->name, mode_type);
fallback = false;
conn_configured |= BIT(i);
base-commit: cf5d8e390e2ac2cfa24a50645efdbb9f0eebe65f
--
2.56.0
next reply other threads:[~2026-10-22 11:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-22 11:43 Hugo Sales [this message]
2026-10-23 10:53 ` Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261022114356.669988-1-hugo@hsal.es \
--to=hugo@hsal.es \
--cc=airlied@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®