mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: Thomas Zimmermann <tzimmermann@suse.de>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>
Cc: David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
	Petr Pavlu <petr.pavlu@suse.com>,
	Luis Chamberlain <mcgrof@kernel.org>,
	Daniel Gomez <da.gomez@kernel.org>,
	Sami Tolvanen <samitolvanen@google.com>,
	Aaron Tomlin <atomlin@atomlin.com>,
	dri-devel@lists.freedesktop.org, linux-modules@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH] drm/fbdev: Replace __MODULE_STRING() with __stringify()
Date: Thu, 22 Oct 2026 13:55:43 -0400	[thread overview]
Message-ID: <20261022175543.1831620-1-sashal@kernel.org> (raw)

Commit 08abfa5a161e ("drivers: Replace __MODULE_STRING() with
__stringify()") converted the drm_fbdev_overalloc parameter description
in drm_fb_helper.c ahead of the removal of __MODULE_STRING().

Commit 6b5a66fd9f21 ("drm/fbdev: Move fbdev module parameters next to
module init") moved that parameter into drm_kms_helper_common.c while it
still used __MODULE_STRING(), so the conversion never reached the moved
code. drm_kms_helper_common.c is now the last user of the macro, and
removing the macro breaks the build with CONFIG_DRM_FBDEV_EMULATION=y:

  drivers/gpu/drm/drm_kms_helper_common.c:46:18: error: expected ')' before '__MODULE_STRING'

Use __stringify() instead. The parameter description is unchanged.

Signed-off-by: Sasha Levin <sashal@kernel.org>
---
This depends on 6b5a66fd9f21 in drm-next and 08abfa5a161e in
modules-next, both queued for 7.4. Petr plans to remove
__MODULE_STRING() once his conversions are in mainline, so this needs to
land first, either through drm-misc after 7.4-rc1 or together with the
removal patch.

Build-tested on next-20261022 (x86_64, gcc) with __MODULE_STRING()
removed from module.h. The parameter description in modinfo is
unchanged.

 drivers/gpu/drm/drm_kms_helper_common.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/drm_kms_helper_common.c b/drivers/gpu/drm/drm_kms_helper_common.c
index 1e55ecac46989..346f6c4c0b234 100644
--- a/drivers/gpu/drm/drm_kms_helper_common.c
+++ b/drivers/gpu/drm/drm_kms_helper_common.c
@@ -28,6 +28,7 @@
 #include <linux/export.h>
 #include <linux/module.h>
 #include <linux/moduleparam.h>
+#include <linux/stringify.h>
 
 #include "drm_crtc_helper_internal.h"
 #include "drm_panic_internal.h"
@@ -43,7 +44,7 @@ EXPORT_SYMBOL(drm_fbdev_overalloc);
 module_param(drm_fbdev_overalloc, int, 0444);
 MODULE_PARM_DESC(drm_fbdev_overalloc,
 		 "Overallocation of the fbdev buffer (%) [default="
-		 __MODULE_STRING(CONFIG_DRM_FBDEV_OVERALLOC) "]");
+		 __stringify(CONFIG_DRM_FBDEV_OVERALLOC) "]");
 
 /*
  * In order to keep user-space compatibility, we want in certain use-cases
-- 
2.53.0


                 reply	other threads:[~2026-10-22 17:55 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261022175543.1831620-1-sashal@kernel.org \
    --to=sashal@kernel.org \
    --cc=airlied@gmail.com \
    --cc=atomlin@atomlin.com \
    --cc=da.gomez@kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-modules@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mcgrof@kernel.org \
    --cc=mripard@kernel.org \
    --cc=petr.pavlu@suse.com \
    --cc=samitolvanen@google.com \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®