mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hui Su <sh_def@163.com>
To: K Prateek Nayak <kprateek.nayak@amd.com>
Cc: Ingo Molnar <mingo@redhat.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Juri Lelli <juri.lelli@redhat.com>,
	Vincent Guittot <vincent.guittot@linaro.org>,
	Dietmar Eggemann <dietmar.eggemann@arm.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
	Valentin Schneider <vschneid@redhat.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sched/pelt: Fix truncation of the PELT period count
Date: Thu, 22 Oct 2026 18:37:31 +0900	[thread overview]
Message-ID: <20261022183731.e4cd6c7848e5-1-sh_def@163.com> (raw)
In-Reply-To: <aa72774f-ad04-4733-8faa-0853a32c2e4c@amd.com>

> Probably needs a:
>
> Fixes: a481db34b9be ("sched/fair: Optimize ___update_sched_avg()") # c079629862b2
>
> I would actually favor changing return type to u64. Since
> accumulate_sum() is only called in one place, and that too within an
> 'if' condition, I'm sure compiler can optimize it similarly.

Thanks for the review.

I will use a481db34b9be in v2's Fixes tag and change accumulate_sum() to return u64.

Thanks,
Hui


  parent reply	other threads:[~2026-10-22 10:17 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-22  3:49 Hui Su
2026-10-22  8:34 ` K Prateek Nayak
2026-10-22  8:39   ` Vincent Guittot
2026-10-22  9:37   ` Hui Su [this message]
2026-10-22  8:37 ` Vincent Guittot
2026-10-22  9:37   ` Hui Su

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261022183731.e4cd6c7848e5-1-sh_def@163.com \
    --to=sh_def@163.com \
    --cc=bsegall@google.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=juri.lelli@redhat.com \
    --cc=kprateek.nayak@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgorman@suse.de \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=vincent.guittot@linaro.org \
    --cc=vschneid@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®