mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: fausten <yunfeng.li.nb@gmail.com>
To: Zack Rusin <zack.rusin@broadcom.com>,
	Maaz Mombasawala <maaz.mombasawala@broadcom.com>
Cc: fausten <yunfeng.li.nb@gmail.com>,
	dri-devel@lists.freedesktop.org,
	bcm-kernel-feedback-list@broadcom.com,
	maarten.lankhorst@linux.intel.com, mripard@kernel.org,
	tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] drm/vmwgfx: Treat zero SVGA_REG_CURSOR_MAX_DIMENSION as unset
Date: Fri, 23 Oct 2026 17:01:20 +0800	[thread overview]
Message-ID: <20261023090121.5031-1-fausten@ebizmis.com> (raw)
In-Reply-To: <e84774ae-b49d-4df5-923d-ae2cde480aaf@broadcom.com>

From: fausten <yunfeng.li.nb@gmail.com>

On Tue, Sep 2, 2026 at 8:44 PM, Maaz Mombasawala
<maaz.mombasawala@broadcom.com> wrote:
> This patch bricked my testing VM, investigating..

Hi Maaz, hi Zack,

Just a gentle ping on this one. Maaz, did the investigation into your
bricked testing VM turn up anything in the meantime?

Meanwhile I've done more testing on my side. I applied this fix on
top of mainline 7.3 and the cursor works correctly again:

  Host:   VMware Fusion 26.0.1 on macOS 26.7.1 (x86_64)
  Guest:  Kylin Linux Advanced Server V10 (Halberd)
  Kernel: 7.3 + this patch

Before the patch, every cursor update was rejected with -EINVAL
because SVGA_REG_CURSOR_MAX_DIMENSION reads back 0 on this setup;
with the patch applied, cursor updates go through normally again.
3D acceleration is disabled in the VM settings.

So far I haven't been able to reproduce the failure you reported.
If you can share your test environment (hypervisor product and
version, host OS, guest kernel, 3D acceleration on/off) and the
failure symptoms (boot hang vs. cursor path only), I'd like to
narrow down what's different between our setups.

And if the conclusion is that treating 0 as "unset" with the current
fallback isn't the right fix, I'm happy to rework it as a v5.

Thanks,
fausten

  reply	other threads:[~2026-10-23  9:02 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-23  8:32 [PATCH] " fausten
2026-08-23  8:59 ` [PATCH v2] " fausten
2026-08-26  0:51   ` Maaz Mombasawala
2026-08-28  1:17   ` Maaz Mombasawala
2026-08-30 15:16     ` [PATCH v4] " fausten
2026-09-02 20:44       ` Maaz Mombasawala
2026-10-23  9:01         ` fausten [this message]
2026-10-23 23:39           ` Maaz Mombasawala <maaz.mombasawala@broadcom.com>
2026-08-28 11:04   ` [PATCH v3] " fausten

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261023090121.5031-1-fausten@ebizmis.com \
    --to=yunfeng.li.nb@gmail.com \
    --cc=airlied@gmail.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=maaz.mombasawala@broadcom.com \
    --cc=mripard@kernel.org \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    --cc=zack.rusin@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®