From: Alice Ryhl <aliceryhl@google.com>
To: Deborah Brouwer <deborah.brouwer@collabora.com>,
Ke Sun <sunke@kylinos.cn>
Cc: "Alice Ryhl" <aliceryhl@google.com>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Boqun Feng" <boqun@kernel.org>, "Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Trevor Gross" <tmgross@umich.edu>,
"Danilo Krummrich" <dakr@kernel.org>,
"Daniel Almeida" <daniel.almeida@collabora.com>,
"Tamir Duberstein" <tamird@kernel.org>,
"Alexandre Courbot" <acourbot@nvidia.com>,
"Onur Özkan" <work@onurozkan.dev>,
"Lorenzo Stoakes" <ljs@kernel.org>,
"Liam R. Howlett" <liam@infradead.org>,
"Lyude Paul" <lyude@redhat.com>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Sami Tolvanen" <samitolvanen@google.com>,
rust-for-linux@vger.kernel.org, linux-mm@kvack.org,
dri-devel@lists.freedesktop.org, driver-core@lists.linux.dev,
linux-kernel@vger.kernel.org, "Alvin Sun" <alvin.sun@linux.dev>
Subject: Re: [PATCH v4 02/11] rust: mm: add `task_size` helper
Date: Fri, 23 Oct 2026 11:53:26 +0000 [thread overview]
Message-ID: <20261023115327.1776353-1-aliceryhl@google.com> (raw)
In-Reply-To: <atqh41vrlC4xVtaj@um790>
On Thu, Oct 22, 2026 at 04:53:07PM -0700, Deborah Brouwer wrote:
> On Tue, Oct 20, 2026 at 04:25:19PM +0800, Ke Sun wrote:
> > From: Alvin Sun <alvin.sun@linux.dev>
>
> I was testing Tyr's auto allocation for the user va range,
> and was surprised to see that mm.task_size() is always returning 0.
> It seems like it should work since it uses the task_size from
> struct mm_struct, but it doesn't, at least for me.
>
> If you look at tyr-dev, I think it would be better to use Sami's approach:
> 428d71932b6f rust: task: add task_size()
>
> Sami creates a task_size() method for CurrentTask which is our equivalent
> to the `current` global and then you can see that task_size becomes much
> more clearly the equivalent of "TASK_SIZE_OF" used by panthor.
>
> This approach also correctly returns a user va range when Tyr has to
> assign it in my tests, so let's switch over.
+1 to switching to CurrentTask::task_size(&self) backed by a C helper
calling TASK_SIZE_OF(current). Please also include `<linux/mm.h>` in
`rust/helpers/task.c`, as on some architectures (e.g. riscv) `TASK_SIZE` is
defined in `<asm/pgtable.h>` rather than `<linux/sched/task.h>`.
Alice
next prev parent reply other threads:[~2026-10-23 11:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-20 8:25 [PATCH v4 00/11] drm/tyr: add VM and BO ioctl support Ke Sun via B4 Relay
2026-10-20 8:25 ` [PATCH v4 01/11] rust: sizes: add SZ_4G constant Ke Sun via B4 Relay
2026-10-20 8:25 ` [PATCH v4 02/11] rust: mm: add `task_size` helper Ke Sun via B4 Relay
2026-10-22 23:53 ` Deborah Brouwer
2026-10-23 11:53 ` Alice Ryhl [this message]
2026-10-20 8:25 ` [PATCH v4 03/11] rust: sync: arc: relax `ForeignOwnable` for `Arc<T>` Ke Sun via B4 Relay
2026-10-20 8:25 ` [PATCH v4 04/11] drm/tyr: add per-file VM pool Ke Sun via B4 Relay
2026-10-21 22:59 ` Deborah Brouwer
2026-10-20 8:25 ` [PATCH v4 05/11] drm/tyr: add user and MCU VM specifications Ke Sun via B4 Relay
2026-10-20 8:25 ` [PATCH v4 06/11] drm/tyr: add BO creation and lookup helpers Ke Sun via B4 Relay
2026-10-20 8:25 ` [PATCH v4 07/11] drm/tyr: add VM-related ioctls Ke Sun via B4 Relay
2026-10-20 8:25 ` [PATCH v4 08/11] drm/tyr: add BO-related ioctls Ke Sun via B4 Relay
2026-10-20 8:25 ` [PATCH v4 09/11] rust: device: expose the device DMA attribute Ke Sun via B4 Relay
2026-10-20 8:25 ` [PATCH v4 10/11] drm/tyr: gem: flush write-combine BOs from probe-time coherence Ke Sun via B4 Relay
2026-10-20 8:25 ` [PATCH v4 11/11] drm/tyr: gem: map cached BOs for DRM_PANTHOR_BO_WB_MMAP Ke Sun via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261023115327.1776353-1-aliceryhl@google.com \
--to=aliceryhl@google.com \
--cc=a.hindborg@kernel.org \
--cc=acourbot@nvidia.com \
--cc=airlied@gmail.com \
--cc=alvin.sun@linux.dev \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun@kernel.org \
--cc=dakr@kernel.org \
--cc=daniel.almeida@collabora.com \
--cc=deborah.brouwer@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=driver-core@lists.linux.dev \
--cc=gary@garyguo.net \
--cc=gregkh@linuxfoundation.org \
--cc=liam@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=lossin@kernel.org \
--cc=lyude@redhat.com \
--cc=ojeda@kernel.org \
--cc=rafael@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=samitolvanen@google.com \
--cc=simona@ffwll.ch \
--cc=sunke@kylinos.cn \
--cc=tamird@kernel.org \
--cc=tmgross@umich.edu \
--cc=work@onurozkan.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®