Re: [PATCH v2 3/3] arm64: dts: qcom: ipq5018: add Ubiquiti UniFi U6 Enterprise

[Andrei-Alexandru Bleortu <me@andrei-z.com>]

On 10/21/26 3:44 PM, Konrad Dybcio wrote:
> On 10/4/26 1:10 PM, Andrei-Alexandru Bleortu wrote:
>> +		button-reset {
>> +			label = "reset";
>
> Normally we do sentence case here, i.e. "Reset"

Will do in v3.

>> +&blsp1_i2c3 {
>> +	pinctrl-0 = <&i2c_pins>;
>> +	pinctrl-names = "default";
>> +	status = "okay";
>
> Please keep a \n before 'status', file-wide for consistency

Will do, for &blsp1_i2c3, &blsp1_spi1 and &sdhc_1.

>> +&pcie0_port0 {
>> +	reset-gpios = <&tlmm 15 GPIO_ACTIVE_LOW>;
>
> No wake-gpios?

Not that I can find. The vendor device tree gives only PERST# for the
two radios (GPIO15 and GPIO18) and configures nothing on GPIO16, 17 or
19, where a reference-design WAKE# would be. Without a schematic I
can't tell whether WAKE# is routed at all, so I'd rather leave it out
than copy the RDP's GPIO16. Both radios work without it.

>> +	wifi@0,0 {
>> +		compatible = "pci17cb,1104";
>> +		reg = <0x10000 0x0 0x0 0x0 0x0>;
>> +		qcom,calibration-variant = "Ubiquiti-U6-Enterprise-5G";
>
> Does the same calibration work for both radios?

No, they need different board data: the 6 GHz radio below pcie1_port0
has "Ubiquiti-U6-Enterprise-6G". The two QCN9074s are otherwise
indistinguishable to ath11k: both are 17cb:1104 with subsystem
17cb:1104, and both report chip-id 0 and board-id 255 (unprogrammed
OTP). So the variant is the only part of the board name that differs:

  bus=pci,qmi-chip-id=0,qmi-board-id=255,variant=Ubiquiti-U6-Enterprise-5G
  bus=pci,qmi-chip-id=0,qmi-board-id=255,variant=Ubiquiti-U6-Enterprise-6G

The stock firmware also ships a separate board file per band. Both
board files went to the ath11k list under these names.

>> +&prng {
>> +	status = "okay";
>> +};
>
> Please add a preceding patch to enable it in the SoC DTSI, this should
> never really need to be disabled

Will do; v3 drops the status from the dtsi, as ipq5332 and ipq9574
have it, and the board no longer touches &prng.

Thanks for the review!
Andrei