From: Jakub Kicinski <kuba@kernel.org>
To: Myeonghun Pak <mhun512@gmail.com>
Cc: netdev@vger.kernel.org, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@kernel.org, pabeni@redhat.com,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
ae878000@gmail.com, daniel.machon@microchip.com
Subject: Re: [PATCH net v3 0/2] net: nixge: fix tasklet and DMA teardown
Date: Fri, 23 Oct 2026 14:03:47 -0700 [thread overview]
Message-ID: <20261023140347.095c1e70@kernel.org> (raw)
In-Reply-To: <20261018020840.3851552-1-mhun512@gmail.com>
On Sat, 17 Oct 2026 22:08:38 -0400 Myeonghun Pak wrote:
> Separate the IRQ/tasklet ordering fix and the DMA shutdown fix from
> v2, as requested by Daniel Machon.
>
> Patch 1 releases both IRQ handlers before draining dma_err_tasklet.
> Patch 2 masks channel interrupts after recovery has stopped and waits
> for DMA reset completion before releasing the buffers. On reset timeout,
> it retains those buffers and prevents a later open from replacing them.
AFAICT these patches don't fix the problem 100% of the time, and are
fully LLM generated, no tested on real HW.
This driver is not maintained, let's not mess with its error paths
because LLM says so.
--
pw-bot: reject
prev parent reply other threads:[~2026-10-23 21:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-18 2:08 Myeonghun Pak
2026-10-18 2:08 ` [PATCH net v3 1/2] net: nixge: free IRQs before killing the DMA error tasklet Myeonghun Pak
2026-10-19 2:10 ` netdev-bot+sashiko
2026-10-23 17:09 ` Simon Horman
2026-10-18 2:08 ` [PATCH net v3 2/2] net: nixge: wait for DMA reset before releasing buffers Myeonghun Pak
2026-10-19 2:10 ` netdev-bot+sashiko
2026-10-23 17:23 ` Simon Horman
2026-10-23 21:03 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261023140347.095c1e70@kernel.org \
--to=kuba@kernel.org \
--cc=ae878000@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=daniel.machon@microchip.com \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhun512@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®