From: Tejun Heo <tj@kernel.org>
To: sched-ext@lists.linux.dev
Cc: David Vernet <void@manifault.com>,
Andrea Righi <arighi@nvidia.com>,
Changwoo Min <changwoo@igalia.com>,
Emil Tsalapatis <emil@etsalapatis.com>,
David Dai <david.dai@linux.dev>,
linux-kernel@vger.kernel.org, Tejun Heo <tj@kernel.org>
Subject: [PATCHSET v3 sched_ext/for-7.4] sched_ext: Fix bypassed sub-scheduler tasks stalling when the host lacks caps
Date: Fri, 23 Oct 2026 07:55:51 -1000 [thread overview]
Message-ID: <20261023175608.4120910-1-tj@kernel.org> (raw)
Hello,
v3 (uncounted reenqueues under bypass, served time from the charge):
- Add a patch testing bypass before the reenqueue count in
scx_do_enqueue_task(). A bypassing scheduler's reenqueues are the kernel's
placements, and counting them could strand a bypassed task and deadlock
the disable, which relies on bypass keeping every task running (#3,
sashiko).
- Add a patch counting rescue served time from the charged runtime. The
rescuee's sum_exec_runtime follows the mutex owner under proxy execution
while the slice follows the donor, so the two disagreed in both
directions. scx_rescue_keep() now WARNs and ends the rescue if its restore
is refused (#6, sashiko).
- With rescue disabled, admit a migration-disabled or migration-pending task
to the local DSQ on a cpu where the host lacks BASE instead of leaving it
on the unconsumed bypass DSQ (#13).
- Update descriptions and comments, among them #17's rescue-off and
zero-interval cases (#4, #7, #9, #10, #11, #16, #17).
v2 (keep a bypassed rescuee in dispatch_one()):
- Add a patch expiring a bypassing prev's slice in dispatch_one() before
its keep test and dropping the bypass test from it. A bypassed rescuee
now keeps the cpu on its kernel slice and scx_dispatch_sched()'s
post-dispatch test no longer keeps a prev that dispatch_one() declined
(#10, sashiko).
- Cover a rescuee that passes the keep-last test in the dispatch_one()
comment and description (#6, sashiko).
- Update the descriptions and correct the refusal causes listed in #15
(#11, #15).
v2: https://lore.kernel.org/r/20261023052452.2889061-1-tj@kernel.org
v1: https://lore.kernel.org/r/20261022213836.2259069-1-tj@kernel.org
A bypassing sub-scheduler's tasks run through the per-cpu bypass DSQs of
its host, the nearest ancestor that is not bypassing. Caps are per cpu, and
a cpu's dispatch descends into a scheduler only where it holds
SCX_CAP_BASE, so a bypass DSQ on a cpu where the host lacks BASE is never
consumed. Bypass placement and the bypass load balancer ignored that. A
bypassed task could be queued or moved onto such a cpu and sit there until
the host regained the cap or the bypass window ended, and a host holding
BASE but not ENQ looped a bypassed task between its bypass DSQ and the
reject drain instead of running it.
The fixes make SCX_CAP_BASE the one cap a bypassed task needs and keep
bypassed tasks off the cpus where the host lacks it. A bypass consume puts
the task on the cpu being dispatched for, to run right away, which is what
BASE grants. Where the host lacks BASE on a task's cpu, the task runs under
rescue at bounded bandwidth instead of waiting for a dispatch that can't
reach it. The bypass load balancer spreads tasks over the cpus where the
host holds BASE only, and when the host loses BASE on a cpu it drains that
cpu's bypass DSQ to the cpus that can still run the tasks, or sends them
home to be placed again.
Running bypassed tasks under rescue leans on the rescue slice harder than
before and exposed gaps there: a cpu could go idle with a runnable rescuee
queued on it, the kernel's own slice writes under bypass served the grant a
tick at a time, and a scheduler could extend the grant past the rescue's
bandwidth. The grant is now a kernel-owned slice that the kernel's slice
housekeeping leaves alone and schedulers can shorten but not extend, and a
cpu no longer idles over a runnable rescuee.
Tested with a three-level hierarchy cycling bypass under pinned spinners,
fork and context-switch storms, with caps revoked under queued tasks. The
balancer's remote move and the drain were exercised, and the holding_cpu
handshake, the cap-revoke placement and the rescue keep were model checked
for small cpu counts.
Based on sched_ext/for-7.4 (1f5dde349ac2).
This patchset contains the following 17 patches.
0001 sched_ext: Pack scx_ent_flags' multi-bit fields at the top
0002 sched_ext: Clear holding_cpu where the claim is confirmed
0003 sched_ext: Fix bypassed tasks stranded by the reenqueue limit
0004 sched_ext: Fix bypassed tasks looping on a host without SCX_CAP_ENQ
0005 sched_ext: Move refill_task_slice_dfl() below apply_slice_vtime()
0006 sched_ext: Fix rescue served time disagreeing with the slice under proxy execution
0007 sched_ext: Restore a rescuee's slice after ops.stopping()
0008 sched_ext: Fix a cpu idling with a runnable rescuee
0009 sched_ext: Mark the rescue grant as a kernel slice with SCX_TASK_KERNEL_SLICE
0010 sched_ext: Refuse extending a kernel slice
0011 sched_ext: Fix a cpu idling after put_prev_task_scx() queues its task on the local DSQ
0012 sched_ext: Expire prev's slice in dispatch_one() under bypass
0013 sched_ext: Fix bypassed tasks stalling when the host lacks SCX_CAP_BASE
0014 sched_ext: Fix the bypass load balancer stranding tasks on cpus where the host lacks SCX_CAP_BASE
0015 sched_ext: Factor out bypass_lb_move() and insert with the donor DSQ unlocked
0016 sched_ext: Let the bypass load balancer move tasks homed on other cpus
0017 sched_ext: Fix queued bypassed tasks stalling when the host loses SCX_CAP_BASE
The patches are organized as follows:
- 0001-0002 prepare: pack scx_ent_flags' multi-bit fields at the top so that
the single-bit flags stay contiguous, and clear holding_cpu where the
claim is confirmed.
- 0003 keeps a bypassing scheduler's reenqueues out of the reenqueue limit,
as the kernel places its tasks and a strand under bypass can deadlock the
disable.
- 0004 consumes bypass DSQs with SCX_ENQ_IMMED, so that a host with BASE but
not ENQ runs its bypassed tasks instead of looping them.
- 0005-0010 fix the rescue slice handling that bypassed tasks under rescue
depend on: count served time from the charge, restore the remainder after
ops.stopping(), keep a cpu from idling with a runnable rescuee, mark the
grant as a kernel slice that the kernel's slice writes leave alone, and
refuse extending it.
- 0011 reschedules a cpu after put_prev_task_scx() queues its task on the
local DSQ through the plain insert too.
- 0012 expires a bypassing prev's slice in dispatch_one() before its keep
test instead of refusing to keep it, so a bypassed rescuee keeps the cpu
on its kernel slice and the post-dispatch test can't keep a declined prev.
- 0013 sends a bypassed task to rescue when the host lacks BASE on its cpu.
- 0014-0017 make the bypass load balancer cap-aware: capacity and donees
from BASE cpus only, a factored-out move that inserts with the donor DSQ
unlocked, moves of tasks homed on other cpus, and the drain of a cpu's
bypass DSQ when the host loses BASE there.
The patchset is also available in the following git branch:
git://git.kernel.org/pub/scm/linux/kernel/git/tj/sched_ext.git bypass-caps-v3
diffstat follows. Thanks.
include/linux/sched/ext.h | 22 +-
kernel/sched/ext/ext.c | 575 +++++++++++++++++-------
kernel/sched/ext/inlines.h | 15 +-
kernel/sched/ext/internal.h | 18 +-
kernel/sched/ext/sub.c | 75 ++--
kernel/sched/ext/sub.h | 16 +
kernel/sched/sched.h | 2 +-
tools/sched_ext/include/scx/enum_defs.autogen.h | 1 +
tools/sched_ext/include/scx/enums_abi.autogen.h | 29 +-
9 files changed, 541 insertions(+), 212 deletions(-)
--
tejun
next reply other threads:[~2026-10-23 17:56 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-23 17:55 Tejun Heo [this message]
2026-10-23 17:55 ` [PATCH 01/17] sched_ext: Pack scx_ent_flags' multi-bit fields at the top Tejun Heo
2026-10-23 17:55 ` [PATCH 02/17] sched_ext: Clear holding_cpu where the claim is confirmed Tejun Heo
2026-10-23 17:55 ` [PATCH 03/17] sched_ext: Fix bypassed tasks stranded by the reenqueue limit Tejun Heo
2026-10-23 17:55 ` [PATCH 04/17] sched_ext: Fix bypassed tasks looping on a host without SCX_CAP_ENQ Tejun Heo
2026-10-23 17:55 ` [PATCH 05/17] sched_ext: Move refill_task_slice_dfl() below apply_slice_vtime() Tejun Heo
2026-10-23 17:55 ` [PATCH 06/17] sched_ext: Fix rescue served time disagreeing with the slice under proxy execution Tejun Heo
2026-10-23 17:55 ` [PATCH 07/17] sched_ext: Restore a rescuee's slice after ops.stopping() Tejun Heo
2026-10-23 17:55 ` [PATCH 08/17] sched_ext: Fix a cpu idling with a runnable rescuee Tejun Heo
2026-10-23 17:56 ` [PATCH 09/17] sched_ext: Mark the rescue grant as a kernel slice with SCX_TASK_KERNEL_SLICE Tejun Heo
2026-10-23 17:56 ` [PATCH 10/17] sched_ext: Refuse extending a kernel slice Tejun Heo
2026-10-23 17:56 ` [PATCH 11/17] sched_ext: Fix a cpu idling after put_prev_task_scx() queues its task on the local DSQ Tejun Heo
2026-10-23 17:56 ` [PATCH 12/17] sched_ext: Expire prev's slice in dispatch_one() under bypass Tejun Heo
2026-10-23 17:56 ` [PATCH 13/17] sched_ext: Fix bypassed tasks stalling when the host lacks SCX_CAP_BASE Tejun Heo
2026-10-23 17:56 ` [PATCH 14/17] sched_ext: Fix the bypass load balancer stranding tasks on cpus where " Tejun Heo
2026-10-23 17:56 ` [PATCH 15/17] sched_ext: Factor out bypass_lb_move() and insert with the donor DSQ unlocked Tejun Heo
2026-10-23 17:56 ` [PATCH 16/17] sched_ext: Let the bypass load balancer move tasks homed on other cpus Tejun Heo
2026-10-23 17:56 ` [PATCH 17/17] sched_ext: Fix queued bypassed tasks stalling when the host loses SCX_CAP_BASE Tejun Heo
2026-10-23 20:06 ` [PATCH 18/17] sched_ext: Fix use-after-free of a NONE rescuee leaving sched_ext Tejun Heo
2026-10-23 20:06 ` [PATCH 19/17] sched_ext: Fix the stall watchdog blaming a bypassing owner for a stuck task Tejun Heo
2026-10-23 20:10 ` [PATCH 20/17] sched_ext: Fix a lone IMMED task waiting behind a kept prev Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261023175608.4120910-1-tj@kernel.org \
--to=tj@kernel.org \
--cc=arighi@nvidia.com \
--cc=changwoo@igalia.com \
--cc=david.dai@linux.dev \
--cc=emil@etsalapatis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sched-ext@lists.linux.dev \
--cc=void@manifault.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®