From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=74.125.82.170 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792897576; b=XIfVwJyw/sPVqdJM0nADvnxI+1dtCDYkYn0cQtBBclKR9t8u9sVbbvCvkYRWd1oG4Cxl oMJ5s/rW2LCB1BP8eDfdDPBkrAzorEoeZl2sDsvnOaH4wW42IH+KlTY0yzc3CMynnFMQ8 SVe2FDMiKwYXsLZJXj13EuNoap3fLumBLYeueN592f8VBoiMTNoagyVtKLpOvWtVmyCyT w9cD8/WCKzcYaxQgm69K9TST2OZ2vuQPWqyXc6g3CTv7NlDAMUadE4fdnFcl1si0A1Gs3 +l0+O2d6V/CSS6vN4TOtIoNhJFTO3vH6Wha9q89xt3nWR+5hk6bY9XhNmdMZoFj4UXg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792897576; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: From:Date:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding: Message-Id:References:In-Reply-To:To:Cc:X-Mailer; bh=QXJ1lAA5CJL+VwXuJtf9fzAkgG9SQEGMbPU6n42N680=; b=hj+0UzFhvOPwfeflHv2GriYSq8Dy0451UaYyUeFaHQBH4ad0Bw0Nf2lzPYUmkrNHwF5+ vPXaK4MCFM+R7Qbvfr4M7Gyg7ANuRAbz5QVLVN4Kwt8iNUxymlAt0QNRZVjDRheL5XVYC 5Mblo7N2iSG5oM744P8FnVCr23rEo4EAustxmiUkPG4LDHcTWzoC24jU7vNHMlIO2bWuK grJMxLu4n9GkPazzOZp1fwvusDaG/tP4uicwNhDhoORlxxB+b3R8jmTpHBR5gokpmB7Sc RkXa09Kbb1F1PIJqJbJqb6nWdwBeu3vYMXxsq1xgcz3WymPzukENgFPOSlDx/h4lUdg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=X1vUlKzm; arc=none smtp.remote-ip=74.125.82.170 Received: from mail-dy1-f170.google.com (mail-dy1-f170.google.com [74.125.82.170]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8182960A260A for ; Sun, 25 Oct 2026 03:06:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 8182960A260A Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=X1vUlKzm Received: by mail-dy1-f170.google.com with SMTP id 5a478bee46e88-35cd4e8bdbdso3523213eec.1 for ; Sat, 24 Oct 2026 20:06:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1792897576; x=1793502376; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=QXJ1lAA5CJL+VwXuJtf9fzAkgG9SQEGMbPU6n42N680=; b=X1vUlKzmxrVzca0s04RBW8h3S8B/UlLGXeQV08TMrlGFFbPgHOOKI6JsH9cpURZVA0 N9tzxcuPSn2OpAX4luRNBMowT7WOLzPSiN4SGLD7Y9efSk5MV6drC7fzXf+3LxVhhzer U0kHH8Pt2Tm37DOWF0YbMiyfKLA91Cqlm51cVDEmDwiV5OKOtBfG1ceOTPrO3ucZVLnh QaK4kEQ5nY6tP7OSNVFkiEH+LD7NVbZI8Gj1UQDnROrJ+mJScfj+LZFIGbVCLkP1wfVr NuDZT5wtAgaTr0u5fRn0Y4ZGXbK9cJhP1aMjo1OTHf4WiAzXI+VJ/HOxJ4mQfW+5/x1c q3pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792897576; x=1793502376; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=QXJ1lAA5CJL+VwXuJtf9fzAkgG9SQEGMbPU6n42N680=; b=qLmRuLufESOJ4Pc0q/YgLZLL0zKlgTAQ2YsSChrOarGAHA/zWsh9hVHLF6aoAkBf5A b3bEByWBMII8gF7PQ4cNJv445cQjVJ321tDosGIs2hy49IS21sAYkjY4ywbKLe8MBF4x jV1ZjeWmLhw+N6KF9D6xGITUUl77+PdOJLH9d7euEr8xkbFPqTm91bvDTiWHB+Mp+ZXP ZQ5rxRa8964qdE4uL93DlWPi6U2vzzi1v+hXHH15zV33j7sv5SJTA5NaGV4YHJrnXkPK iQCQiHGKPYgkcMM8MCGV2JU+ZDoY1Iwnl25SbtIxKYOQQihhiJwjpPoydzwv4FYbPmoj 6hGg== X-Forwarded-Encrypted: i=1; AKwUvBx53Zfaa7b1FvAgMwbFqQMb70NJviNxekbHc5B0R05VjtuJ6HCKySPoC81vlldisNzdZ9L1K4Sst9dm3lE=@vger.kernel.org X-Gm-Message-State: AFq9FYJwOhrRZ/Yvc5j916amQcbbRx95l0XTuZJeV4jBMvf0zMHWacdz qtw3H8nrd9Qi1kUU/kEhYpgW6gjdVjYsFjdR3U77Rpsqvr+AhkCZcAgT X-Gm-Gg: AYBFou13OtY9X/sAv6wh05iB68sbsp+AWlAaPB3S3T3x7JfTW6joS+qu2zaRp5ODr4W AySF3srHmvq1e3pTqO46JzK8t+lQSmTrTXBphIYR8brn/b931FUDQmA0Cu/feBrDIA/GGLoLWoG qAbAGxhW6cWy0PtQ5s22rV+Klm0f5VEZ8YQDSJdWIEMifsZ9UQlpknAetcISJEpb2UK/pvZs10a Bf0atuGvLyIZwqXlcmhag4GZ/qSnWfLtEO3qETL7I8lL3aT7httLzOJ8Q0TDCaCNKqxXq89+5sG LjbIUUBHxA5p/jBMkn6n6eDmv3cclzok8X9sGRp24aswsJI3vqQKf702SPAumYlIGqeYXPcwony XUNT0VqXKUbxjJa5tBym1EsPL6l5qxwetR2Pub55y1B04lGVwGxyhqg8YoXHi+xLlcPj9u0Lw6g PCgix0p7yi/nNhHZssF2/hoSXQImlbxjMwjW7NtHwM7MthDdq52LKCgA9K1y8UGzAfKe3NjJJo5 bi/0q3gZcjFEJYQ0RqQoj3DGUDQ4TE5uBnW7Pl7ehKhHsFN1jDmS0V6jEhoRJ17Fg5eo04oqYbX EdAPFd6X7rvesB+AJ3bQTUJBcJqsiQvxTQxcOsmLSqw= X-Received: by 2002:a05:7300:f292:b0:368:a825:bf7f with SMTP id 5a478bee46e88-369e84fa201mr4858295eec.13.1792897575668; Sat, 24 Oct 2026 20:06:15 -0700 (PDT) Received: from dtor-ws.sjc.corp.google.com ([2a00:79e0:2ebe:8:8fe4:693:7158:24de]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-369e8ec9276sm20245992eec.25.2026.10.24.20.06.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 24 Oct 2026 20:06:15 -0700 (PDT) From: Dmitry Torokhov Date: Sat, 24 Oct 2026 20:06:08 -0700 Subject: [PATCH 05/31] hwmon: (pmbus/acbel-fsg032) use 4-argument i2c_smbus_read_block_data() X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20261024-hwmon-i2c-smbus-read-block-data-v1-5-e81941ad0cd3@gmail.com> References: <20261024-hwmon-i2c-smbus-read-block-data-v1-0-e81941ad0cd3@gmail.com> In-Reply-To: <20261024-hwmon-i2c-smbus-read-block-data-v1-0-e81941ad0cd3@gmail.com> To: Guenter Roeck , Cosmo Chou , Andy Chung , Ninad Palsule , Abdurrahman Hussain , Robert Marko , Delphine CC Chiu , Daniel Nilsson Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.17-dev-e56a4 Pass the buffer size to i2c_smbus_read_block_data(), shrink the debugfs data buffer to I2C_SMBUS_BLOCK_MAX, and ensure the string buffer is NUL-terminated before comparison. Signed-off-by: Dmitry Torokhov --- drivers/hwmon/pmbus/acbel-fsg032.c | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/drivers/hwmon/pmbus/acbel-fsg032.c b/drivers/hwmon/pmbus/acbel-fsg032.c index 5222e7aeca44..d36076b9c44d 100644 --- a/drivers/hwmon/pmbus/acbel-fsg032.c +++ b/drivers/hwmon/pmbus/acbel-fsg032.c @@ -19,11 +19,12 @@ static ssize_t acbel_fsg032_debugfs_read(struct file *file, char __user *buf, si loff_t *ppos) { struct i2c_client *client = file->private_data; - u8 data[I2C_SMBUS_BLOCK_MAX + 2] = { 0 }; + u8 data[I2C_SMBUS_BLOCK_MAX] = { 0 }; char out[8]; int rc; - rc = i2c_smbus_read_block_data(client, ACBEL_MFR_FW_REVISION, data); + rc = i2c_smbus_read_block_data(client, ACBEL_MFR_FW_REVISION, + sizeof(data), data); if (rc < 0) return rc; @@ -70,25 +71,26 @@ static int acbel_fsg032_probe(struct i2c_client *client) struct device *dev = &client->dev; int rc; - rc = i2c_smbus_read_block_data(client, PMBUS_MFR_ID, buf); + rc = i2c_smbus_read_block_data(client, PMBUS_MFR_ID, + sizeof(buf) - 1, buf); if (rc < 0) { dev_err(dev, "Failed to read PMBUS_MFR_ID\n"); return rc; } + buf[rc] = '\0'; if (strncmp(buf, "ACBEL", 5)) { - buf[rc] = '\0'; dev_err(dev, "Manufacturer '%s' not supported\n", buf); return -ENODEV; } - rc = i2c_smbus_read_block_data(client, PMBUS_MFR_MODEL, buf); + rc = i2c_smbus_read_block_data(client, PMBUS_MFR_MODEL, + sizeof(buf) - 1, buf); if (rc < 0) { dev_err(dev, "Failed to read PMBUS_MFR_MODEL\n"); return rc; } - + buf[rc] = '\0'; if (strncmp(buf, "FSG032", 6)) { - buf[rc] = '\0'; dev_err(dev, "Model '%s' not supported\n", buf); return -ENODEV; } -- 2.56.0.257.gf7497c7d27-goog