From: ChunAn Wu <an.wu@canonical.com>
To: linux-serial@vger.kernel.org, platform-driver-x86@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, markus.probst@posteo.de,
gregkh@linuxfoundation.org, jirislaby@kernel.org,
hansg@kernel.org, ilpo.jarvinen@linux.intel.com,
mpearson-lenovo@squebb.ca, derekjohn.clark@gmail.com
Subject: [PATCH v4 0/3] serdev: handle devices without an ACPI or device tree node
Date: Sat, 24 Oct 2026 10:29:27 +0800 [thread overview]
Message-ID: <20261024022930.2704030-1-an.wu@canonical.com> (raw)
Driver-created serdev clients without an ACPI companion or device tree
node currently have no modalias and cannot be matched to a driver:
their modalias sysfs read returns -ENODEV and their creators force a
bind with device_driver_attach().
Backlight function on dell-uart-backlight is not affected: that class
device is registered independently and gets its own add uevent. The
user-visible breakage is the failing modalias read on an existing
serdev child -- Checkbox dkms_info_attachment aborts with
"OSError: [Errno 19] No such device".
Resolve the two long-standing serdev-core TODOs by letting the creator
pass a modalias to serdev_device_add() and giving the serdev driver an
id_table, modelled on the SPI bus. ACPI and OF match first and are
unchanged. Convert dell-uart-backlight and the Lenovo Yoga Tab 2 Pro
fastcharger to this path and drop their force-attach workarounds.
Changes in v4:
- Patch 1: drop the dead is_serdev_device() guard from the match
callback, and dereference serdev once at the top
- Patch 1: drop the "large enough" comment on SERDEV_NAME_SIZE
- Patch 1: in struct serdev_device_driver, place id_table right under
driver, next to driver->of_match_table and driver->acpi_match_table
- Patch 1: merge serdev_device_set_modalias() into serdev_device_add()
so the modalias is set at the only point where forgetting it would
matter; internal firmware callers pass NULL
- All three patches: tightened commit messages and moved the v2/v3
changelog narrative out of Patch 1 into this cover letter
Changes in v3:
- Rename struct serdev_device::name to ::modalias; dev_name() is
unchanged
- Model matching on the SPI bus: add struct serdev_device_id and
id_table; drop driver->name matching
- Add serdev_device_set_modalias() helper and SERDEV_MODULE_PREFIX
- No MODULE_DEVICE_TABLE(serdev, ...) support: both in-tree
firmware-less clients are created by the same module that provides
their driver, so udev has nothing to autoload
Changes in v2:
- Instead of silently returning success with no modalias, use a
creator-supplied name as a "serial:<name>" modalias fallback and as
the matching key, so clients can bind through normal serdev matching
v3: https://lore.kernel.org/lkml/20261023052717.2577234-1-an.wu@canonical.com/
v2: https://lore.kernel.org/lkml/20261022032842.2492572-1-an.wu@canonical.com/
v1: https://lore.kernel.org/lkml/20261021092124.2306053-1-an.wu@canonical.com/
ChunAn Wu (3):
serdev: handle devices without an ACPI or device tree node
platform/x86: dell-uart-backlight: Bind through normal serdev matching
platform/x86: lenovo-yoga-tab2-pro-1380-fastcharger: Bind through
normal serdev matching
MAINTAINERS | 1 +
.../platform/x86/dell/dell-uart-backlight.c | 33 ++++------
.../lenovo/yoga-tab2-pro-1380-fastcharger.c | 25 +++----
.../platform/x86/x86-android-tablets/core.c | 2 +-
drivers/power/sequencing/pwrseq-pcie-m2.c | 2 +-
drivers/tty/serdev/core.c | 65 ++++++++++++++-----
include/linux/device-id/serdev.h | 19 ++++++
include/linux/serdev.h | 12 +++-
8 files changed, 105 insertions(+), 54 deletions(-)
create mode 100644 include/linux/device-id/serdev.h
base-commit: 9e947d96915af63e28896caae85a81b74855621b
--
2.34.1
next reply other threads:[~2026-10-24 2:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-24 2:29 ChunAn Wu [this message]
2026-10-24 2:29 ` [PATCH v4 1/3] " ChunAn Wu
2026-10-24 2:29 ` [PATCH v4] platform/x86: dell-uart-backlight: Bind through normal serdev matching ChunAn Wu
2026-10-24 11:59 ` kernel test robot
2026-10-24 12:03 ` Markus Probst
2026-10-24 17:42 ` kernel test robot
2026-10-24 2:29 ` [PATCH v4 3/3] platform/x86: lenovo-yoga-tab2-pro-1380-fastcharger: " ChunAn Wu
2026-10-24 3:50 ` [PATCH v4 2/3] platform/x86: dell-uart-backlight: " ChunAn Wu
2026-10-24 8:40 ` [PATCH v4 0/3] serdev: handle devices without an ACPI or device tree node An Wu
2026-10-24 11:48 ` Markus Probst
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261024022930.2704030-1-an.wu@canonical.com \
--to=an.wu@canonical.com \
--cc=derekjohn.clark@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hansg@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=markus.probst@posteo.de \
--cc=mpearson-lenovo@squebb.ca \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®