From: Jonathan Cameron <jic23@kernel.org>
To: Rupesh Majhi <zoone.rupert@gmail.com>
Cc: "Bart Van Assche" <bvanassche@acm.org>,
"Andy Shevchenko" <andy@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Jishnu Prakash" <jishnu.prakash@oss.qualcomm.com>,
"Nuno Sá" <nuno.sa@analog.com>, "Marco Elver" <elver@google.com>,
linux-arm-msm@vger.kernel.org, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] iio: adc: qcom-spmi-adc5-gen3: fix lock annotations on mutex helpers
Date: Sat, 24 Oct 2026 03:30:06 +0100 [thread overview]
Message-ID: <20261024033006.35498dec@jic23-hlaptop> (raw)
In-Reply-To: <20261023064709.77180-1-zoone.rupert@gmail.com>
On Fri, 23 Oct 2026 09:47:09 +0300
Rupesh Majhi <zoone.rupert@gmail.com> wrote:
> On Wed, Oct 21, 2026 at 08:24:33PM +0100, Jonathan Cameron wrote:
> > I haven't tried yet, but I think you said not much broke?
>
> I hadn't tried either, so I did: CONTEXT_ANALYSIS := y in every
> drivers/iio Makefile, on testing, x86_64 allmodconfig, clang 23.
> 255 warnings.
>
> 240 come from iio_device_claim_direct() and
> iio_device_try_claim_buffer_mode() lacking __cond_acquires(). The rest
> are 4 in industrialio-core.c and 11 in five drivers, none of them real
> bugs. With those annotated it builds clean.
>
> v3 would be this fix without Fixes tag, core annotations, one patch per
> driver, then enabling it for drivers/iio. Does that work for you?
Yes, though no need to necessarily do it in one go if you
prefer smaller steps. I don't mind merging fixes like this
without the global enable. Maybe can do it on a directory first?
J
prev parent reply other threads:[~2026-10-24 2:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-21 5:24 Rupesh Majhi
2026-10-21 14:23 ` Andy Shevchenko
2026-10-21 15:15 ` Bart Van Assche
2026-10-21 18:19 ` Rupesh Majhi
2026-10-21 19:24 ` Jonathan Cameron
2026-10-23 6:47 ` Rupesh Majhi
2026-10-24 2:30 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261024033006.35498dec@jic23-hlaptop \
--to=jic23@kernel.org \
--cc=andy@kernel.org \
--cc=bvanassche@acm.org \
--cc=dlechner@baylibre.com \
--cc=elver@google.com \
--cc=jishnu.prakash@oss.qualcomm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=zoone.rupert@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®