From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=205.220.180.131 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792834850; b=NIiuwowmvKF+4HHWFBJ5xPDkW4BuMXDJnmBqfDsK/qLUgsoCzlHztCRkcf4vtRvslPBn K5Oho5ST5HNdGJ/lRWPJ+hohSruFZFRpPdP+WsJXTdHdGSnKBACbMDB8BdbdNycHvM4SJ hJoaPWN0RMR/N9IUE6iVmuVigstDkDac4KaRuw9LKVApAQSw9Gmm/4lezqs0Pmraw0Lao BHMgdieIa9wLOsqoK3b68RL7QPcqJyvvA5hQPdzyN5i+Yod3hp4G1w1i+kA/aaLchhnKk n92pXaIB2L8IQo99ckFLjKS7h6S8tS92Lw7v/UFxzSpRhE2sx8QM5NwSQkFMBDwpHWQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792834850; h=DMARC-Filter:Received:DKIM-Signature:Received:Received: DKIM-Signature:X-Google-DKIM-Signature:X-Forwarded-Encrypted: X-Gm-Message-State:X-Gm-Gg:X-Received:X-Received:Received:From:To:Cc: Subject:Date:Message-Id:X-Mailer:In-Reply-To:References:MIME-Version: Content-Transfer-Encoding:X-Proofpoint-GUID:X-Authority-Analysis: X-Proofpoint-Spam-Info:X-Proofpoint-Spam-Details-Enc: X-Proofpoint-ORIG-GUID:X-Proofpoint-Virus-Version: X-Proofpoint-Spam-Details; bh=jgkKAewrB4ulG7W0OsxbbjajcwrjHSByS/uUqiEtUBA=; b=xyfwsXxljdNtrYbgQ6dADYnRlbyOhoArRMZ11pz0RMResNk28VK3MZLaW4w71J2FbTxB DXQwmy188l7CZ1Se5Kav6kbC+e+O9xfGFPLAJYCA26PcyUtc9XOPuZrLuyJT42V/qlBVj 54WXXj0OnQ6Fu3OwpxbL2UW+D3z81kKhHrzJkhoqB3Ra6oBWfYgDqXt6YKDKsk1HvauQq 1VyZPuadirzv4SJg2qY2GsiiknkR+AqiIiU++C3+Vg7ttUL5os8R3kHnCrNhhxCKC5o52 1y4OwCseXtGAQEp7JLP9+DAve/5/XWLVxP7f68YiUs/WavOMHOaM6mHjqDYSuQGobzQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=bV2dsHZy; dkim=pass header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=DxlxblOh; arc=none smtp.remote-ip=205.220.180.131 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8B3EB606A327 for ; Sat, 24 Oct 2026 09:40:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 8B3EB606A327 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=bV2dsHZy; dkim=pass (2048-bit key, unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=DxlxblOh Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 69O8nx0R1706862 for ; Sat, 24 Oct 2026 09:40:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=jgkKAewrB4u lG7W0OsxbbjajcwrjHSByS/uUqiEtUBA=; b=bV2dsHZyZzUoDGgwcjLHfW8u83D 2dlCetRtENgZEMXvNJJC1quy/HlLmoU+U/b2KD/jkLs1wScM8yymKNnqmfJNfIaN nI9uc/9lHloewTlXfxdGZ9FcD3ade2GUb7tATr0H8qa1P/4DaJrqamMp7kwfbQHw okVr6LK5c7ZmdqNPe0gIzhJCc75p4FTlbY+EGPveP5Oc1YZ8VNNRUap7xV40y21I ejTNbNt2jI0WW+nqdcG8rGxmdIYYFJAq2c/D9UqS56jDsw8KyzlfgLAC9dcAGKO+ SflHWKCuFoFPIp7kNYGy7rzyOJYq464ewewWjdKMgYYU+ZkogHs4GfWR0Cw== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4hgm8xgq6w-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sat, 24 Oct 2026 09:40:48 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-93f37c94ceeso550005985a.1 for ; Sat, 24 Oct 2026 02:40:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1792834848; x=1793439648; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=jgkKAewrB4ulG7W0OsxbbjajcwrjHSByS/uUqiEtUBA=; b=DxlxblOhLHvp4MaG161aY4QO6x5YZw99Va7zhiIX8TfLZGWg23aecNLwBO6Y0SGy41 ZiPVeGXncpi+rAYP2AYgx53PBfZ1v88anUzWGDvLMmdH2IlLZqXgzQ1C5q31Y8UKrTvm snoDXUNkatne8txlJZI3gf42A3Jt2yNqHCbLJdG5UzKj4KDzjMu6uFfj8eq0B/zKYeJr rpwtrShBPSv3HCP+PO6OPSghEWWGUEQapSoMTaEL/1M6nOq12csZBRbqJPPamm1khV6m i2PZcXXWke+1dLXXH0IlWdR1ZGJQu6FDrra7E2K1vFomNFd+e8y74ghn7Y9AX5tK8qvT L7rQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792834848; x=1793439648; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=jgkKAewrB4ulG7W0OsxbbjajcwrjHSByS/uUqiEtUBA=; b=c4juCr3RVPcLxpEPUrmFE+q3mWHbYVipPAHd01dyPZueEjtplElyUNq+O+T7YuP2eI RYnwJ+792WdUuVLExzMiLc0m1jhFboUTY4Oj+9u+TLTWsNvfphoSqxOMOlpzMVyZWW8S dN1RRUOp6MuuTzg2MDNaXwe6qjlqgHqI2cthSLVwc9lNAhLVMVMt3jt445sOMtv89hJT JKNJbiYiIckbgtomi89hB/sBi0HU10ELiAQIQHedVCmwiQumoA4Sfk2tDeWoM1MH6dr8 PS9XqknnE0aT1uA3Al+J90bIrr3UQraO8ddgf0knWA7TqKHb6xPHpVVWqazAmYz/hphN 6nVQ== X-Forwarded-Encrypted: i=1; AKwUvBwn3/eYHFtjoxULJd+/RXkkOtRSX8eaVg1wl9Zjw0PJnb7VrZVzJrYeyFeWMBn6Di6NV8tKjCalqyiRTpY=@vger.kernel.org X-Gm-Message-State: AFq9FYKqPjsJubJMWVr6fLJHKfGfSzpCuKElEldIram/y3O0Fab3zWW1 hMoq4oXdQZxiPj5O2GkIBirEZB2sEbp5Xt0jdgA8reA8a7WoOF3pqvOssr1tOVJWgf+pdCSD1Og iHkg1hUM3T85famvUg7hR2w4GqKcsmdVzFw0rGbSw3DvvpSXHGkf+rJQcwO7dRsc/n88= X-Gm-Gg: AYBFou1KfGkwkRNuDflt8pIId7YWoeZ+umFT/z7acpoWTu9gbCR47pYp0EXt14QbLHv FxoDet1N2tSaggx4AFONpT7HvZIUlS5WIwjSKb4Qy5nfz7kugCWZElFaV3M1yr26MfQZb5ckywc V0xj4U/r9tKLUdS+zCHUuTzJkf1Rx1sb23JfqxvFJNBzYLHJC+G5JoLmk4qNhkkpDfGtj2rYLwX FD7KWqPAyhk9dOWGYZKUV+zc/LDqFjDWEW3qC/81LBL4wVZk3EVYWo9hQ8mV+Ry55NGemQzNz79 60t5vYWklnCnGKFijjNNqrhXz/UgMNxwEo/O4dK3IIk0WQs2eg3z6SJoSdmYNg6VNiR/aXId3Ik OCYcw57FYMO0UyT7bMnqjfDq8 X-Received: by 2002:a05:620a:401:b0:93f:4a02:ed99 with SMTP id af79cd13be357-940ef956f57mr143096385a.20.1792834847724; Sat, 24 Oct 2026 02:40:47 -0700 (PDT) X-Received: by 2002:a05:620a:401:b0:93f:4a02:ed99 with SMTP id af79cd13be357-940ef956f57mr143094685a.20.1792834847230; Sat, 24 Oct 2026 02:40:47 -0700 (PDT) Received: from lin-0772.qualcomm.com ([212.136.9.4]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48e3ebc3bcdsm2857166f8f.13.2026.10.24.02.40.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 24 Oct 2026 02:40:46 -0700 (PDT) From: Atanas Filipov To: Bryan O'Donoghue , Mauro Carvalho Chehab Cc: atanas.filipov@oss.qualcomm.com, Vladimir Zapolskiy , Loic Poulain , Gjorgji Rosikopulos , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 6/6] media: qcom: camss: sm8250: set the camera NoC AXI rate from the VFE Date: Sat, 24 Oct 2026 12:40:27 +0300 Message-Id: <20261024094027.3095475-7-atanas.filipov@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20261024094027.3095475-1-atanas.filipov@oss.qualcomm.com> References: <20261024094027.3095475-1-atanas.filipov@oss.qualcomm.com> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: vOEyHg1rcjkGThNyWzbpzV7bUtpttono X-Authority-Analysis: v=2.4 cv=Ra0FmFtv c=1 sm=1 tr=0 ts=6adc7d20 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=dNlqnMcrdpbb+gQrTujlOQ==:17 a=660iZSQnnn4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=FiRPRoyJa4ALD98OXUAA:9 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-Spam-Info: AW1haW4tMjYxMDI0MDAzOCBTYWx0ZWRfXwmh3htnwxEXg zJAqjmGXGT3LLigE3NJRQ2tKaePrRqhndjXp/uAayFHMUrE15E0iQarpEPbs7l7gbcR6aIh0K0o JsfSa0jfFvSd8cMOajwgMFRE5cW4Rao= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDI0MDAzOCBTYWx0ZWRfX9tcfwLI8Rv4i VRu6MCEiFbMugs08dgB4a2PxqLwV7ZlhoaWgeUHwAlV2Ra+JOy7x9ehCQL0KNT/R2YcoztwZFOI GikaD27IrsEBpzMF2Z8Uelbem9g7Z/a83zO4s0UiiTxLezlqu49WGbt1vPSW2jUzBEG1eDXo0zv 1DC35Ld4E8c2rJ6sP+a9ldxAwz7tLz0heyJANCxouEJzs3L6oDYtDEsMHrAR7C7zGhuHYlQlkEG Gq9q/PIH5azEVoxhzMB+1KEOZg2ACzsWPhgZ7+KeyzwcYlpVUc6cI7+2i5pnnvnJaIXa+mRobc4 yaCcyN8qyIfs4VsICBhQ0/z02JxVkkze8WQDWNoSO+yCZ4hHTRFjQ8foZifKGujrCjgYN2xghAB rERTulQMAla4+pVoaQ84xqHE0JTUPiO/50U5ofUp7t1L5gGf71+63zmpRYLiB7EmwzSmayO99Os 3ZY9vpkqQ9TFdd8Ib1A== X-Proofpoint-ORIG-GUID: vOEyHg1rcjkGThNyWzbpzV7bUtpttono X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.138,FMLib:17.12.100.49 definitions=2026-10-24_01,2026-10-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 adultscore=0 impostorscore=0 phishscore=0 lowpriorityscore=0 priorityscore=1501 suspectscore=0 bulkscore=0 malwarescore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2610190000 definitions=main-2610240038 The SM8250 VFE resources list both the camera NoC AXI RCG, camnoc_axi_src, and its camnoc_axi branch. The camnoc_axi_src levels are never applied, since vfe_match_clock_names() does not match that name, and they list 480 MHz, which the RCG does not support. The camnoc_axi branch has no rates, so the camera NoC runs from XO and two concurrent streams stall. Drop camnoc_axi_src, as the camnoc_axi branch keeps it enabled through its parent, and list the 300 and 400 MHz camera NoC AXI rates for the camnoc_axi branch, whose rate the VFE sets through the parent. The four VFEs share its source through a clock domain, so it runs at the highest rate requested by the running VFEs. Signed-off-by: Atanas Filipov --- drivers/media/platform/qcom/camss/camss.c | 28 ++++++++++------------- 1 file changed, 12 insertions(+), 16 deletions(-) diff --git a/drivers/media/platform/qcom/camss/camss.c b/drivers/media/platform/qcom/camss/camss.c index 100612d97fa7..9bfb634ee9f7 100644 --- a/drivers/media/platform/qcom/camss/camss.c +++ b/drivers/media/platform/qcom/camss/camss.c @@ -2120,13 +2120,12 @@ static const struct camss_subdev_resources vfe_res_8250[] = { /* VFE0 */ { .regulators = {}, - .clock = { "camnoc_axi_src", "slow_ahb_src", "cpas_ahb", + .clock = { "slow_ahb_src", "cpas_ahb", "camnoc_axi", "vfe0_ahb", "vfe0_areg", "vfe0", "vfe0_axi", "cam_hf_axi" }, - .clock_rate = { { 19200000, 300000000, 400000000, 480000000 }, - { 19200000, 80000000 }, + .clock_rate = { { 19200000, 80000000 }, { 19200000 }, - { 0 }, + { 300000000, 400000000 }, { 0 }, { 100000000, 200000000, 300000000, 400000000 }, { 350000000, 475000000, 576000000, 720000000 }, @@ -2146,13 +2145,12 @@ static const struct camss_subdev_resources vfe_res_8250[] = { /* VFE1 */ { .regulators = {}, - .clock = { "camnoc_axi_src", "slow_ahb_src", "cpas_ahb", + .clock = { "slow_ahb_src", "cpas_ahb", "camnoc_axi", "vfe1_ahb", "vfe1_areg", "vfe1", "vfe1_axi", "cam_hf_axi" }, - .clock_rate = { { 19200000, 300000000, 400000000, 480000000 }, - { 19200000, 80000000 }, + .clock_rate = { { 19200000, 80000000 }, { 19200000 }, - { 0 }, + { 300000000, 400000000 }, { 0 }, { 100000000, 200000000, 300000000, 400000000 }, { 350000000, 475000000, 576000000, 720000000 }, @@ -2172,13 +2170,12 @@ static const struct camss_subdev_resources vfe_res_8250[] = { /* VFE2 (lite) */ { .regulators = {}, - .clock = { "camnoc_axi_src", "slow_ahb_src", "cpas_ahb", + .clock = { "slow_ahb_src", "cpas_ahb", "camnoc_axi", "vfe_lite_ahb", "vfe_lite_axi", "vfe_lite", "cam_hf_axi" }, - .clock_rate = { { 19200000, 300000000, 400000000, 480000000 }, - { 19200000, 80000000 }, + .clock_rate = { { 19200000, 80000000 }, { 19200000 }, - { 0 }, + { 300000000, 400000000 }, { 0 }, { 0 }, { 400000000, 480000000 }, @@ -2196,13 +2193,12 @@ static const struct camss_subdev_resources vfe_res_8250[] = { /* VFE3 (lite) */ { .regulators = {}, - .clock = { "camnoc_axi_src", "slow_ahb_src", "cpas_ahb", + .clock = { "slow_ahb_src", "cpas_ahb", "camnoc_axi", "vfe_lite_ahb", "vfe_lite_axi", "vfe_lite", "cam_hf_axi" }, - .clock_rate = { { 19200000, 300000000, 400000000, 480000000 }, - { 19200000, 80000000 }, + .clock_rate = { { 19200000, 80000000 }, { 19200000 }, - { 0 }, + { 300000000, 400000000 }, { 0 }, { 0 }, { 400000000, 480000000 }, -- 2.34.1