mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Karl Mehltretter <kmehltretter@gmail.com>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: Karl Mehltretter <kmehltretter@gmail.com>,
	Thierry Reding <thierry.reding@kernel.org>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	linux-pci@vger.kernel.org, linux-tegra@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH] PCI: quirks: Skip nv_msi_ht_cap_quirk when host bridge 00:00.0 is absent
Date: Sat, 24 Oct 2026 19:24:26 +0200	[thread overview]
Message-ID: <20261024172426.85842-1-kmehltretter@gmail.com> (raw)

__nv_msi_ht_cap_quirk() runs on all PCI_VENDOR_ID_NVIDIA devices to
enable or disable HyperTransport MSI mapping relative to a host bridge
at bus 0, slot 0, function 0.

On NVIDIA Tegra SoCs (such as Tegra210 on Jetson Nano), the PCIe
controller exposes root ports at 00:01.0 and 00:02.0 with no device at
00:00.0, and the root port's HT MSI mapping capability is already
disabled (found == 1). Looking up 00:00.0 returns NULL and logs a
false-positive warning on every boot:

  pci 0000:00:02.0: nv_msi_ht_cap_quirk didn't locate host bridge

Return silently when no 00:00.0 device exists on the domain, matching
nv_ht_enable_msi_mapping().

Assisted-by: LLM
Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>
---
Observed on a Jetson Nano 4GB (Tegra210, p3450-0000) booting v7.3
(c03c1a14507d), where the Tegra PCIe controller (1003000.pcie)
enumerates the active root port at 0000:00:02.0 ([10de:0faf]) with no
0000:00:00.0 device on bus 00:

  pci 0000:00:02.0: [10de:0faf] type 01 class 0x060400 PCIe Root Port
  pci 0000:00:02.0: nv_msi_ht_cap_quirk didn't locate host bridge

 drivers/pci/quirks.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
index 1aa87a3..47778c1 100644
--- a/drivers/pci/quirks.c
+++ b/drivers/pci/quirks.c
@@ -3115,10 +3115,8 @@ static void __nv_msi_ht_cap_quirk(struct pci_dev *dev, int all)
 	 */
 	host_bridge = pci_get_domain_bus_and_slot(pci_domain_nr(dev->bus), 0,
 						  PCI_DEVFN(0, 0));
-	if (host_bridge == NULL) {
-		pci_warn(dev, "nv_msi_ht_cap_quirk didn't locate host bridge\n");
+	if (!host_bridge)
 		return;
-	}
 
 	pos = pci_find_ht_capability(host_bridge, HT_CAPTYPE_SLAVE);
 	if (pos != 0) {

base-commit: c03c1a14507dfaf8b856c2608f9ac216021fc222
-- 
2.39.5 (Apple Git-154)


             reply	other threads:[~2026-10-24 17:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-24 17:24 Karl Mehltretter [this message]
2026-10-24 17:52 ` Nicolas Chauvet
2026-10-26 18:32   ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261024172426.85842-1-kmehltretter@gmail.com \
    --to=kmehltretter@gmail.com \
    --cc=bhelgaas@google.com \
    --cc=jonathanh@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=thierry.reding@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®