From: Greg KH <gregkh@linuxfoundation.org>
To: Himanshu Bakshi <himanshu.bakshi478@gmail.com>
Cc: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com,
linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: sm750fb: clean up PLL calculation code
Date: Sat, 24 Oct 2026 16:10:53 +0200 [thread overview]
Message-ID: <2026102447-exhale-overarch-8ce7@gregkh> (raw)
In-Reply-To: <CAGLmz9+J-s98cT_ZFHF5EU7t=beK8m82fjq20+n5dmncdrMSEQ@mail.gmail.com>
On Sat, Oct 24, 2026 at 05:20:41PM +0530, Himanshu Bakshi wrote:
> Hi Greg,
Please do not top-post or send html email, the list rejects that.
> I found this while reviewing sm750_calc_pll_value() and looking for a
> cleaner way to handle the PLL candidate calculation.
But why does it need to be "cleaner"?
> I tested the change as follows:
>
> Built the sm750fb driver successfully using make -j2
> M=drivers/staging/sm750fb W=1.
>
> Ran a standalone C differential regression test comparing the original
> and modified algorithms across 2,010,084 test cases, including
> frequency sweeps, boundary values, and randomized requests.
Ah, you used a LLM. You have read:
https://lore.kernel.org/r/2026080354-skater-urgent-31b2@gregkh
right?
Sorry,
greg k-h
next prev parent reply other threads:[~2026-10-24 14:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-24 7:35 himanshu bakshi
2026-10-24 8:02 ` Greg KH
2026-10-24 11:50 ` Himanshu Bakshi
2026-10-24 14:10 ` Greg KH [this message]
2026-10-24 14:26 ` Himanshu Bakshi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026102447-exhale-overarch-8ce7@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=himanshu.bakshi478@gmail.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=sudipm.mukherjee@gmail.com \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®