From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.214.180 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792910445; b=sYF7174+cPisoByPnZ/i6BGEV7LtgzMVrDqKEA13MQKMm3TGdvA1v33t9AN90Ybnk023 bg+Ej4SdKVg+6iVdGcqXd3WZLBesZLUfPZ5oEslQ6xg3YJZ/qyJ9lbhvBaiX7BPiUbD+y SzgHIWFye0orxihpCXZ4y19q+ZlZ8l7R6nM15edGqaKR6++ZJnP4yOKw9rMltmsUVHFKX fJ4/GCgiFdUezGirUAWgJr4w3+mV7ROimKeg7BgIpmMtEUoYUy1yBLnSuOlyJyg6mf+sx D0aNkKDNiSc0mXQIXM3EpqUqX1ZDVunlxh4ungL1y+cqy6jnwzJL4R+5yc3QnuFaayw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792910445; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: From:To:Cc:Subject:Date:Message-ID:X-Mailer:MIME-Version: Content-Transfer-Encoding; bh=ZOE0jx7namuFNQAILgAyIxxvCrkDcwa5wtjwYyQxQgg=; b=C3aaxmyKoyRlgaqcCXZY7L+mFRZlt8TveaFjRsRyldBCGSpbiA8L6Ld+Mb5ahNKQDg9n XyBz5YefuN36I8RiqehoOpVTKOlsYDV2H6wxe5zi5M5FpWNTed/DuSmW/YQDYWciJr0ae AFxJX+4vuuCBaAxH4G//WSV0mN4DV4e4tKvba9ccMME17r/1+CLVJzpLG3jO52KCO7Tsw UAqWy7pRyPdXncmeGEoyw6B/n7s4kFFMZSfoevkPyPwYXotckC7jQGIVs/rT/ebzwLYhm BEfBSXHUYIjovGJKUZY+TFjLf9K7ep/N5avVOldswYePD7xKloiOo1V1j9dp+tqeQ6g== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=rGKp3xU2; arc=none smtp.remote-ip=209.85.214.180 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 493A9606A31D for ; Sun, 25 Oct 2026 06:40:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 493A9606A31D Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=rGKp3xU2 Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-2e9d1114320so15634575ad.3 for ; Sat, 24 Oct 2026 23:40:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1792910444; x=1793515244; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=ZOE0jx7namuFNQAILgAyIxxvCrkDcwa5wtjwYyQxQgg=; b=rGKp3xU2NC6YEtRR3huA75NNHVkNlWKHf1KFnq5kzOzB2ctLNFsFtXlnlIQKgJ7u0J 39Ld9aHK+40aFkDkB28K+hHHV1931kzh7feIY6mynV+qajimNxqFPLj8FOyKsC85tGnd h9FvnsBRHRe6eqYx15mHPfCBELdZrKExI29h9kTqYG0ZByx6AXJ004rI8XxO3Ax+fQYC sjYVC9I0fN55y7/9cBKPQCOXPLjC3dvYb1wjknudYYfUmIW4KmLNfEGitBFeYrraigJN reH3H4LFq/L0Q92b6X3Fq0+cM/atrr6z71l3HRkgakJICYGtZmCARd9r92ds5LSDl28K dmlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792910444; x=1793515244; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ZOE0jx7namuFNQAILgAyIxxvCrkDcwa5wtjwYyQxQgg=; b=wqIW+513Q9yzOkmWT0VFj//kBt6oB9m2mJmhsqCLEoQguA5cRKKniFJ6arr+JYvLnG n2QOpl+3Z1nefLRM2xxrYwqIzV1GlGvJuI3D3qtpqEs8/nNbrqn+wLG8zmseFSYCdcsE I7XBO0tc8KNViqD0qsBW8NRB8cyKUr6K1g1dyBI2ur+co623yLV4u6wLLMp3Elb9DZSb BbDEQXw7lUgpJujbjKpUjKYnoHIl2SXoCr7xaisCF+xlgPYZHaBb/GJWvaZIYXPvANy5 CfDgs1eCbhiLgDVKjTMVNNTtqVMGdjqLrhV/Ns3crQwQR6WxMPD2L0tbZNrIrwfwEgZq NRxQ== X-Forwarded-Encrypted: i=1; AKwUvByPzQqV29l+H2CfrvTg5KBo0rIl5oKBfzGmppODtV2mUI+hlOoruIHEh9B+NLRgEjunuDEwMZrJa4fCtPA=@vger.kernel.org X-Gm-Message-State: AFq9FYJb95Ok+l7TCP27MEGRmu5K3XmQPxoEJd9XkmLkOfO3Jo+l+oWp LVaRkJm6xLbnC34RHa5Rtb1rpnSvIGleSxbU7ey4XeaUbpUpQKeYPh2G X-Gm-Gg: AYBFou0RugvMRvAUfbGbMnDPrHuVsNTi0Hm7FcpPMtlTO4y3UAs5NR7JJExQEPTjzAZ pel2KbRWVSgTWoCL+EyxIrNdhB/dA+WBvtFF/VjmshzmrmtITamXR2sdCU26g9hYfRT3qXQpgu2 o4qmUxzckqqLHFluLzn9NRnjiHrfIFsNdHw3BxI2KD1XbjxTuyF2OGn9BxJWTuJ4T+wRiRmVi3o nIW4zYsexIM8iW4QuxzAy4r4v8V0BGw7tVz6VxKyBv+PJeoz45hhMfHm9Fa6xagt3s0Sdg0ZhYG gZseFkrb6H7iA0nxCMY0i5exvc9WDapk/FH4pRe6ET1PmoHq8VMBxhDMETz1R7YuD9ad4jAfRy3 QygG+fElmY2aQlleEasr8zBUiW0kr7AdVrEO+yWK4OSxkfGw1gac81huXrqrClhJ28ZtoMBr0n+ kMZiRRKXtoL8+L0SJflcSmpoOFy7hZmkrQKEdNwFY9kbntUSQpVmObYenEPjY5URzhO2sFxVS1C bmaEm6gOtuj8pX5BsLlSNvtaeJ8URKqvByt/ju8VG3LPcyVi3Wm8QtFwTqNm7eYU9DHqKlZfOPl Hn/P6FhGsBXWguWrkweQQH342Nmx8nvdlX70nARvJcdsH49qCGdInm50pNuIzNRU6Ixsl3cT X-Received: by 2002:a17:90b:50cb:b0:3ab:413:49b1 with SMTP id 98e67ed59e1d1-3adeaffa088mr3030302a91.48.1792910444439; Sat, 24 Oct 2026 23:40:44 -0700 (PDT) Received: from localhost.localdomain ([180.182.24.11]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3adebbb2fb2sm4462670a91.1.2026.10.24.23.40.41 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sat, 24 Oct 2026 23:40:42 -0700 (PDT) From: Joonho Lee To: linux-sound@vger.kernel.org Cc: perex@perex.cz, tiwai@suse.com, anton.yakovlev@opensynergy.com, mst@redhat.com, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v4 0/2] ALSA: virtio-snd: fix dsnoop capture with staged buffers Date: Sun, 25 Oct 2026 15:40:36 +0900 Message-ID: <20261025064038.81674-1-mynameisjune111@gmail.com> X-Mailer: git-send-email 2.54.0 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hi, Changes in v4: * Arm synchronous stop before paused capture enters XRUN through ACK or period work, so recovery releases pending RX requests before prepare. * Add read/forward ACK regressions for first-prepare recovery and direct close/reopen, with native pause and pause-restart on one and two vCPUs. * Keep patch 1 and the prerequisite metadata unchanged. Sashiko identified a missing cleanup path in v3 patch 2: https://sashiko.dev/#/patchset/20261025055702.69259-1-mynameisjune111%40gmail.com?part=2 Previous version: https://lore.kernel.org/all/20261025055702.69259-1-mynameisjune111@gmail.com/ This series fixes dsnoop capture on top of the staged-capture virtio-snd changes. dsnoop configures its slave with stop_threshold == boundary and can keep capture running without advancing the slave application pointer as an ordinary reader would. The staged-capture accounting currently exhausts its bounded unread capacity in this configuration. The first patch marks stop_threshold accesses used by the driver's policy sampling. READ_ONCE/WRITE_ONCE provide single-access annotations; the virtio-snd state transitions remain protected by the substream lock. The second patch caches the prepared boundary and samples the stop policy under that lock. A completion uses one sampled policy for validation, copying and queue refill. Free-running capture keeps requests queued and retains the existing frame, payload and pointer-window checks. Returning to bounded capture restores unread accounting from the monotonic counters. If the outstanding data already fills the ring, the policy helper returns -EPIPE without changing the cached mode or counters. The detecting RX, pointer or ACK path then reports XRUN through its existing error path. Native pause-release refill failures schedule the period worker to move a paused stream to XRUN and wake capture waiters. This does not guarantee a synchronous error from the sw_params ioctl. The ACK accounting and subsequent queue refill each sample the policy under the appropriate locks. Prepare and teardown reset the cached state. The existing ACK-race and priority changes are prerequisites to this series and are excluded from these two diffs. New testing for v4: * v3 reproduced -EPIPE from paused read/forward ACK, followed by -EBADFD on the first prepare in both native pause and pause-restart modes. * The corrected module passed 16 combinations of ACK operation, recovery route, pause mode and vCPU count under ARM64 QEMU with KASAN/lockdep. Prepare recovery uses the first prepare without an intervening drop. Recovery and reopening each capture 48,000 frames. * The native-pause regression and 13-case mode suite also passed. No KASAN or lockdep diagnostics were recorded in the six final VM runs. * Direct close/reopen succeeded even on v3 in this fixture; these results establish the prepare regression, without establishing a persistent buffer leak across close. Forced RX/pause interleaving, new physical microphone tests and KCSAN reruns were not performed for v4. Earlier testing for v3: * ARM64 QEMU with KASAN and lockdep, native pause: v2 returned -EPIPE but stayed PAUSED, and a waiting poll timed out. The corrected module reached XRUN, woke poll with POLLERR and returned -EPIPE from read. Prepare recovery and reopening each captured 48,000 frames. The corrected case passed with both one and two vCPUs. * The 13-case mode suite passed with the corrected module, including direct and mmap capture, policy transitions, delayed-reader recovery, reopening, mixed-rate dsnoop readers and client departure. KASAN and lockdep reported no diagnostics in these runs. The following testing was performed on v2 before this focused change: * ARM64 QEMU synthetic dsnoop capture: 12 files and 2,160,000 frames matched the reference sequence from each client's observed starting position. All 48 corruption, loss, duplication and reordering controls were detected. * Default KCSAN: 13/13 cases and 619 policy transitions passed without race or lockdep reports. Forced RX/ACK policy changes and four isolated policy-helper branches passed under KASAN and KCSAN. * macOS VZ with MOTU UltraLite-mk5 at 48 kHz: comparisons used one or two vCPUs and idle or CPU-saturated guests. The baseline failed all 32 shared-client captures. The candidate passed 48 captures and eight recovery diagnostics, including mixed-rate sharing, client departure, reopening and recovery after an intentionally delayed reader. Loaded shared captures ran for 70 seconds. All eight accepted VM runs shut down on the first request. The physical tests checked frame counts and nonzero input. Exact sample continuity was checked with the QEMU synthetic source. VZ exposed mono; these tests do not establish physical input-channel routing or multichannel support. Aggressive KCSAN still produced dsnoop client-threshold XRUNs with a 160 ms buffer. Further isolation supports a deadline sensitivity, but does not exclude every kernel timing contribution. Separate generic KCSAN reports remain recorded in the test evidence. This series depends on the staged-capture prerequisite stack below. The tested local base is 8d0d4c1a6c4bcb81ae9f52d1c0d979fafb2e22f2, consisting of nine prerequisite patches above sound.git commit 5618f6837ef3314e2c581d4c05ec13b7ed975cb4. Prerequisites, in application order: 1-5. Lifetime and error recovery v3: https://lore.kernel.org/all/cover.1791881787.git.mynameisjune111@gmail.com/ 6. Generic teardown/control wait v2: https://lore.kernel.org/all/rfc-v2-generic-control-wait-0.2eddd58a796e497f@gmail.com/ 7. VZ staged capture v2: https://lore.kernel.org/all/rfc-v2-vz-capture-compat-1.b9ab4c1540dc4691@gmail.com/ 8-9. ACK accounting and high-priority period work: https://lore.kernel.org/all/rfc-virtio-snd-capture-followups-1.f2737c95c12e45b4@gmail.com/ https://lore.kernel.org/all/rfc-virtio-snd-capture-followups-2.f2737c95c12e45b4@gmail.com/ This fixes the staged-capture accounting introduced by that prerequisite stack. The reproductions do not establish the same failure in an unmodified upstream kernel. The policy uses the existing stop_threshold == boundary convention. Sampling it under the driver lock avoids introducing a PCM stream lock into RX completion. A completion overlapping a policy update may finish with the previous policy; its accounting and refill use that same sample. Rejecting a transition whose bounded accounting cannot be restored preserves explicit overflow detection and lets the caller recover the stream. Patches: ALSA: pcm: mark stop-threshold accesses for capture policy sampling ALSA: virtio-snd: fix dsnoop capture with staged buffers Thanks, Joonho --- base-commit: 5618f6837ef3314e2c581d4c05ec13b7ed975cb4 prerequisite-patch-id: 39fb327a004c966ab90f66a34a64bbdbb3ffb475 prerequisite-patch-id: 7c6bc344656fd839ae0d697ba18d66ac0b47827a prerequisite-patch-id: 9dd290ac3147fa7b49a475d7df8a6172778f2860 prerequisite-patch-id: f4c24a5e441343a690f4ac2437f181c815bc23d0 prerequisite-patch-id: ab4a5b770247a65272ab7af18a75a147daf81287 prerequisite-patch-id: cfe3e7000e695a2fda27993f4d9acf0a637cf24e prerequisite-patch-id: 771e8815f2b874d98376f309dc60bc90244f378c prerequisite-patch-id: fdea8eaa29a47360e19820e27301dd8b6b26e43e prerequisite-patch-id: 67ffb5c72970e1aeace72b6537dab1b977a3fc6c prerequisite-message-id: cover.1791881787.git.mynameisjune111@gmail.com prerequisite-message-id: rfc-v2-generic-control-wait-0.2eddd58a796e497f@gmail.com prerequisite-message-id: rfc-v2-vz-capture-compat-1.b9ab4c1540dc4691@gmail.com prerequisite-message-id: rfc-virtio-snd-capture-followups-0.f2737c95c12e45b4@gmail.com