From: Ido Schimmel <idosch@nvidia.com>
To: Cheng Yongkang <teel4res@gmail.com>
Cc: Nikolay Aleksandrov <razor@blackwall.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
bridge@lists.linux.dev, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
Horatiu Vultur <horatiu.vultur@microchip.com>
Subject: Re: [PATCH net] net: bridge: flush FDB again after unregistering the RX handler
Date: Sun, 25 Oct 2026 10:19:19 +0200 [thread overview]
Message-ID: <20261025081919.GA53797@shredder> (raw)
In-Reply-To: <179268538303.70821.8213834342995341232@gmail.com>
On Thu, Oct 22, 2026 at 08:26:49AM -0700, Cheng Yongkang wrote:
> del_nbp() flushes the port's FDB entries before it unregisters the RX
> handler. For a normal port, br_stp_disable_port() has already moved
> the port to BR_STATE_DISABLED, so no frame is learned in between.
>
> That does not hold for an MRP ring port. br_set_state() ignores state
> changes while BR_MRP_AWARE_BIT is set, so br_stp_disable_port() leaves
> the port state alone, and br_mrp_port_del() then sets the port to
> BR_STATE_FORWARDING (when the bridge is up) before clearing the bit.
Same root cause as [1] where I suggested moving br_mrp_port_del() before
br_stp_disable_port() so that the port is actually disabled. That would
also fix this issue as the port would be disabled before the
synchronize_net() in nbp_vlan_group_unpublish() and the FDB flush that
follows it. Can you test it with your reproducer?
[1] https://lore.kernel.org/netdev/20261012123051.GA714215@shredder/
prev parent reply other threads:[~2026-10-25 8:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-22 15:26 Cheng Yongkang
2026-10-25 8:19 ` Ido Schimmel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261025081919.GA53797@shredder \
--to=idosch@nvidia.com \
--cc=bridge@lists.linux.dev \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=horatiu.vultur@microchip.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
--cc=teel4res@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®