From: George Karagounis <taterraster@gmail.com>
To: Jani Nikula <jani.nikula@linux.intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Tvrtko Ursulin <tursulin@ursulin.net>,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, mail@taterr.org
Subject: [PATCH] drm/i915/dp: Remove redundant link capabilities reset
Date: Sun, 25 Oct 2026 13:32:00 +0200 [thread overview]
Message-ID: <20261025113200.25097-1-mail@taterr.org> (raw)
intel_dp_link_caps_update(reset=true) is already called prior to intel_dp_reset_link_params(), making the explicit call to intel_dp_link_caps_reset() redundant. Remove it as requested by the existing TODO comment to clean up the link parameter reset flow.
Signed-off-by: George Karagounis <mail@taterr.org>
---
drivers/gpu/drm/i915/display/intel_dp.c | 15 ++++-----------
1 file changed, 4 insertions(+), 11 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index d8c0d9381471..0e753824bc28 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -3674,17 +3674,10 @@ void intel_dp_set_link_params(struct intel_dp *intel_dp,
void intel_dp_reset_link_params(struct intel_dp *intel_dp)
{
- /*
- * TODO: Remove the following reset of link capabilities, as
- * this isn't needed after intel_dp_link_caps_update(reset=true)
- * was called.
- */
- intel_dp_link_caps_reset(intel_dp->link.caps);
- intel_dp_tunnel_uhbr_lanes_wa_apply(intel_dp);
-
- intel_dp->link.mst_probed_lane_count = 0;
- intel_dp->link.mst_probed_rate = 0;
- intel_dp_link_training_reset(intel_dp->link.training);
+ intel_dp_tunnel_uhbr_lanes_wa_apply(intel_dp);
+ intel_dp->link.mst_probed_lane_count = 0;
+ intel_dp->link.mst_probed_rate = 0;
+ intel_dp_link_training_reset(intel_dp->link.training);
}
/* Enable backlight PWM and backlight PP control. */
--
2.56.0
next reply other threads:[~2026-10-25 11:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-25 11:32 George Karagounis [this message]
2026-10-27 16:01 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261025113200.25097-1-mail@taterr.org \
--to=taterraster@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mail@taterr.org \
--cc=rodrigo.vivi@intel.com \
--cc=tursulin@ursulin.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®