From: Ido Schimmel <idosch@nvidia.com>
To: David Corvaglia <david@corvaglia.dev>
Cc: netdev@vger.kernel.org, bridge@lists.linux.dev,
Nikolay Aleksandrov <razor@blackwall.org>,
Horatiu Vultur <horatiu.vultur@microchip.com>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] bridge: mrp: fix silent truncation of IN_ID
Date: Sun, 25 Oct 2026 14:09:11 +0200 [thread overview]
Message-ID: <20261025120911.GA156077@shredder> (raw)
In-Reply-To: <20261023014536.72444-1-david@corvaglia.dev>
On Thu, Oct 22, 2026 at 06:45:36PM -0700, David Corvaglia wrote:
> IFLA_BRIDGE_MRP_IN_STATE_IN_ID and IFLA_BRIDGE_MRP_START_IN_TEST_IN_ID
> are NLA_U32, but these values are stored as u16 in their respective
> structs. Values above U16_MAX are silently truncated instead of being
> rejected.
>
> Fixes: 7ab1748e4ce6 ("bridge: mrp: Extend MRP netlink interface for configuring MRP interconnect")
> Signed-off-by: David Corvaglia <david@corvaglia.dev>
If anything, this belongs in net-next. Better to drop it completely
given that this issue doesn't bother anyone and that we're going to
deprecate MRP and CFM.
Also, you're expected to reply to the automated message from
netdev-bot+sinfo@kernel.org.
prev parent reply other threads:[~2026-10-25 12:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-23 1:45 David Corvaglia
2026-10-23 1:47 ` netdev-bot+sinfo
2026-10-25 12:09 ` Ido Schimmel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261025120911.GA156077@shredder \
--to=idosch@nvidia.com \
--cc=bridge@lists.linux.dev \
--cc=davem@davemloft.net \
--cc=david@corvaglia.dev \
--cc=edumazet@kernel.org \
--cc=horatiu.vultur@microchip.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®