From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Aditya Nagar <dev.adityanagar@gmail.com>
Cc: Andy Shevchenko <andy@kernel.org>,
linux-staging@lists.linux.dev, linux-fbdev@vger.kernel.org,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: fbtft: remove unused argument from FBTFT_SPI_DRIVER()
Date: Sun, 25 Oct 2026 06:55:34 +0100 [thread overview]
Message-ID: <2026102519-polymer-gorged-bc90@gregkh> (raw)
In-Reply-To: <20261025052136.389541-1-dev.adityanagar@gmail.com>
On Sun, Oct 25, 2026 at 10:51:36AM +0530, Aditya Nagar wrote:
> The _compatible argument of FBTFT_SPI_DRIVER() is never used in the
> macro body. The device tree match table is created separately by
> FBTFT_DT_TABLE() in both callers, FBTFT_REGISTER_DRIVER() and
> FBTFT_REGISTER_SPI_DRIVER().
>
> Drop the argument and update both callers. No functional change.
>
> The argument has been unused since the macro was introduced in commit
> c222ea5d2f33 ("staging: fbtft: Deduplicate driver registration macros").
>
> Found with checkpatch.pl (MACRO_ARG_UNUSED). The change was prepared
> with the help of an AI coding assistant (Claude); I reviewed it and
> build-tested all fbtft drivers with W=1.
>
> Signed-off-by: Aditya Nagar <dev.adityanagar@gmail.com>
Sorry, but please read:
https://lore.kernel.org/r/2026080354-skater-urgent-31b2@gregkh
next prev parent reply other threads:[~2026-10-25 5:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-25 5:21 Aditya Nagar
2026-10-25 5:55 ` Greg Kroah-Hartman [this message]
2026-10-25 6:00 ` Aditya Nagar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026102519-polymer-gorged-bc90@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=andy@kernel.org \
--cc=dev.adityanagar@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®