mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Navon John Lukose <navonjohnlukose@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Lee Jones <lee@kernel.org>
Cc: "Mika Westerberg" <mika.westerberg@linux.intel.com>,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
	mfd@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: [PATCH v3] mfd: intel-lpss: Set d3hot_delay to 0
Date: Mon, 26 Oct 2026 01:06:13 +0530	[thread overview]
Message-ID: <20261025193613.278610-1-navonjohnlukose@gmail.com> (raw)

Every runtime resume of an LPSS controller waits the default 10 ms
d3hot_delay in pci_power_up() for the D3hot->D0 transition. Nothing
misbehaves, but the wait adds latency. On Arrow Lake-H (Lenovo Yoga Pro 7
14IAH10) the touchpad's I2C controller autosuspends after 1 s idle, and
the i2c-hid interrupt handler for the first report afterwards takes
12.6-14.4 ms.

The PCI spec asks for those 10 ms, but Mika Westerberg pointed out that
the LPSS controllers are not really PCI-connected devices, so the delay
is likely not needed. intel-lpss-pci already clears d3cold_delay,
quirk_remove_d3hot_delay() drops d3hot_delay on several older Intel
chipsets, Cherry Trail among them, and commit 815b4448198f ("i3c:
mipi-i3c-hci-pci: Set d3hot_delay to 0 for Intel controllers") does the
same for the Intel I3C controllers.

Set d3hot_delay to 0 as well. The handler above then takes 1.1-1.9 ms,
with no I2C errors. Only Arrow Lake-H was tested.

Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Signed-off-by: Navon John Lukose <navonjohnlukose@gmail.com>
---

Notes:
    Changes in v3:
    - Describe the delay first, then why it is not needed (Ilpo).
    - Give Mika's full name (Ilpo).
    - Add Mika's Acked-by.
    
    Changes in v2:
    - Drop RFC and add the review discussion to the changelog (Andy).
    
    v2: https://lore.kernel.org/r/20261022040453.45797-1-navonjohnlukose@gmail.com
    RFC: https://lore.kernel.org/r/20261016114347.23633-1-navonjohnlukose@gmail.com

 drivers/mfd/intel-lpss-pci.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mfd/intel-lpss-pci.c b/drivers/mfd/intel-lpss-pci.c
index 63a3fb58566..5672f033e5c 100644
--- a/drivers/mfd/intel-lpss-pci.c
+++ b/drivers/mfd/intel-lpss-pci.c
@@ -70,6 +70,7 @@ static int intel_lpss_pci_probe(struct pci_dev *pdev,
 		info->quirks = quirk_pci_info->driver_data;
 
 	pdev->d3cold_delay = 0;
+	pdev->d3hot_delay = 0;
 
 	/* Probably it is enough to set this for iDMA capable devices only */
 	pci_set_master(pdev);
-- 
2.56.0


                 reply	other threads:[~2026-10-25 19:36 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261025193613.278610-1-navonjohnlukose@gmail.com \
    --to=navonjohnlukose@gmail.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=lee@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mfd@lists.linux.dev \
    --cc=mika.westerberg@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®