From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=95.215.58.63 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792972372; b=riEL/V7wreuPGLphyoj+ksJXIRNPoxw3eCKthrOsry010iqF56NJhv7ID6rKEzrXWVkY CxmoYMvifiwoWxncQut9ja6Jczvt3DnnW6W2HfCwxT/Szsgo2tEvXjkdqKoYVJ8PZVwLz 6zJi9ePHQonS+nQemrNPbCGvU/R3NVOsy7iWLD/+jnsyIbAMSMRqpACsscYxWxOKmJb9h npu7vfVt8mUbQqEeG3gZdUlBh6yk38OaRZ4jxjOe0wSGmhVgFI8SlgYkpBTqf+2rwSAKn 26STD2KTNiosCuNm5h7AsozPiLQyKQvAVBtPeOK3a29QJ3ltdEU4muzX3nb7vQgZd7A== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792972372; h=DMARC-Filter:X-Envelope-To:DKIM-Signature:X-Envelope-To:Received: X-Mizu-Trace-ID:X-Migadu-Flow:From:To:Cc:Subject:Date:Message-ID: X-Mailer:In-Reply-To:References:MIME-Version: Content-Transfer-Encoding; bh=A8+5xn8MmcAr5yfNkhTY3jdrc0eSEbE+561MxjuSoPg=; b=rRW5qj3rFQYd5OLOfjkXI2E0XEbE7cD//6n8FV6wlfUKdLt6EVc2eaJWHS7ASAMG/DfL 1p/5xQ8ag8OkBUbEsCXtz38+4u1Sku0CBH8oNyGEA1OwdEX8U9+knqRMXzgjU9mHDvSwR T/IFZtSJBL29rxEtK5TqlPYLe28Qk96Uz0oImQ8GPgsUobsfhOrN8l0TbqzkLjH6th6G3 KC9QSr1FbgNlSMeu3k8RZf96yZmP5EEwmq1KK3BKlal21C3E0sWiHZGTjr6AoJcOAIAzw Y+vOLLBbV1hJbHT9kxAHH7Gj+7yjIN9A4h3d2DFrllSFi4kaO9bvTSehkpr/2lVBqbQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=NXL9nzUO; arc=none smtp.remote-ip=95.215.58.63 Received: from mta1.migadu.com (out-63.mta1.migadu.com [95.215.58.63]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7076B60A2614 for ; Sun, 25 Oct 2026 23:52:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 7076B60A2614 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=NXL9nzUO X-Envelope-To: linux-kernel@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=YorgiiKPr9PMPuH9UELqxwkea/3mWqVBFXltGMjSNE8=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1792972369; v=1; x=1793577169; b=NXL9nzUOjA/CTbccrP9a7cX1+es2zqNDqynI681/qrG/tjjijy4MGdoUc3dZ/HbevEHswtEP Fz5fvOnb9vb6vpG2TdoggjMSgDIIrN9kbGY1NkEYuYflU/JreVaFGDkhupEDMeX6ROrpwux+7ax 3kaczw6RLZin0TMLlRiT4Gpc= X-Envelope-To: linux-kernel@vger.kernel.org Received: by smtp.migadu.com with ESMTPS id fe0f4676592fb801; Sun, 25 Oct 2026 23:52:49 +0000 X-Mizu-Trace-ID: fe0f4676592fb801 X-Migadu-Flow: FLOW_OUT From: Denis Benato To: linux-kernel@vger.kernel.org Cc: platform-driver-x86@vger.kernel.org, linux-input@vger.kernel.org, kernel@lists.opengamingcollective.org, "Benjamin Tissoires" , "Jiri Kosina" , "Luke D . Jones" , "Mateusz Schwartz" , "Denis Benato" , "Jonathan LoBue" , "Khamunetri Clark" , "Derek J. Clark" , "Joshua Leivenzon" , "Nathan Chancellor" , =?UTF-8?q?Rebecca=20Mara=20M=C3=BCller?= , "Ivan Levchenko" , "Corentin Chary" , "Hans de Goede" , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , Denis Benato Subject: [PATCH v11 06/18] HID: asus: add joysticks anti-deadzone configuration Date: Sun, 25 Oct 2026 23:52:19 +0000 Message-ID: <20261025235232.129945-7-denis.benato@linux.dev> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261025235232.129945-1-denis.benato@linux.dev> References: <20261025235232.129945-1-denis.benato@linux.dev> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ROG Ally devices allow configuring the anti-deadzone parameter for the resistive joysticks devices as over time those develops drift, therefore allow userspace to configure the anti-deadzone by exposing relevant sysfs attributes. Signed-off-by: Denis Benato Signed-off-by: Luke Jones --- drivers/hid/hid-asus.c | 215 ++++++++++++++++++++++++++++++++++++++++- 1 file changed, 211 insertions(+), 4 deletions(-) diff --git a/drivers/hid/hid-asus.c b/drivers/hid/hid-asus.c index 03b033087289..b4bc89ec28bc 100644 --- a/drivers/hid/hid-asus.c +++ b/drivers/hid/hid-asus.c @@ -1391,6 +1391,197 @@ static struct device_attribute dev_attr_right_joystick_outer_threshold = static struct device_attribute dev_attr_right_joystick_outer_threshold_range = __ATTR(outer_threshold_range, 0444, right_joystick_outer_threshold_range_show, NULL); +/** + * ally_set_anti_deadzone() - Set anti-deadzone values for joysticks + * @ally: ally handheld structure + * @hdev: HID device + * @cfg: ally config + * @left_adz: left joystick anti-deadzone value (0-100) + * @right_adz: right joystick anti-deadzone value (0-100) + * + * Return: 0 on success, negative errno on failure + */ +static int ally_set_anti_deadzone(struct ally_handheld *ally, + struct hid_device *hdev, struct ally_config *cfg, + u8 left_adz, u8 right_adz) +{ + const u8 payload[] = { left_adz, right_adz }; + int ret; + + if (!cfg->anti_deadzone_support) { + hid_dbg(hdev, "Anti-deadzone not supported on this device\n"); + return -EOPNOTSUPP; + } + + u8 *buf __free(kfree) = ally_alloc_cmd(CMD_SET_ANTI_DEADZONE, payload, sizeof(payload)); + if (!buf) + return -ENOMEM; + + ret = ally_gamepad_send_packet(ally, hdev, buf, ROG_ALLY_REPORT_SIZE); + if (ret < 0) { + hid_err(hdev, "Failed to set anti-deadzone values: %d\n", ret); + return ret; + } + + return 0; +} + +static ssize_t left_joystick_anti_deadzone_show(struct device *dev, struct device_attribute *attr, + char *buf) +{ + struct hid_device *hdev = to_hid_device(dev); + struct asus_drvdata *drvdata = hid_get_drvdata(hdev); + struct ally_handheld *const ally = drvdata->rog_ally; + struct ally_config *cfg; + + if (!ally) + return -ENODEV; + + cfg = ally_get_config(ally); + if (!cfg) + return -ENODEV; + + guard(mutex)(&cfg->config_mutex); + + if (!cfg->anti_deadzone_support) { + hid_dbg(hdev, "Anti-deadzone not supported on this device\n"); + return -EOPNOTSUPP; + } + + return sysfs_emit(buf, "%u\n", cfg->left_anti_deadzone); +} + +static ssize_t left_joystick_anti_deadzone_store(struct device *dev, struct device_attribute *attr, + const char *buf, size_t count) +{ + struct hid_device *hdev = to_hid_device(dev); + struct asus_drvdata *drvdata = hid_get_drvdata(hdev); + struct ally_handheld *const ally = drvdata->rog_ally; + struct ally_config *cfg; + u8 value; + int ret; + + if (!ally) + return -ENODEV; + + cfg = ally_get_config(ally); + if (!cfg) + return -ENODEV; + + ret = kstrtou8(buf, 10, &value); + if (ret || value > 100) + return -EINVAL; + + guard(mutex)(&cfg->config_mutex); + + if (!cfg->anti_deadzone_support) { + hid_dbg(hdev, "Anti-deadzone not supported on this device\n"); + return -EOPNOTSUPP; + } + + ret = ally_set_anti_deadzone(ally, hdev, cfg, value, cfg->right_anti_deadzone); + if (ret) + return ret; + + cfg->left_anti_deadzone = value; + + sysfs_notify(&dev->kobj, "left_joystick_axis", "anti_deadzone"); + + return count; +} + +static ssize_t left_joystick_anti_deadzone_range_show(struct device *dev, + struct device_attribute *attr, + char *buf) +{ + return sysfs_emit(buf, "0 100\n"); +} + +static ssize_t right_joystick_anti_deadzone_show(struct device *dev, struct device_attribute *attr, + char *buf) +{ + struct hid_device *hdev = to_hid_device(dev); + struct asus_drvdata *drvdata = hid_get_drvdata(hdev); + struct ally_handheld *const ally = drvdata->rog_ally; + struct ally_config *cfg; + + if (!ally) + return -ENODEV; + + cfg = ally_get_config(ally); + if (!cfg) + return -ENODEV; + + guard(mutex)(&cfg->config_mutex); + + if (!cfg->anti_deadzone_support) { + hid_dbg(hdev, "Anti-deadzone not supported on this device\n"); + return -EOPNOTSUPP; + } + + return sysfs_emit(buf, "%u\n", cfg->right_anti_deadzone); +} + +static ssize_t right_joystick_anti_deadzone_store(struct device *dev, struct device_attribute *attr, + const char *buf, size_t count) +{ + struct hid_device *hdev = to_hid_device(dev); + struct asus_drvdata *drvdata = hid_get_drvdata(hdev); + struct ally_handheld *const ally = drvdata->rog_ally; + struct ally_config *cfg; + u8 value; + int ret; + + if (!ally) + return -ENODEV; + + cfg = ally_get_config(ally); + if (!cfg) + return -ENODEV; + + ret = kstrtou8(buf, 10, &value); + if (ret || value > 100) + return -EINVAL; + + guard(mutex)(&cfg->config_mutex); + + if (!cfg->anti_deadzone_support) { + hid_dbg(hdev, "Anti-deadzone not supported on this device\n"); + return -EOPNOTSUPP; + } + + ret = ally_set_anti_deadzone(ally, hdev, cfg, cfg->left_anti_deadzone, value); + if (ret) + return ret; + + cfg->right_anti_deadzone = value; + + sysfs_notify(&dev->kobj, "right_joystick_axis", "anti_deadzone"); + + return count; +} + +static ssize_t right_joystick_anti_deadzone_range_show(struct device *dev, + struct device_attribute *attr, + char *buf) +{ + return sysfs_emit(buf, "0 100\n"); +} + +static struct device_attribute dev_attr_left_joystick_anti_deadzone = + __ATTR(anti_deadzone, 0644, left_joystick_anti_deadzone_show, + left_joystick_anti_deadzone_store); + +static struct device_attribute dev_attr_left_joystick_anti_deadzone_range = + __ATTR(anti_deadzone_range, 0444, left_joystick_anti_deadzone_range_show, NULL); + +static struct device_attribute dev_attr_right_joystick_anti_deadzone = + __ATTR(anti_deadzone, 0644, right_joystick_anti_deadzone_show, + right_joystick_anti_deadzone_store); + +static struct device_attribute dev_attr_right_joystick_anti_deadzone_range = + __ATTR(anti_deadzone_range, 0444, right_joystick_anti_deadzone_range_show, NULL); + /** * ally_set_trigger_ranges() - Generic function to set triggers ranges * @ally: ally handheld structure @@ -1764,6 +1955,8 @@ static struct attribute *left_joystick_axis_attrs[] = { &dev_attr_left_joystick_outer_threshold.attr, &dev_attr_left_joystick_inner_threshold_range.attr, &dev_attr_left_joystick_outer_threshold_range.attr, + &dev_attr_left_joystick_anti_deadzone.attr, + &dev_attr_left_joystick_anti_deadzone_range.attr, NULL }; @@ -1772,6 +1965,8 @@ static struct attribute *right_joystick_axis_attrs[] = { &dev_attr_right_joystick_outer_threshold.attr, &dev_attr_right_joystick_inner_threshold_range.attr, &dev_attr_right_joystick_outer_threshold_range.attr, + &dev_attr_right_joystick_anti_deadzone.attr, + &dev_attr_right_joystick_anti_deadzone_range.attr, NULL }; @@ -1903,8 +2098,11 @@ static struct ally_config *ally_config_create(struct hid_device *hdev, struct al } } - /* Skip the calibration groups when the capability is missing. */ - if (cfg->user_cal_support) { + /* + * Skip the calibration and anti-deadzone groups when none of the + * features they expose is supported. + */ + if (cfg->user_cal_support || cfg->anti_deadzone_support) { int cal_i; for (cal_i = 0; cal_i < ARRAY_SIZE(ally_cal_attr_groups); @@ -1958,8 +2156,7 @@ static void ally_config_remove(struct hid_device *hdev, struct ally_config *cfg) * create them, so a device without those capabilities does not * trigger a "not found" warning. */ - if (cfg->user_cal_support || cfg->anti_deadzone_support || - cfg->resp_curve_support) { + if (cfg->user_cal_support || cfg->anti_deadzone_support) { for (i = 0; i < ARRAY_SIZE(ally_cal_attr_groups); i++) sysfs_remove_group(&hdev->dev.kobj, ally_cal_attr_groups[i]); @@ -2284,6 +2481,16 @@ static int hid_asus_ally_init(struct hid_device *hdev, struct ally_handheld *all ret); } + if (cfg->anti_deadzone_support) { + ret = ally_set_anti_deadzone(ally, hdev, cfg, + cfg->left_anti_deadzone, + cfg->right_anti_deadzone); + if (ret < 0) + hid_warn(hdev, + "Failed to restore anti-deadzone: %d\n", + ret); + } + return 0; } -- 2.47.3