From: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
To: "Douglas Anderson" <dianders@chromium.org>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Jessica Zhang" <jesszhan0024@gmail.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Jyri Sarha" <jyri.sarha@iki.fi>,
"Tomi Valkeinen" <tomi.valkeinen@ideasonboard.com>,
"Andrzej Hajda" <andrzej.hajda@intel.com>,
"Robert Foss" <rfoss@kernel.org>,
"Laurent Pinchart" <Laurent.pinchart@ideasonboard.com>,
"Jonas Karlman" <jonas@kwiboo.se>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
"Luca Ceresoli" <luca.ceresoli@bootlin.com>,
"Paul Cercueil" <paul@crapouillou.net>,
"Marek Vasut" <marex@denx.de>, "Stefan Agner" <stefan@agner.ch>,
"Frank Li" <Frank.Li@nxp.com>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Fabio Estevam" <festevam@gmail.com>,
"Laurent Pinchart" <laurent.pinchart+renesas@ideasonboard.com>,
"Tomi Valkeinen" <tomi.valkeinen+renesas@ideasonboard.com>,
"Kieran Bingham" <kieran.bingham+renesas@ideasonboard.com>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Magnus Damm" <magnus.damm@gmail.com>,
"Biju Das" <biju.das.jz@bp.renesas.com>,
"Linus Walleij" <linusw@kernel.org>,
"Sandy Huang" <hjc@rock-chips.com>,
"Heiko Stübner" <heiko@sntech.de>,
"Andy Yan" <andy.yan@rock-chips.com>,
"Jonathan Corbet" <corbet@lwn.net>,
"Shuah Khan" <skhan@linuxfoundation.org>,
"Randy Dunlap" <rdunlap@infradead.org>,
"Inki Dae" <inki.dae@samsung.com>,
"Seung-Woo Kim" <sw0312.kim@samsung.com>,
"Kyungmin Park" <kyungmin.park@samsung.com>,
"Krzysztof Kozlowski" <krzk@kernel.org>,
"Peter Griffin" <peter.griffin@linaro.org>,
"Alim Akhtar" <alim.akhtar@samsung.com>,
"Alison Wang" <alison.wang@nxp.com>,
"Paul Kocialkowski" <paulk@sys-base.io>,
"Yannick Fertre" <yannick.fertre@foss.st.com>,
"Raphael Gallais-Pou" <raphael.gallais-pou@foss.st.com>,
"Philippe Cornu" <philippe.cornu@foss.st.com>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
"Chen-Yu Tsai" <wens@kernel.org>,
"Samuel Holland" <samuel@sholland.org>,
"Thierry Reding" <thierry.reding@kernel.org>,
"Mikko Perttunen" <mperttunen@nvidia.com>,
"Jonathan Hunter" <jonathanh@nvidia.com>,
"Jagan Teki" <jagan@amarulasolutions.com>,
"Ondrej Jirman" <megi@xff.cz>,
"Javier Martinez Canillas" <javierm@redhat.com>,
"Igor Reznichenko" <igor@reznichenko.net>,
"Michael Walle" <mwalle@kernel.org>,
"Dario Binacchi" <dario.binacchi@amarulasolutions.com>,
"Jagan Teki" <jagan@edgeble.ai>,
"Jianhua Lu" <lujianhua000@gmail.com>,
"Guido Günther" <agx@sigxcpu.org>,
"Purism Kernel Team" <kernel@puri.sm>,
"Jerry Han" <hanxu5@huaqin.corp-partner.google.com>,
"Joel Selvaraj" <jo@jsfamily.in>,
"Icenowy Zheng" <icenowy@aosc.io>,
"Michael Trimarchi" <michael@amarulasolutions.com>,
"Sumit Semwal" <sumit.semwal@linaro.org>,
"Casey Connolly" <casey.connolly@linaro.org>,
"Michael Tretter" <m.tretter@pengutronix.de>,
"Cristian Cozzolino" <cristian_ci@protonmail.com>,
"Junjie Cao" <junjie.cao@linux.dev>,
"Ryan Brue" <ryanbrue.dev@gmail.com>,
"Nickolay Goppen" <setotau@mainlining.org>,
"Stefan Mavrodiev" <stefan@olimex.com>,
"Florian Fainelli" <florian.fainelli@broadcom.com>,
"Broadcom internal kernel review list"
<bcm-kernel-feedback-list@broadcom.com>,
"Robert Chiras" <robert.chiras@nxp.com>,
"Alexander Koskovich" <akoskovich@pm.me>,
"Markuss Broks" <markuss.broks@gmail.com>,
"Artur Weber" <aweber.kernel@gmail.com>,
"David Heidelberg" <david@ixit.cz>,
"Dzmitry Sankouski" <dsankouski@gmail.com>,
"Yedaya Katsman" <yedaya.ka@gmail.com>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
linux-mips@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-renesas-soc@vger.kernel.org,
linux-rockchip@lists.infradead.org, linux-doc@vger.kernel.org,
linux-samsung-soc@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org,
linux-rpi-kernel@lists.infradead.org
Subject: [PATCH 13/35] drm/panel: remove the _typed() panel bridge functions
Date: Mon, 26 Oct 2026 13:10:02 +0200 [thread overview]
Message-ID: <20261026-drm-panel-funcs-v1-13-5e3070a3478f@oss.qualcomm.com> (raw)
In-Reply-To: <20261026-drm-panel-funcs-v1-0-5e3070a3478f@oss.qualcomm.com>
The connector type argument of drm_panel_bridge_add_typed() and
devm_drm_panel_bridge_add_typed() has been ignored since commit
b7797081ccfe ("drm/panel: embed a drm_bridge into every drm_panel"),
and they have no users left.
Assisted-by: LLM
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
---
Documentation/gpu/todo.rst | 1 -
drivers/gpu/drm/drm_panel.c | 55 ++++-----------------------------------------
include/drm/drm_panel.h | 5 -----
3 files changed, 4 insertions(+), 57 deletions(-)
diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst
index e6d36f8da086..f78455e4c97b 100644
--- a/Documentation/gpu/todo.rst
+++ b/Documentation/gpu/todo.rst
@@ -475,7 +475,6 @@ not needed anymore. Its APIs are just accessing the embedded drm_bridge
transparently, and the are deprecated.
The funcions to remove are:
- - drm_panel_bridge_add_typed()
- devm_drm_of_get_bridge()
- drmm_of_get_bridge()
- drm_panel_bridge_remove()
diff --git a/drivers/gpu/drm/drm_panel.c b/drivers/gpu/drm/drm_panel.c
index 268e655140ac..ab701a526ef9 100644
--- a/drivers/gpu/drm/drm_panel.c
+++ b/drivers/gpu/drm/drm_panel.c
@@ -270,31 +270,9 @@ struct drm_bridge *drm_panel_bridge_add(struct drm_panel *panel)
if (WARN_ON(panel->connector_type == DRM_MODE_CONNECTOR_Unknown))
return ERR_PTR(-EINVAL);
- return drm_panel_bridge_add_typed(panel, panel->connector_type);
-}
-EXPORT_SYMBOL(drm_panel_bridge_add);
-
-/**
- * drm_panel_bridge_add_typed - Pretend to create a &drm_bridge and &drm_connector with
- * an explicit connector type.
- * @panel: The drm_panel being wrapped. Must be non-NULL.
- * @connector_type: The connector type (DRM_MODE_CONNECTOR_*)
- *
- * This is just like drm_panel_bridge_add(), but forces the connector type to
- * @connector_type instead of infering it from the panel.
- *
- * This function is deprecated. A drm_bridge is embedded into every panel.
- * Don't use it in new drivers and update your driver to stop using it.
- */
-struct drm_bridge *drm_panel_bridge_add_typed(struct drm_panel *panel,
- u32 connector_type)
-{
- if (!panel)
- return ERR_PTR(-EINVAL);
-
return drm_bridge_get(&panel->bridge);
}
-EXPORT_SYMBOL(drm_panel_bridge_add_typed);
+EXPORT_SYMBOL(drm_panel_bridge_add);
/**
* drm_panel_bridge_remove - Unregisters and frees a drm_bridge
@@ -362,31 +340,6 @@ static void devm_drm_panel_bridge_release(struct device *dev, void *res)
*/
struct drm_bridge *devm_drm_panel_bridge_add(struct device *dev,
struct drm_panel *panel)
-{
- if (WARN_ON(panel->connector_type == DRM_MODE_CONNECTOR_Unknown))
- return ERR_PTR(-EINVAL);
-
- return devm_drm_panel_bridge_add_typed(dev, panel,
- panel->connector_type);
-}
-EXPORT_SYMBOL(devm_drm_panel_bridge_add);
-
-/**
- * devm_drm_panel_bridge_add_typed - Creates a managed &drm_bridge and
- * &drm_connector with an explicit connector type.
- * @dev: device to tie the bridge lifetime to
- * @panel: The drm_panel being wrapped. Must be non-NULL.
- * @connector_type: The connector type (DRM_MODE_CONNECTOR_*)
- *
- * This is just like devm_drm_panel_bridge_add(), but forces the connector type
- * to @connector_type instead of infering it from the panel.
- *
- * This function is deprecated. A drm_bridge is embedded into every panel.
- * Don't use it in new drivers and update your driver to stop using it.
- */
-struct drm_bridge *devm_drm_panel_bridge_add_typed(struct device *dev,
- struct drm_panel *panel,
- u32 connector_type)
{
struct drm_bridge **ptr, *bridge;
@@ -395,7 +348,7 @@ struct drm_bridge *devm_drm_panel_bridge_add_typed(struct device *dev,
if (!ptr)
return ERR_PTR(-ENOMEM);
- bridge = drm_panel_bridge_add_typed(panel, connector_type);
+ bridge = drm_panel_bridge_add(panel);
if (IS_ERR(bridge)) {
devres_free(ptr);
return bridge;
@@ -406,7 +359,7 @@ struct drm_bridge *devm_drm_panel_bridge_add_typed(struct device *dev,
return &panel->bridge;
}
-EXPORT_SYMBOL(devm_drm_panel_bridge_add_typed);
+EXPORT_SYMBOL(devm_drm_panel_bridge_add);
static void drmm_drm_panel_bridge_release(struct drm_device *drm, void *ptr)
{
@@ -436,7 +389,7 @@ struct drm_bridge *drmm_panel_bridge_add(struct drm_device *drm,
struct drm_bridge *bridge;
int ret;
- bridge = drm_panel_bridge_add_typed(panel, panel->connector_type);
+ bridge = drm_panel_bridge_add(panel);
if (IS_ERR(bridge))
return bridge;
diff --git a/include/drm/drm_panel.h b/include/drm/drm_panel.h
index deae4753a594..07612e9791cd 100644
--- a/include/drm/drm_panel.h
+++ b/include/drm/drm_panel.h
@@ -393,16 +393,11 @@ static inline int drm_panel_of_backlight(struct drm_panel *panel)
#ifdef CONFIG_DRM_PANEL_BRIDGE
bool drm_bridge_is_panel(const struct drm_bridge *bridge);
struct drm_bridge *drm_panel_bridge_add(struct drm_panel *panel);
-struct drm_bridge *drm_panel_bridge_add_typed(struct drm_panel *panel,
- u32 connector_type);
void drm_panel_bridge_remove(struct drm_bridge *bridge);
int drm_panel_bridge_set_orientation(struct drm_connector *connector,
struct drm_bridge *bridge);
struct drm_bridge *devm_drm_panel_bridge_add(struct device *dev,
struct drm_panel *panel);
-struct drm_bridge *devm_drm_panel_bridge_add_typed(struct device *dev,
- struct drm_panel *panel,
- u32 connector_type);
struct drm_bridge *drmm_panel_bridge_add(struct drm_device *drm,
struct drm_panel *panel);
struct drm_connector *drm_panel_bridge_connector(struct drm_bridge *bridge);
--
2.47.3
next prev parent reply other threads:[~2026-10-26 11:10 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-26 11:09 [PATCH 00/35] drm/panel: let the panels use the atomic state Dmitry Baryshkov
2026-10-26 11:09 ` [PATCH 01/35] drm/panel: remove the get_timings() callback Dmitry Baryshkov
2026-10-26 11:09 ` [PATCH 02/35] drm/panel: remove the unused struct panel_bridge Dmitry Baryshkov
2026-10-26 11:09 ` [PATCH 03/35] drm/tidss: get the panel type from the embedded bridge Dmitry Baryshkov
2026-10-26 11:09 ` [PATCH 04/35] drm/bridge: lvds-codec: use devm_drm_panel_bridge_add() Dmitry Baryshkov
2026-10-26 11:09 ` [PATCH 05/35] drm/ingenic: " Dmitry Baryshkov
2026-10-26 11:09 ` [PATCH 06/35] drm: mxsfb: " Dmitry Baryshkov
2026-10-26 11:09 ` [PATCH 07/35] drm: rcar-du: " Dmitry Baryshkov
2026-10-26 11:09 ` [PATCH 08/35] drm: rz-du: " Dmitry Baryshkov
2026-10-26 11:09 ` [PATCH 09/35] drm/mcde: use drm_panel_bridge_add() Dmitry Baryshkov
2026-10-26 11:09 ` [PATCH 10/35] drm/pl111: " Dmitry Baryshkov
2026-10-26 11:10 ` [PATCH 11/35] drm/rockchip: lvds: " Dmitry Baryshkov
2026-10-26 11:10 ` [PATCH 12/35] drm/rockchip: rgb: " Dmitry Baryshkov
2026-10-26 11:10 ` Dmitry Baryshkov [this message]
2026-10-26 11:10 ` [PATCH 14/35] drm/panel: remove drm_panel.connector_type Dmitry Baryshkov
2026-10-26 11:10 ` [PATCH 15/35] drm/bridge: anx6345: set the panel orientation on the connector Dmitry Baryshkov
2026-10-26 11:10 ` [PATCH 16/35] drm/exynos: dpi: " Dmitry Baryshkov
2026-10-26 11:10 ` [PATCH 17/35] drm/fsl-dcu: " Dmitry Baryshkov
2026-10-26 11:10 ` [PATCH 18/35] drm/logicvc: " Dmitry Baryshkov
2026-10-26 11:10 ` [PATCH 19/35] drm/stm: lvds: " Dmitry Baryshkov
2026-10-26 11:10 ` [PATCH 20/35] drm/sun4i: " Dmitry Baryshkov
2026-10-26 11:10 ` [PATCH 21/35] drm/tegra: sor: " Dmitry Baryshkov
2026-10-26 11:10 ` [PATCH 22/35] drm/panel: drop the orientation workaround from get_modes() Dmitry Baryshkov
2026-10-26 11:10 ` [PATCH 23/35] drm/panel: read the panel orientation in the core Dmitry Baryshkov
2026-10-26 11:10 ` [PATCH 24/35] drm/panel: use the orientation from the panel core Dmitry Baryshkov
2026-10-26 11:10 ` [PATCH 25/35] drm/panel: remove the get_orientation() callback Dmitry Baryshkov
2026-10-26 11:10 ` [PATCH 26/35] drm/bridge: add the connector_init callback Dmitry Baryshkov
2026-10-26 11:10 ` [PATCH 27/35] drm/bridge-connector: let the bridges set up the connector Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261026-drm-panel-funcs-v1-13-5e3070a3478f@oss.qualcomm.com \
--to=dmitry.baryshkov@oss.qualcomm.com \
--cc=Frank.Li@nxp.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=agx@sigxcpu.org \
--cc=airlied@gmail.com \
--cc=akoskovich@pm.me \
--cc=alexandre.torgue@foss.st.com \
--cc=alim.akhtar@samsung.com \
--cc=alison.wang@nxp.com \
--cc=andrzej.hajda@intel.com \
--cc=andy.yan@rock-chips.com \
--cc=aweber.kernel@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=casey.connolly@linaro.org \
--cc=corbet@lwn.net \
--cc=cristian_ci@protonmail.com \
--cc=dario.binacchi@amarulasolutions.com \
--cc=david@ixit.cz \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=dsankouski@gmail.com \
--cc=festevam@gmail.com \
--cc=florian.fainelli@broadcom.com \
--cc=geert+renesas@glider.be \
--cc=hanxu5@huaqin.corp-partner.google.com \
--cc=heiko@sntech.de \
--cc=hjc@rock-chips.com \
--cc=icenowy@aosc.io \
--cc=igor@reznichenko.net \
--cc=imx@lists.linux.dev \
--cc=inki.dae@samsung.com \
--cc=jagan@amarulasolutions.com \
--cc=jagan@edgeble.ai \
--cc=javierm@redhat.com \
--cc=jernej.skrabec@gmail.com \
--cc=jesszhan0024@gmail.com \
--cc=jo@jsfamily.in \
--cc=jonas@kwiboo.se \
--cc=jonathanh@nvidia.com \
--cc=junjie.cao@linux.dev \
--cc=jyri.sarha@iki.fi \
--cc=kernel@pengutronix.de \
--cc=kernel@puri.sm \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=krzk@kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linusw@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-sunxi@lists.linux.dev \
--cc=linux-tegra@vger.kernel.org \
--cc=luca.ceresoli@bootlin.com \
--cc=lujianhua000@gmail.com \
--cc=m.tretter@pengutronix.de \
--cc=maarten.lankhorst@linux.intel.com \
--cc=magnus.damm@gmail.com \
--cc=marex@denx.de \
--cc=markuss.broks@gmail.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=megi@xff.cz \
--cc=michael@amarulasolutions.com \
--cc=mperttunen@nvidia.com \
--cc=mripard@kernel.org \
--cc=mwalle@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=paul@crapouillou.net \
--cc=paulk@sys-base.io \
--cc=peter.griffin@linaro.org \
--cc=philippe.cornu@foss.st.com \
--cc=raphael.gallais-pou@foss.st.com \
--cc=rdunlap@infradead.org \
--cc=rfoss@kernel.org \
--cc=robert.chiras@nxp.com \
--cc=ryanbrue.dev@gmail.com \
--cc=s.hauer@pengutronix.de \
--cc=samuel@sholland.org \
--cc=setotau@mainlining.org \
--cc=simona@ffwll.ch \
--cc=skhan@linuxfoundation.org \
--cc=stefan@agner.ch \
--cc=stefan@olimex.com \
--cc=sumit.semwal@linaro.org \
--cc=sw0312.kim@samsung.com \
--cc=thierry.reding@kernel.org \
--cc=tomi.valkeinen+renesas@ideasonboard.com \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=tzimmermann@suse.de \
--cc=wens@kernel.org \
--cc=yannick.fertre@foss.st.com \
--cc=yedaya.ka@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®