From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=205.220.168.131 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793013079; b=hc7LIzLgpE/RCXDHpXZZlNx9GK4t9IhINoaYlx8TPxWZ6Ek82NjnUv1FTzzcAjjuLC64 QQMxi8ZLck7PhHZ4+BLFjURELbf531XHVJrhUPsPeTWa1JuqgYNb4FZismyNGxiKQgQrh uUbutwCOFt8/eMPuLQdUbyMnTPmk31lKubPUqSc9dK3Bovt5Tt5CV9aOzfdia4eVO725o cY9QBtkXDCkZyF3FJgRSIpjVO5eUp3iROqBghaa0PtccdfEXxGHccrSAEUYpU99xE7QSz rC5QSEHSQNRT/5cs0gTMDvYuc1K5EWAUnMFvyopsUtpZL6aC/omG0Nx4MgOD7ELk1nQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793013079; h=DMARC-Filter:Received:DKIM-Signature:Received:Received: DKIM-Signature:X-Google-DKIM-Signature:X-Forwarded-Encrypted: X-Gm-Message-State:X-Gm-Gg:X-Received:X-Received:Received:From:Date: Subject:MIME-Version:Content-Type:Content-Transfer-Encoding: Message-Id:References:In-Reply-To:To:Cc:X-Mailer: X-Developer-Signature:X-Developer-Key:X-Proofpoint-Spam-Info: X-Proofpoint-GUID:X-Proofpoint-Spam-Details-Enc:X-Authority-Analysis: X-Proofpoint-ORIG-GUID:X-Proofpoint-Virus-Version: X-Proofpoint-Spam-Details; bh=dg5zkY2HMaN3S1LQ7C2wxwVeSCWjIGLxXjphKAEg1Bc=; b=eCSpKLFt17nHkwSyGNBO7qn+NwAFHEmrfJVzRFAtJyPArEfw3wLDHOMMb6swb6re+tkJ dVy/FueuwQeFUhe03qTWXOzfXzVZUoTpH8MY8mv0jgs7SvvDo6NBq2udivIn3iRmHzsgA m6o1QzD3hpKPPhPP9sdL2Yl49rc2nEloe/AJ/0I/ekMhY4D4Vwv2suk2sSK42zGb7Hj2I d7QR3P5iKQShDRbLBQFFRU1aPxj8cCI5rqkui2wyYXAtPCMROPq6IjHsd8ZHgXYgHxR3S C7cOqYPll0VgSBxwekGXlo3VBiWtINC9vHn01KGi9C8KMfG0pZKAa2jXuvxSIqd4WZg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b="NT/pTjjt"; dkim=pass header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=N57G6O9I; arc=none smtp.remote-ip=205.220.168.131 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0AE98607065D for ; Mon, 26 Oct 2026 11:11:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 0AE98607065D Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=NT/pTjjt; dkim=pass (2048-bit key, unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=N57G6O9I Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 69QAt6Ik4126385 for ; Mon, 26 Oct 2026 11:11:18 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= dg5zkY2HMaN3S1LQ7C2wxwVeSCWjIGLxXjphKAEg1Bc=; b=NT/pTjjtrT8dYnjF WH6qLjW6kx2wD0tAa1EQLt5mJoBFBC278Sstl3FzSsSLBoPXgMOCnzIX09ifooBv 7pkRxd4fS7XPQ7JUM4NjjZcmJx19Y7WHU7i6jtMBXYyLPC9T6rwbv93In7PMXpzi QPJAkI+be2BxxA5zI5XamOE6r6O3Kr5HDZwTNTv73jT5VrWnsFJ77Yi5yzqT9yFn o45rm4LsQsYn7vmIWTjo6iqt6X9ZYuPY0W1pF4CdJNLN/FLKlxEq6LFKnF2+K0UB 5kXQZ/lskryTSgbtibVEeNId1StpbWSfS21DPbH0l2PIcYPWxAp1dLnqntim7WL0 OGOMwQ== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4hhshpt3uc-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 26 Oct 2026 11:11:18 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-93f62934ef6so365777085a.3 for ; Mon, 26 Oct 2026 04:11:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1793013077; x=1793617877; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=dg5zkY2HMaN3S1LQ7C2wxwVeSCWjIGLxXjphKAEg1Bc=; b=N57G6O9IcosHOeX2GjT3OCg/jpM63H8vc5Q0O8F5W7qq9RW9k61SuXfAdOEGRteqO/ AVIZGhN3edEXmmcClMhDpW+5Dn3jjOWNdOtGRm5JjsYFaaxEgtYzjOz2dJjYH9s9A90y 0sc+NkhJXHIYmBQ/XZuQSrYoZnHlKo7ZEzEVbW5m8VooJqgIQwcnNiuW67wRltRtq1Tl wcLQ3YvszQ3WRzPp8di5ilM1A2EVMUrEUj86tpTF0HIOm+R/nDoWiNS6BnAdQPlMV2Cg P6wdPwgGHLKQ6GjyMGXjKmML/JSUm1ZnwIZO2kS2NBq3i1bMQTSbavt2CPOpZej03Abs aABQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793013077; x=1793617877; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=dg5zkY2HMaN3S1LQ7C2wxwVeSCWjIGLxXjphKAEg1Bc=; b=Y+cVBQX+y//+QCeLKzyUSRGhAjdsshMfx4jftFYjReDQDmMVNPDPH1cbcjw3bv3rWT taTDoMUOBbRLjF/BvQC6RcGknbXQe60B1/bpg/xg4gQ51St8/h1NZIw2aWdU+XC7Mh1N IGqk1t4sRosctcTFxaWawzRJ2hMuJ0EPVs2juwwmppUHJ1w6hq4YFGud6osa8zuljh/s wXo/CV2w4/8w4nsPBzWUlOCa1krTtrKXNtK/GQwWpjr2ufc5l0zwh0rtNLNAy8W6RhMU TPb64LQiW0iB9SP4x3gZnlVs8XvnJ4WkX58bZG2BjU6nHnIdJIJoMs8LfEtNILEvOm7w wVAg== X-Forwarded-Encrypted: i=1; AKwUvBz1W5ApkdF4g5F8k4ClN+akIfMLy085ZflqflO8elObxFrMt5FcP7kGsYBfzC8n1famIF4uAL0JbL6L+3E=@vger.kernel.org X-Gm-Message-State: AFq9FYLgTd7OyP0I30JvNkSE570aK8Ahj01Ci7BK7pQqC+3VUXFdPVAU jFC0ig0ev2v+BCcfYbJOxj/WYV5Wiv6fJ9ggwKDLDWCALg75h0sv6vFzLvTdwnASsrYKfjGNOlK Z3iXtAi08leF4tvEgiOLVc6ED+5M0uxcHPLIRFQnhToZli3OPrPuNzzCa2usNUs7hYV8= X-Gm-Gg: AYBFou1iUIaNDKNesFpZkOp33b/4NtOhdTG/SLHkcC12G0faYyPymebk0Q4+TBfS92N cgAkVizGVrM8jG2LfHJkZR5ujZ2H/c+uv0KDbez7qmI5EeidKQvJX+KYnsFv5W0u/cUwq1KRpxj wbFknwWNYEKIPfjENb0s3Uoq7OIErFsfv+fdFFVpwjgkul3Ooo0v3rW6vwYhPrPCNOIN4NxcmxS aRUwrwT+lagOZdajq2aUZ03cAcDiduIsptHekR8oFWd5kL+LSFYBb9H0vtx4oV3VpgVK4Tb4tD/ yPUBOFrwPcqo6Ai6+EB5HCM9JGZP0la8fy7n0HTg3azRm7nt5Wr2rZtr42vKwnLF7sSS+bHkqeR jN1onB7Hy5ImJ6BAoxCXDcy+fBZiT8eu5Vj6P/hv0ZAutJv7Qd5rAovNGcFuGamChcrhMxdbz2I wYL/DBPyAFbm91 X-Received: by 2002:a05:620a:261c:b0:93f:707f:28d2 with SMTP id af79cd13be357-940ef8aed1bmr994274185a.26.1793013077099; Mon, 26 Oct 2026 04:11:17 -0700 (PDT) X-Received: by 2002:a05:620a:261c:b0:93f:707f:28d2 with SMTP id af79cd13be357-940ef8aed1bmr994262285a.26.1793013076523; Mon, 26 Oct 2026 04:11:16 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5bfb7a950a3sm1455459e87.68.2026.10.26.04.11.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Oct 2026 04:11:14 -0700 (PDT) From: Dmitry Baryshkov Date: Mon, 26 Oct 2026 13:10:11 +0200 Subject: [PATCH 22/35] drm/panel: drop the orientation workaround from get_modes() X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20261026-drm-panel-funcs-v1-22-5e3070a3478f@oss.qualcomm.com> References: <20261026-drm-panel-funcs-v1-0-5e3070a3478f@oss.qualcomm.com> In-Reply-To: <20261026-drm-panel-funcs-v1-0-5e3070a3478f@oss.qualcomm.com> To: Douglas Anderson , Neil Armstrong , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jyri Sarha , Tomi Valkeinen , Andrzej Hajda , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Luca Ceresoli , Paul Cercueil , Marek Vasut , Stefan Agner , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Laurent Pinchart , Tomi Valkeinen , Kieran Bingham , Geert Uytterhoeven , Magnus Damm , Biju Das , Linus Walleij , Sandy Huang , =?utf-8?q?Heiko_St=C3=BCbner?= , Andy Yan , Jonathan Corbet , Shuah Khan , Randy Dunlap , Inki Dae , Seung-Woo Kim , Kyungmin Park , Krzysztof Kozlowski , Peter Griffin , Alim Akhtar , Alison Wang , Paul Kocialkowski , Yannick Fertre , Raphael Gallais-Pou , Philippe Cornu , Maxime Coquelin , Alexandre Torgue , Chen-Yu Tsai , Samuel Holland , Thierry Reding , Mikko Perttunen , Jonathan Hunter , Jagan Teki , Ondrej Jirman , Javier Martinez Canillas , Igor Reznichenko , Michael Walle , Dario Binacchi , Jagan Teki , Jianhua Lu , =?utf-8?q?Guido_G=C3=BCnther?= , Purism Kernel Team , Jerry Han , Joel Selvaraj , Icenowy Zheng , Michael Trimarchi , Sumit Semwal , Casey Connolly , Michael Tretter , Cristian Cozzolino , Junjie Cao , Ryan Brue , Nickolay Goppen , Stefan Mavrodiev , Florian Fainelli , Broadcom internal kernel review list , Robert Chiras , Alexander Koskovich , Markuss Broks , Artur Weber , David Heidelberg , Dzmitry Sankouski , Yedaya Katsman Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-doc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, linux-rpi-kernel@lists.infradead.org X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=6347; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=pIOB3uhyuBnIv/4e7qIm3qYvTrQqV7MkFySAJKsupco=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBq3zURNMUbn+OFPYO6Rs5wHYoMvPXWbHnPEQw+S eR2by97mJWJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCat81EQAKCRCLPIo+Aiko 1ZJmB/4pC0z3MOz+MYOvygaw89qOLA80ziZqdzL2JsocIt6Gdpqn+jXgLiKeKzfpkRqe93yynNS 6w72Miunger/6rdcY7rRGrRlFem8FTSpCJtamc5WacQP7woDC6T0A67d60V0sA53pFs6mnPcf1c wmG+kc/TZizvHfgHcIsV3ojeaH0YdfS0Uw0jd5DpNQMPz4+FJ4SEOdO0N9UsSqaN8p99GLZ4wnN Eg7CEyx8XI/MEu4LI5iPg3mHptZfQ+7T8GOdDgkhLvNvhyz24Lm16Y6wMSjdIQKPau5mwzUKf2R 8CvwIbzO6VH8PVQTzIyeLMh901DD8wek/BCPDasQMN/5pNtU X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-Spam-Info: AW1haW4tMjYxMDI2MDA0NCBTYWx0ZWRfX3hGklHAnjd3D /Qz4auTIEb5LX7p8Nbj69W9LZcy0Un0jVxpT4tg7or2z827jWVP2GvuKnvQ5rZd7ETRjXVKZqFv tg0f4CpV0eYzWOkNNyrxw/gFmXc7hcQ= X-Proofpoint-GUID: rolH7bzoff8v-WPR9d0W2ePcC2d5aiwF X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDI2MDA0NCBTYWx0ZWRfX13JtDDw22CrW +xzTyqxq/Mkmck2xnzNur9BwsmUpUNnGkkqzrCuB5nFsKPLyJSyeBdqzrRCkjoQeaqqnCma6iXk fGBD5JDuGK1uTquBCEEwJ2B4PtnucdIZZnDtVCIMidgOoAJRbs5WoB+X5gc5IEZTrFo0gQDTYo+ OebY5xVxlBPa1ztGDSUhc0D3F04+kKeUjKSmVoLiN9WNfiGZ30gvdAugMhRl/mN3XMo2FUsgijB xA8sZzVIP8HMfeB3JidgCgS8Adfd8CEbekiZU9KY7QxRrfWeDFb49oEe2j6OmYX8FA4tupjIcEt IciLfRS57w+4Cuy0vMD3FHiUlDuU3GVKOFsyyG5C3j/NNhLd3tWTlRQXHoCEbv0q7aBQVczd3wD 12GZnpgT7eiS8in17bLB1dil5L0yJ2Fc9CUSnCep5QNwczY7MIOTMVd3RT/M28LuQwP1ZD2QjqC neEaXtmKNzFni36iMtg== X-Authority-Analysis: v=2.4 cv=HZWB3SE8 c=1 sm=1 tr=0 ts=6adf3556 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=660iZSQnnn4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=PL5jcg54admUc1aTEAgA:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-ORIG-GUID: rolH7bzoff8v-WPR9d0W2ePcC2d5aiwF X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.138,FMLib:17.12.100.49 definitions=2026-10-26_02,2026-10-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 phishscore=0 clxscore=1015 adultscore=0 priorityscore=1501 impostorscore=0 lowpriorityscore=0 bulkscore=0 suspectscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2610190000 definitions=main-2610260044 Setting the orientation from get_modes() was a stopgap for the display drivers not calling drm_connector_set_orientation_from_panel(). It is also too late: by then the connector is registered and the property can no longer be attached properly. drm_bridge_connector and the panel bridge set the orientation on their own, and the drivers using a panel directly do it when creating the connector now. The exceptions are sun6i_mipi_dsi, sti_dvo and the Tegra DSI, which get the panel only after the DRM device has been registered. None of the in-tree boards using them has a rotated panel. Assisted-by: LLM Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/panel/panel-boe-th101mb31ig002-28a.c | 6 ------ drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c | 6 ------ drivers/gpu/drm/panel/panel-edp.c | 6 ------ drivers/gpu/drm/panel/panel-ilitek-ili9881c.c | 6 ------ drivers/gpu/drm/panel/panel-lvds.c | 6 ------ drivers/gpu/drm/panel/panel-simple.c | 6 ------ drivers/gpu/drm/panel/panel-sitronix-st7701.c | 6 ------ drivers/gpu/drm/panel/panel-sitronix-st7789v.c | 6 ------ 8 files changed, 48 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-boe-th101mb31ig002-28a.c b/drivers/gpu/drm/panel/panel-boe-th101mb31ig002-28a.c index a70a2e58f88c..a67e0e57d8c3 100644 --- a/drivers/gpu/drm/panel/panel-boe-th101mb31ig002-28a.c +++ b/drivers/gpu/drm/panel/panel-boe-th101mb31ig002-28a.c @@ -318,12 +318,6 @@ static int boe_th101mb31ig002_get_modes(struct drm_panel *panel, const struct drm_display_mode *desc_mode = ctx->desc->modes; connector->display_info.bpc = 8; - /* - * TODO: Remove once all drm drivers call - * drm_connector_set_orientation_from_panel() - */ - drm_connector_set_panel_orientation(connector, ctx->orientation); - return drm_connector_helper_get_modes_fixed(connector, desc_mode); } diff --git a/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c b/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c index 150dff3ab6c3..681a2418f154 100644 --- a/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c +++ b/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c @@ -1666,12 +1666,6 @@ static int boe_panel_get_modes(struct drm_panel *panel, connector->display_info.width_mm = boe->desc->size.width_mm; connector->display_info.height_mm = boe->desc->size.height_mm; connector->display_info.bpc = boe->desc->bpc; - /* - * TODO: Remove once all drm drivers call - * drm_connector_set_orientation_from_panel() - */ - drm_connector_set_panel_orientation(connector, boe->orientation); - return 1; } diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel-edp.c index d3a4cf9b1760..493a76f7416c 100644 --- a/drivers/gpu/drm/panel/panel-edp.c +++ b/drivers/gpu/drm/panel/panel-edp.c @@ -637,12 +637,6 @@ static int panel_edp_get_modes(struct drm_panel *panel, else if (!num) dev_warn(p->base.dev, "No display modes\n"); - /* - * TODO: Remove once all drm drivers call - * drm_connector_set_orientation_from_panel() - */ - drm_connector_set_panel_orientation(connector, p->orientation); - return num; } diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c b/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c index 7bf38e96678a..9e64bdb403ed 100644 --- a/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c +++ b/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c @@ -2520,12 +2520,6 @@ static int ili9881c_get_modes(struct drm_panel *panel, else connector->display_info.subpixel_order = SubPixelHorizontalRGB; - /* - * TODO: Remove once all drm drivers call - * drm_connector_set_orientation_from_panel() - */ - drm_connector_set_panel_orientation(connector, ctx->orientation); - return 1; } diff --git a/drivers/gpu/drm/panel/panel-lvds.c b/drivers/gpu/drm/panel/panel-lvds.c index 37f7498449ec..92d397b131ba 100644 --- a/drivers/gpu/drm/panel/panel-lvds.c +++ b/drivers/gpu/drm/panel/panel-lvds.c @@ -98,12 +98,6 @@ static int panel_lvds_get_modes(struct drm_panel *panel, &lvds->bus_format, 1); connector->display_info.bus_flags = lvds->bus_flags; - /* - * TODO: Remove once all drm drivers call - * drm_connector_set_orientation_from_panel() - */ - drm_connector_set_panel_orientation(connector, lvds->orientation); - return 1; } diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index e4629428b1b2..0bd0afbd562e 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -396,12 +396,6 @@ static int panel_simple_get_modes(struct drm_panel *panel, /* add hard-coded panel modes */ num += panel_simple_get_non_edid_modes(p, connector); - /* - * TODO: Remove once all drm drivers call - * drm_connector_set_orientation_from_panel() - */ - drm_connector_set_panel_orientation(connector, p->orientation); - return num; } diff --git a/drivers/gpu/drm/panel/panel-sitronix-st7701.c b/drivers/gpu/drm/panel/panel-sitronix-st7701.c index f16e0de1ea60..b6e62a4c67fa 100644 --- a/drivers/gpu/drm/panel/panel-sitronix-st7701.c +++ b/drivers/gpu/drm/panel/panel-sitronix-st7701.c @@ -635,12 +635,6 @@ static int st7701_get_modes(struct drm_panel *panel, connector->display_info.width_mm = desc_mode->width_mm; connector->display_info.height_mm = desc_mode->height_mm; - /* - * TODO: Remove once all drm drivers call - * drm_connector_set_orientation_from_panel() - */ - drm_connector_set_panel_orientation(connector, st7701->orientation); - return 1; } diff --git a/drivers/gpu/drm/panel/panel-sitronix-st7789v.c b/drivers/gpu/drm/panel/panel-sitronix-st7789v.c index da6ed31d151e..4d28efeafd64 100644 --- a/drivers/gpu/drm/panel/panel-sitronix-st7789v.c +++ b/drivers/gpu/drm/panel/panel-sitronix-st7789v.c @@ -361,12 +361,6 @@ static int st7789v_get_modes(struct drm_panel *panel, drm_display_info_set_bus_formats(&connector->display_info, &ctx->info->bus_format, 1); - /* - * TODO: Remove once all drm drivers call - * drm_connector_set_orientation_from_panel() - */ - drm_connector_set_panel_orientation(connector, ctx->orientation); - return 1; } -- 2.47.3