From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.216.45 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793010094; b=FTeSy0UYRG5v9Gv5MXwQU3c6SAyvmmTf0RMZeBbNPzUTg3WgIrpo6hRAazVH5C8dUhvM R/j+Hx7TaL3vTcIgqVDP7T+qvesg2bfvRo0sfHIsSEFeZmVVB42dgIRcSqB55CDaznL+J YbGTCLJtsB9cKnXHpjG4KM/4IHd49Uokxv9uv14hb/Hfl7QUoS1XRDHuX6OVPr5A/g1Fm dv3HPdQOsShZCaNjqDIdOPGEgCrWNtCND0IGlEAj0ZDG9XGWMAZSlzOxvVpDdVxR0nFcs laUH7P1KSnKIP9gynL6bdDOcUHrZ0QeHWJ0pm20NLYqKQ8wRDA0pwsBGAoLNBHViYZA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793010094; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: From:To:Cc:Subject:Date:Message-ID:X-Mailer:In-Reply-To:References: MIME-Version:Content-Transfer-Encoding; bh=Y81mQESgXPYR9nS4rHXdGj0DbylaewWcxtgvMLy1Njk=; b=lG/hVagdNlmdmKO1bdjhBA16+UIRWmx36uW/DblWhXCHTpY+lIT+uilnWj0BhC6A7CzT 4lhDWzzh9E9xZAzpzgxYUml8MBrFCBFoIs0i9ndmAucT00APMa4tC8RVfuD2pYc3kn0jR d2kwIMaz3ukDtUntTJuQJNnejc4fijG8XnwgSz58fddTJGoQAYhbJ6aHuomFXdqS4X9q2 c3NDW9RxuetvfH/f/4UsABnrRvI/lbh3n2Of6npHFzpvKxq0o1Ex3pFyJoLlgK3wzU1k5 w5Pjn3r8d1U+LPS/oe7ndoBS7x9rQeBnIFiNa/ZOnrnQFA4mB4XPqVDcLvoM6l4X8BQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=f5a5vBiT; arc=none smtp.remote-ip=209.85.216.45 Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 94D54606A31A for ; Mon, 26 Oct 2026 10:21:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 94D54606A31A Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=f5a5vBiT Received: by mail-pj1-f45.google.com with SMTP id 98e67ed59e1d1-3ae0852df46so739587a91.0 for ; Mon, 26 Oct 2026 03:21:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1793010093; x=1793614893; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Y81mQESgXPYR9nS4rHXdGj0DbylaewWcxtgvMLy1Njk=; b=f5a5vBiTvg9Zi9Z0yS7Vk2mbeZm2VC4KBM3nTeYWriPlvXnz0ZqXMQ740ao9Ll1OAI vHefA1z9p7Aegguq1wuoWx97T4i6FjAwl5BqG8DMjN7+05pbxTnYUUwdWSaC1roAWwjb UrFf9jdym2SXh7t4P0FR1LKMTN/PoiQAbfThqyoSqF/Bo0XJAecGqrGnbsFzNYtqCA5o /lMK3orQTmr/arMRLRwGlfuamSdVUvLTykCzW//MZ5X4rNNjJH/ZsfDtrGtd+19/us6+ ZaF8vh71YDXgg+v9sIU4bRCTI7l+Ni0HkeSfp/DzCkBbQp6dGfLV/F3dYRX9e2Fa9ARF Eeaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793010093; x=1793614893; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=Y81mQESgXPYR9nS4rHXdGj0DbylaewWcxtgvMLy1Njk=; b=jQDa8+qCrcB5xDSMinxKnZePue5eLIzmcFQ6OqAky9xR34+1Edsmf0aXyVR0fJkbOO 9kNLLnAMYxqXm4AE9mS/Zkw+8wM5fRHNpSBgqGpSIF/nMBuioSCdK7H2qzD7m0FWQQLi iHXROpTzh5fZnO1ks4TxRxC0+J2EoYdfI5nh6qFwO1lzklDFGQxjpU3goX9BiY7UTfm+ yF5FDHr9xySNS+QaZOXEwVKem1jjnhZkfn+O913XbDLkqCcXMH0IfLulAKkCa6uD/07Y 6EUlqlmobl27wxRrXO1veKlAUjSZ+H0cx6lDgNPmK0UWBL+PXGAAdkwt+XydiM6F4HmM WR0Q== X-Forwarded-Encrypted: i=1; AKwUvBzwLrz9ipQkI3eAOjY4hGJZjR5xOcw1S+CpXM3K4ZM4TZra7HWSZddgf4MqT9reF5nh/bmGFEWMJZe2iGc=@vger.kernel.org X-Gm-Message-State: AFq9FYJJSb6PaS1s53T44DqDZlnLecjPp1BGCTNj4xqfQq/q/Es02YWN ebQqbj0CQIXBpp79xh3SvPftVHluSHwOBjMgyjrzbSDQo9UpmpHeVWSH X-Gm-Gg: AYBFou0+16kgjh9wG2ODfrHYjKXEEwW4WZcDUopRESJbqGyqF2KxYTfZnWbbSuYBZbE hIPYCpe8aqXudIJyl5+UIxEk4QMX+q9b96Tx2DJImRtdzB84iAagH3rCG4BD1eJ6Io6REP2bYv1 y0PZC1EVivl2EWmQrHbJsFv/YX7yNQ/eu8T14ubDx2TS/WrQ0BvnGP2ZuvWebw/6LhSHegtCh0R HguS/8+phl06l1W6Q34KpqJBuwod5Eep9BdDPDb9hrzRfxGBrmb251usUvdbVW+pCgbcqXJ76Zb lziSjIh7kUWgpG3YMo0KN77neD/MSFDBn3weJdMH6Tg7eB0PaHIi04qSfYHiEIcnzj9raoiMTeD EUnr+9d7P6Of/pIEmGeimdRykgsO8a8grX1uhJyK5bHAUOBIWNffF7zGYglxBd5pothSjHcdVaZ dui5MfZ/ecRh5aSpANUUDYIJ1NN/bzPiJJolf3Sxuk2etOk5ZeWrJzcCrgFhJXWqXzOtbXE33kp +mvAUt6SAi6CGSthn8J76eZMuicW4WogcZeCA== X-Received: by 2002:a17:90b:3e89:b0:3ad:7f4d:2839 with SMTP id 98e67ed59e1d1-3adeb550e43mr3395198a91.14.1793010092927; Mon, 26 Oct 2026 03:21:32 -0700 (PDT) Received: from qby-nixos-laptop ([2a13:edc0:18:16f::a]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3adebe6af0dsm7877467a91.5.2026.10.26.03.21.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Oct 2026 03:21:32 -0700 (PDT) From: Mingyou Chen To: =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , Hans de Goede , Ilya Gladyshev Cc: KentoNion , platform-driver-x86@vger.kernel.org, ted eric , Armin Wolf , linux-kernel@vger.kernel.org, Chris Taraszka , Matias Civadda , =?UTF-8?q?=E9=AB=98=20=E4=BF=8A=E6=96=87?= , powerfullz , =?UTF-8?q?=E5=AD=99=20=E8=AA=89=E9=93=AD?= , =?UTF-8?q?Milo=C5=A1=20Vlku?= , Rsplwe , Bozhen Peng , Anton Karasev , Jame Jao , Serhiy Shliapuhin , Mingyou Chen , Nika Krasnova Subject: [PATCH v14 2/6] platform/x86: bitland-mifs-wmi: Merge the function of redmi-wmi into the bitland driver Date: Mon, 26 Oct 2026 18:20:57 +0800 Message-ID: <20261026102101.224568-3-qby140326@gmail.com> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261026102101.224568-1-qby140326@gmail.com> References: <20261026102101.224568-1-qby140326@gmail.com> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The bitland-mifs-wmi and legacy redmi-wmi drivers both attempt to bind to the same WMI GUID (46C93E13-EE9B-4262-8488-563BCA757FEF). This overlap causes a device registration conflict, preventing one of the drivers from loading properly depending on the module initialization order. Merge the event handling logic from redmi-wmi into bitland-mifs-wmi. By handling both device layouts within a single driver, we eliminate the GUID ownership conflict. Tested-by: Nika Krasnova Tested-by: Ilya Gladyshev Reviewed-by: Ilya Gladyshev Signed-off-by: Mingyou Chen --- drivers/platform/x86/bitland-mifs-wmi.c | 153 ++++++++++++++++-------- 1 file changed, 106 insertions(+), 47 deletions(-) diff --git a/drivers/platform/x86/bitland-mifs-wmi.c b/drivers/platform/x86/bitland-mifs-wmi.c index dd1648b7de77..9afa2e2764b0 100644 --- a/drivers/platform/x86/bitland-mifs-wmi.c +++ b/drivers/platform/x86/bitland-mifs-wmi.c @@ -35,6 +35,11 @@ #include #include +#define BI_HOTKEY_CODE(id, low, high) \ + (((u32)(high) << 24) | ((u32)(low) << 16) | ((u32)(id) << 8) | WMI_EVENT_TYPE_HOTKEY) + +#define AI_KEY_VALUE_MASK BIT(8) + #define DRV_NAME "bitland-mifs-wmi" #define BITLAND_MIFS_GUID "B60BFB48-3E5B-49E4-A0E9-8CFFE1B3434B" #define BITLAND_EVENT_GUID "46C93E13-EE9B-4262-8488-563BCA757FEF" @@ -80,9 +85,9 @@ enum bitland_mifs_power_profile { }; enum bitland_mifs_event_id { - WMI_EVENT_RESERVED_1 = 1, - WMI_EVENT_RESERVED_2 = 2, - WMI_EVENT_RESERVED_3 = 3, + WMI_EVENT_SWITCHVIDEOMODE = 1, + WMI_EVENT_SELECTIVE_SCREENSHOT = 2, + WMI_EVENT_ALL_APPLICATIONS = 3, WMI_EVENT_AIRPLANE_MODE = 4, WMI_EVENT_KBD_BRIGHTNESS = 5, WMI_EVENT_TOUCHPAD_STATE = 6, @@ -100,10 +105,11 @@ enum bitland_mifs_event_id { WMI_EVENT_FN_1 = 19, WMI_EVENT_FN_2 = 20, WMI_EVENT_FN_3 = 21, - WMI_EVENT_FN_4 = 22, + WMI_EVENT_PERFORMANCE_PLAN_ALT = 22, WMI_EVENT_FN_5 = 24, WMI_EVENT_REFRESH_RATE = 25, WMI_EVENT_CPU_FAN_SPEED = 26, + WMI_EVENT_CONFIG = 27, WMI_EVENT_GPU_FAN_SPEED = 32, WMI_EVENT_WIN_KEY_LOCK = 33, WMI_EVENT_RESERVED_23 = 34, @@ -607,18 +613,54 @@ static const struct attribute *const laptop_attrs[] = { ATTRIBUTE_GROUPS(laptop); static const struct key_entry bitland_mifs_wmi_keymap[] = { - { KE_KEY, WMI_EVENT_OPEN_APP, { KEY_PROG1 } }, - { KE_KEY, WMI_EVENT_CALCULATOR_START, { KEY_CALC } }, - { KE_KEY, WMI_EVENT_BROWSER_START, { KEY_WWW } }, - { KE_IGNORE, WMI_EVENT_FN_J, { KEY_RESERVED } }, - { KE_IGNORE, WMI_EVENT_FN_F, { KEY_RESERVED } }, - { KE_IGNORE, WMI_EVENT_FN_0, { KEY_RESERVED } }, - { KE_IGNORE, WMI_EVENT_FN_1, { KEY_RESERVED } }, - { KE_IGNORE, WMI_EVENT_FN_2, { KEY_RESERVED } }, - { KE_IGNORE, WMI_EVENT_FN_3, { KEY_RESERVED } }, - { KE_IGNORE, WMI_EVENT_FN_4, { KEY_RESERVED } }, - { KE_IGNORE, WMI_EVENT_FN_5, { KEY_RESERVED } }, - { KE_END, 0 } + { KE_KEY, BI_HOTKEY_CODE(WMI_EVENT_OPEN_APP, 1, 0), { KEY_PROG1 } }, + + { KE_KEY, BI_HOTKEY_CODE(WMI_EVENT_CALCULATOR_START, 1, 0), { KEY_CALC } }, + + { KE_KEY, BI_HOTKEY_CODE(WMI_EVENT_BROWSER_START, 1, 0), { KEY_WWW } }, + + { KE_IGNORE, BI_HOTKEY_CODE(WMI_EVENT_FN_J, 0, 0), {} }, + { KE_IGNORE, BI_HOTKEY_CODE(WMI_EVENT_FN_F, 0, 0), {} }, + { KE_IGNORE, BI_HOTKEY_CODE(WMI_EVENT_FN_0, 0, 0), {} }, + { KE_IGNORE, BI_HOTKEY_CODE(WMI_EVENT_FN_1, 0, 0), {} }, + { KE_IGNORE, BI_HOTKEY_CODE(WMI_EVENT_FN_2, 0, 0), {} }, + { KE_IGNORE, BI_HOTKEY_CODE(WMI_EVENT_FN_3, 0, 0), {} }, + { KE_IGNORE, BI_HOTKEY_CODE(WMI_EVENT_FN_5, 0, 0), {} }, + + { KE_KEY, BI_HOTKEY_CODE(WMI_EVENT_SELECTIVE_SCREENSHOT, 0, 0), + { KEY_SELECTIVE_SCREENSHOT } }, + { KE_KEY, BI_HOTKEY_CODE(WMI_EVENT_ALL_APPLICATIONS, 0, 0), { KEY_ALL_APPLICATIONS } }, + { KE_KEY, BI_HOTKEY_CODE(WMI_EVENT_CONFIG, 0, 0), { KEY_CONFIG } }, + { KE_KEY, BI_HOTKEY_CODE(WMI_EVENT_CONFIG, 1, 0), { KEY_CONFIG } }, + { KE_KEY, BI_HOTKEY_CODE(WMI_EVENT_SWITCHVIDEOMODE, 1, 0), { KEY_SWITCHVIDEOMODE } }, + { KE_KEY, BI_HOTKEY_CODE(WMI_EVENT_SWITCHVIDEOMODE, 0, 0), { KEY_SWITCHVIDEOMODE } }, + { KE_KEY, BI_HOTKEY_CODE(WMI_EVENT_REFRESH_RATE, 0, 0), { KEY_REFRESH_RATE_TOGGLE } }, + + /* AI button has code for each position */ + { KE_KEY, BI_HOTKEY_CODE(WMI_EVENT_FN_5, 1, 0), { KEY_ASSISTANT } }, + + { KE_KEY, BI_HOTKEY_CODE(0x19, 1, 0), { KEY_ASSISTANT } }, + + { KE_KEY, BI_HOTKEY_CODE(WMI_EVENT_KBD_BRIGHTNESS, 0, 0), {KEY_KBDILLUMTOGGLE} }, + { KE_KEY, BI_HOTKEY_CODE(WMI_EVENT_KBD_BRIGHTNESS, 0x80, 0), {KEY_KBDILLUMTOGGLE} }, + { KE_KEY, BI_HOTKEY_CODE(WMI_EVENT_KBD_BRIGHTNESS, 5, 0), {KEY_KBDILLUMTOGGLE} }, + { KE_KEY, BI_HOTKEY_CODE(WMI_EVENT_KBD_BRIGHTNESS, 0x0a, 0), {KEY_KBDILLUMTOGGLE} }, + + /* Xiaomi G Command Center */ + { KE_KEY, BI_HOTKEY_CODE(0x0a, 1, 0), { KEY_VENDOR } }, + + /* Fn Lock state */ + { KE_KEY, BI_HOTKEY_CODE(WMI_EVENT_FNLOCK_STATE, 0, 0), { KEY_FN_ESC } }, + { KE_KEY, BI_HOTKEY_CODE(WMI_EVENT_FNLOCK_STATE, 1, 0), { KEY_FN_ESC } }, + + /* Fn+`/1/2/3/4 */ + { KE_KEY, BI_HOTKEY_CODE(WMI_EVENT_FN_F, 1, 0), { KEY_F13 } }, + { KE_KEY, BI_HOTKEY_CODE(WMI_EVENT_FN_0, 1, 0), { KEY_F14 } }, + { KE_KEY, BI_HOTKEY_CODE(WMI_EVENT_FN_1, 1, 0), { KEY_F15 } }, + { KE_KEY, BI_HOTKEY_CODE(WMI_EVENT_FN_2, 1, 0), { KEY_F16 } }, + { KE_KEY, BI_HOTKEY_CODE(WMI_EVENT_FN_3, 1, 0), { KEY_F17 } }, + + { KE_END } }; static void bitland_notifier_unregister(void *data) @@ -736,13 +778,42 @@ static int bitland_mifs_wmi_probe(struct wmi_device *wdev, const void *context) &drv_data->notifier); } +static bool bitland_is_ai_key_scancode(unsigned int code) +{ + return code == BI_HOTKEY_CODE(WMI_EVENT_FN_5, 1, 0) || + code == BI_HOTKEY_CODE(0x19, 1, 0); +} + +static void bitland_mifs_wmi_report_key(struct wmi_device *wdev, u32 payload) +{ + struct bitland_mifs_wmi_data *data = dev_get_drvdata(&wdev->dev); + struct key_entry *entry; + bool autorelease = true; + int value = 1; + + entry = sparse_keymap_entry_from_scancode(data->input_dev, payload); + if (!entry) { + dev_dbg(&wdev->dev, "Unknown WMI hotkey with payload 0x%08x\n", payload); + return; + } + + /* AI key quirk */ + if (bitland_is_ai_key_scancode(entry->code)) { + value = !(payload & AI_KEY_VALUE_MASK); + autorelease = false; + } + + guard(mutex)(&data->lock); + sparse_keymap_report_entry(data->input_dev, entry, value, autorelease); +} + static void bitland_mifs_wmi_notify(struct wmi_device *wdev, const struct wmi_buffer *buffer) { - struct bitland_mifs_wmi_data *data = dev_get_drvdata(&wdev->dev); const struct bitland_mifs_event *event = buffer->data; struct bitland_fan_notify_data fan_data; u8 brightness; + u32 payload; /* Validate event type */ if (event->event_type != WMI_EVENT_TYPE_HOTKEY) @@ -758,24 +829,14 @@ static void bitland_mifs_wmi_notify(struct wmi_device *wdev, blocking_notifier_call_chain(&bitland_notifier_list, BITLAND_NOTIFY_KBD_BRIGHTNESS, &brightness); - break; + return; case WMI_EVENT_PERFORMANCE_PLAN: + case WMI_EVENT_PERFORMANCE_PLAN_ALT: blocking_notifier_call_chain(&bitland_notifier_list, BITLAND_NOTIFY_PLATFORM_PROFILE, NULL); - break; - - case WMI_EVENT_OPEN_APP: - case WMI_EVENT_CALCULATOR_START: - case WMI_EVENT_BROWSER_START: { - guard(mutex)(&data->lock); - if (!sparse_keymap_report_event(data->input_dev, - event->event_id, 1, true)) - dev_warn(&wdev->dev, "Unknown key pressed: 0x%02x\n", - event->event_id); - break; - } + return; /* * The device has 3 fans (CPU, GPU, SYS), @@ -783,6 +844,14 @@ static void bitland_mifs_wmi_notify(struct wmi_device *wdev, */ case WMI_EVENT_CPU_FAN_SPEED: case WMI_EVENT_GPU_FAN_SPEED: + /* Redmi refresh rate toggle quirk */ + if (event->event_id == WMI_EVENT_CPU_FAN_SPEED && + event->value_low == 0 && event->value_high == 0) { + payload = BI_HOTKEY_CODE(WMI_EVENT_REFRESH_RATE, 0, 0); + bitland_mifs_wmi_report_key(wdev, payload); + return; + } + if (event->event_id == WMI_EVENT_CPU_FAN_SPEED) fan_data.channel = 0; else @@ -793,27 +862,17 @@ static void bitland_mifs_wmi_notify(struct wmi_device *wdev, blocking_notifier_call_chain(&bitland_notifier_list, BITLAND_NOTIFY_HWMON, &fan_data); - break; - - case WMI_EVENT_AIRPLANE_MODE: - case WMI_EVENT_TOUCHPAD_STATE: - case WMI_EVENT_FNLOCK_STATE: - case WMI_EVENT_KBD_MODE: - case WMI_EVENT_CAPSLOCK_STATE: - case WMI_EVENT_NUMLOCK_STATE: - case WMI_EVENT_SCROLLLOCK_STATE: - case WMI_EVENT_REFRESH_RATE: - case WMI_EVENT_WIN_KEY_LOCK: - /* These events are informational or handled by firmware */ - dev_dbg(&wdev->dev, "State change event: id=%d value=%d\n", - event->event_id, event->value_low); - break; + return; default: - dev_dbg(&wdev->dev, "Unknown event: id=0x%02x value=0x%02x\n", - event->event_id, event->value_low); + dev_dbg(&wdev->dev, + "Unknown WMI event: id=0x%02x value_low=0x%02x value_high=0x%02x\n", + event->event_id, event->value_low, event->value_high); break; } + + payload = get_unaligned_le32(buffer->data); + bitland_mifs_wmi_report_key(wdev, payload); } static const struct wmi_device_id bitland_mifs_wmi_id_table[] = { -- 2.56.0