From: Yuanhe Shu <xiangzao@linux.alibaba.com>
To: sashiko-bot@kernel.org
Cc: mkp@kernel.org, linux-scsi@vger.kernel.org,
target-devel@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org, john.garry@linux.dev, ddiss@suse.de,
hexlabsecurity@proton.me, xiangzao@linux.alibaba.com
Subject: Re: [PATCH] scsi: target: Verify the iSCSI ISID is NUL-terminated
Date: Mon, 26 Oct 2026 20:48:01 +0800 [thread overview]
Message-ID: <20261026124801.2720682-1-xiangzao@linux.alibaba.com> (raw)
In-Reply-To: <sashiko-outbox-184760@kernel.org>
Sashiko is right. get_unaligned_be64() reads the first 8 bytes
unconditionally, and the NUL check alone does not bound that when
fewer than 8 bytes remain in the descriptor.
v2 requires 8 bytes to remain after the separator, in addition to
the NUL, so every consumer stays inside the descriptor.
v2: https://lore.kernel.org/r/20261026124138.2708365-1-xiangzao@linux.alibaba.com/
--
Yuanhe
prev parent reply other threads:[~2026-10-26 12:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-26 4:46 Yuanhe Shu
2026-10-26 12:41 ` [PATCH v2] " Yuanhe Shu
[not found] ` <sashiko-outbox-184760@kernel.org>
2026-10-26 12:48 ` Yuanhe Shu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261026124801.2720682-1-xiangzao@linux.alibaba.com \
--to=xiangzao@linux.alibaba.com \
--cc=ddiss@suse.de \
--cc=hexlabsecurity@proton.me \
--cc=john.garry@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mkp@kernel.org \
--cc=sashiko-bot@kernel.org \
--cc=stable@vger.kernel.org \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®