From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793019795; b=5GgKlf+TEKR6/CTutWIwh/qw/gSVgy7FgYJsI4pg6Uk1TFUOs3bU8myrdhURrEp0iFbv nnHC5RU+ChGhXVqUd0kwcJOUoYWesz4lbDCQdI7kZt+x/KZP22GVS9cusx2BVDQH54IRQ i0IYd8zNVhsnIKeJWFx8LBgFyzClkDgO6trUo20sSJseIzrbJqFKgc3tZL8GYlX2y9WEW O0YE5wC35M5N5Qqc6VknmmIDjYtyoHfIobF4mFCVE9gGoi2V+6mDcr512pBdgAkOZYH+c T02u0LYKo9RN7IVAwkwHdqATHTo/TOn/zfiQqOihjhmkQcgLq6IwQPlSy2kIByIT2LA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793019795; h=DMARC-Filter:Received:Received:Received:From:To:Cc:Subject:Date: Message-ID:X-Mailer:In-Reply-To:References:MIME-Version: Content-Transfer-Encoding:X-Rspamd-Pre-Result:X-Rspamd-Queue-Id: X-Rspamd-Pre-Result:X-Rspamd-Action:X-Rspamd-Server:X-Spam-Level: X-Spamd-Result:X-Spam-Flag:X-Spam-Score; bh=2nDeeFVd3Ir/trL1J9h2hfL4Jj4JoqZNrHAGr6KWNhI=; b=asZUstCAopou9p8IS9RrvLLDCilXXQORxThiC+VumpMniMtcNxUzNiI7Hsn167tTZPXG yiVInzbfiXh0XisjwLPXu+HE3/Ka0iCpc3zN0cK1Pn248xOgRDeYJ6N9HS9cqhwjiCO0Q bGPjTALWzwgNOal6svhe8GW1HVNSdEEK9tbbCld59PiKll2B7zFEWdY3afmTlvtru3y3e 7gGBiQ8VsVfBWd98+BI5g+Lilit+ianVyTiNnIJy4D1cUNO8UIzb2sy4sY37T5bA4zn9k IMvYYZC8DpVhnu8qC5YOGChEOmUpvRNtKxAKxznJTFyalTrxRVK5BZ2AzWBYPFNVAGQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=suse.com; spf=pass smtp.mailfrom=suse.com; arc=none smtp.remote-ip=195.135.223.131 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 33805606A31D; Mon, 26 Oct 2026 13:03:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 33805606A31D Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id AA1721F806; Mon, 26 Oct 2026 13:03:13 +0000 (UTC) Authentication-Results: smtp-out2.suse.de; none Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 58DD9134EA; Mon, 26 Oct 2026 13:03:13 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id aWs/DJFP32pDWwAAD6G6ig (envelope-from ); Mon, 26 Oct 2026 13:03:13 +0000 From: Juergen Gross To: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org Cc: Juergen Gross , Linus Walleij , Bartosz Golaszewski , Bartosz Golaszewski Subject: [PATCH v5 08/12] drivers/gpio: Stop using 32-bit MSR interfaces Date: Mon, 26 Oct 2026 14:02:19 +0100 Message-ID: <20261026130223.773129-9-jgross@suse.com> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261026130223.773129-1-jgross@suse.com> References: <20261026130223.773129-1-jgross@suse.com> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Queue-Id: AA1721F806 X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Action: no action X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spam-Level: X-Spamd-Result: default: False [-4.00 / 50.00]; REPLY(-4.00)[] X-Spam-Flag: NO X-Spam-Score: -4.00 The 32-bit MSR interfaces rdmsr() and wrmsr() are planned to be removed. Use the related 64-bit variants instead. Signed-off-by: Juergen Gross Acked-by: Bartosz Golaszewski --- drivers/gpio/gpio-cs5535.c | 10 +++++----- include/linux/cs5535.h | 10 +++++----- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/gpio/gpio-cs5535.c b/drivers/gpio/gpio-cs5535.c index 5f5373d86397..a97ec7561889 100644 --- a/drivers/gpio/gpio-cs5535.c +++ b/drivers/gpio/gpio-cs5535.c @@ -143,17 +143,17 @@ EXPORT_SYMBOL_GPL(cs5535_gpio_isset); int cs5535_gpio_set_irq(unsigned group, unsigned irq) { - uint32_t lo, hi; + struct msr val; if (group > 7 || irq > 15) return -EINVAL; - rdmsr(MSR_PIC_ZSEL_HIGH, lo, hi); + rdmsrq(MSR_PIC_ZSEL_HIGH, val.q); - lo &= ~(0xF << (group * 4)); - lo |= (irq & 0xF) << (group * 4); + val.l &= ~(0xF << (group * 4)); + val.l |= (irq & 0xF) << (group * 4); - wrmsr(MSR_PIC_ZSEL_HIGH, lo, hi); + wrmsrq(MSR_PIC_ZSEL_HIGH, val.q); return 0; } EXPORT_SYMBOL_GPL(cs5535_gpio_set_irq); diff --git a/include/linux/cs5535.h b/include/linux/cs5535.h index 2be1120174eb..5ec2aca537bb 100644 --- a/include/linux/cs5535.h +++ b/include/linux/cs5535.h @@ -49,12 +49,12 @@ static inline int cs5535_pic_unreqz_select_high(unsigned int group, unsigned int irq) { - uint32_t lo, hi; + struct msr val; - rdmsr(MSR_PIC_ZSEL_HIGH, lo, hi); - lo &= ~(0xF << (group * 4)); - lo |= (irq & 0xF) << (group * 4); - wrmsr(MSR_PIC_ZSEL_HIGH, lo, hi); + rdmsrq(MSR_PIC_ZSEL_HIGH, val.q); + val.l &= ~(0xF << (group * 4)); + val.l |= (irq & 0xF) << (group * 4); + wrmsrq(MSR_PIC_ZSEL_HIGH, val.q); return 0; } -- 2.56.0