mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Niklas Söderlund" <niklas.soderlund@ragnatech.se>
To: "Barnabás Pőcze" <barnabas.pocze+renesas@ideasonboard.com>
Cc: Jacopo Mondi <jacopo.mondi+renesas@ideasonboard.com>,
	Jai Luthra <jai.luthra+renesas@ideasonboard.com>,
	Sakari Ailus <sakari.ailus@linux.intel.com>,
	linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] media: rppx1: wbmeas: Fix uapi documentation
Date: Mon, 26 Oct 2026 15:10:33 +0100	[thread overview]
Message-ID: <20261026141033.GC1959885@ragnatech.se> (raw)
In-Reply-To: <20261026140215.603906-1-barnabas.pocze+renesas@ideasonboard.com>

Hi Barnabás,

Thanks for your work.

On 2026-10-26 15:02:15 +0100, Barnabás Pőcze wrote:
> The format is Q4.12 as already mentioned earlier in the documentation.
> 
> Fixes: 884d6794a816 ("media: rppx1: wbmeas: Add support for white balance measurement")
> Signed-off-by: Barnabás Pőcze <barnabas.pocze+renesas@ideasonboard.com>

Nice catch.

Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>

> ---
>  include/uapi/linux/media/dreamchip/rppx1-config.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/uapi/linux/media/dreamchip/rppx1-config.h b/include/uapi/linux/media/dreamchip/rppx1-config.h
> index 3507a9ab03dfd..f7c5a88922444 100644
> --- a/include/uapi/linux/media/dreamchip/rppx1-config.h
> +++ b/include/uapi/linux/media/dreamchip/rppx1-config.h
> @@ -154,7 +154,7 @@ enum rppx1_wbmeas_mode {
>   *	   @ymax_cmp is set to enabled, 24 bits
>   * @max_csum: chrominance sum maximum value, 24 bits
>   * @min_c: chrominance minimum value, 24 bits
> - * @ccor_coeff: coefficients for color conversion matrix, signed 16 bits Q4.6
> + * @ccor_coeff: coefficients for color conversion matrix, signed 16 bits Q4.12
>   * @reserved2: padding
>   * @ccor_offs: R-G-B color conversion coefficients, signed 25 bits 2's complement
>   * @reserved3: padding
> -- 
> 2.56.0
> 

-- 
Kind Regards,
Niklas Söderlund

      reply	other threads:[~2026-10-26 14:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-26 14:02 Barnabás Pőcze
2026-10-26 14:10 ` Niklas Söderlund [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261026141033.GC1959885@ragnatech.se \
    --to=niklas.soderlund@ragnatech.se \
    --cc=barnabas.pocze+renesas@ideasonboard.com \
    --cc=jacopo.mondi+renesas@ideasonboard.com \
    --cc=jai.luthra+renesas@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®