From: Leonardo Bras <leo.bras@arm.com>
To: Oliver Upton <oupton@kernel.org>, Marc Zyngier <maz@kernel.org>,
Fuad Tabba <fuad.tabba@linux.dev>,
Joey Gouly <joey.gouly@arm.com>,
Steffen Eiden <seiden@linux.ibm.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Zenghui Yu <yuzenghui@huawei.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Leonardo Bras <leo.bras@arm.com>,
Raghavendra Rao Ananta <rananta@google.com>,
Tian Zheng <zhengtian10@huawei.com>
Cc: linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: [RFC PATCH v2 0/3] Set DBM bit on writable pages
Date: Mon, 26 Oct 2026 14:44:06 +0000 [thread overview]
Message-ID: <20261026144413.441566-1-leo.bras@arm.com> (raw)
When HAFDBS is enabled (VTCR_EL2.{HA,HD}={1,1}), having a DBM bit allows
hardware to promote a non-writable page to writable by setting (S2AP[1]=1),
without having to take a fault.
The reason for this patchset is to add the DBM bit when setting-up writable
pages, so the code is prepared for future patches that make use of
HDBSS/HACDBS to accelerate dirty-tracking. Write-bit detection still
happens based only in S2AP[1], so no change in that aspect.
Having DBM set on block entries is undesired, as we benefit from the first
fault for splitting it in PAGE_SIZE entries, which is the granularity used
to track the dirty pages in KVM. So introduce a new walker that, on top of
clearing S2AP[1] for every entry, also clear DBM for block entries.
Also introduce a new VCPU request to reload Stage2, as it will be needed on
future HDBSS/HAFDBS patchsets.
Please let me know of what do you think!
Changes since RFCv1:
- Dropped patch #5 on enabling HAFDBS on non-dirty-tracking guests, as it
proved to be counter-productive on wrprotect, contrary to expectations
- No more moving writable-bit to DBM. That does not seem to be the intended
use. It makes sense and it's easier to convert code to new DBM approach.
- No new PROT_DIRTY, so drop patch #2
- Tried adding a PROT_DBM, but does not seem necessary to fault a page as
writable-clean.
- KVM_REQ_RELOAD_STAGE2 now depends on VHE, as it already reloads Stage2 on
guest entry otherwise.
Link: https://lore.kernel.org/all/20260901171558.2674031-1-leo.bras@arm.com/
Thanks!
Leo
Leonardo Bras (3):
KVM: arm64: pgtables: Set DBM attribute on writable Stage-2 PTEs
KVM: arm64: Introduce a dedicated walker for stage2 write-protect
KVM: arm64: Add KVM_REQ_RELOAD_STAGE2
arch/arm64/include/asm/kvm_host.h | 2 ++
arch/arm64/include/asm/kvm_pgtable.h | 3 +++
arch/arm64/kvm/arm.c | 10 ++++++++++
arch/arm64/kvm/hyp/pgtable.c | 30 ++++++++++++++++++++++------
4 files changed, 39 insertions(+), 6 deletions(-)
base-commit: c03c1a14507dfaf8b856c2608f9ac216021fc222
--
2.56.0
next reply other threads:[~2026-10-26 14:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-26 14:44 Leonardo Bras [this message]
2026-10-26 14:44 ` [RFC PATCH v2 1/3] KVM: arm64: pgtables: Set DBM attribute on writable Stage-2 PTEs Leonardo Bras
2026-10-26 14:44 ` [RFC PATCH v2 2/3] KVM: arm64: Introduce a dedicated walker for stage2 write-protect Leonardo Bras
2026-10-26 14:44 ` [RFC PATCH v2 3/3] KVM: arm64: Add KVM_REQ_RELOAD_STAGE2 Leonardo Bras
2026-10-26 19:08 ` [RFC PATCH v2 0/3] Set DBM bit on writable pages Oliver Upton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261026144413.441566-1-leo.bras@arm.com \
--to=leo.bras@arm.com \
--cc=catalin.marinas@arm.com \
--cc=fuad.tabba@linux.dev \
--cc=joey.gouly@arm.com \
--cc=kvmarm@lists.linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=oupton@kernel.org \
--cc=rananta@google.com \
--cc=seiden@linux.ibm.com \
--cc=suzuki.poulose@arm.com \
--cc=will@kernel.org \
--cc=yuzenghui@huawei.com \
--cc=zhengtian10@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®