From: Joshua Crofts <joshua.crofts1@gmail.com>
To: Arnav Kapoor <kapoorarnav43@gmail.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Andy Shevchenko" <andriy.shevchenko@intel.com>,
"Gwendal Grignou" <gwendal@chromium.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/3] iio: proximity: sx93xx: keep the IRQ balanced across suspend and resume
Date: Mon, 26 Oct 2026 15:21:36 +0100 [thread overview]
Message-ID: <20261026152136.0000047d@gmail.com> (raw)
In-Reply-To: <20261026112342.65917-1-kapoorarnav43@gmail.com>
On Mon, 26 Oct 2026 16:53:03 +0530
Arnav Kapoor <kapoorarnav43@gmail.com> wrote:
> sx9310, sx9324 and sx9360 disable the interrupt in suspend before
> anything that can fail, and don't enable it again when suspend or resume
> fails. Without an interrupt line they also act on IRQ 0. One patch per
> driver, as the Fixes tags differ.
>
> Changes in v2:
> - Send as a series with a cover letter (Joshua)
> - sx9310: move the wake-up register writes into a helper that uses
> guard(), so resume can use the usual early returns (Andy)
> - sx9324, sx9360: no changes
>
> v1:
> https://lore.kernel.org/all/20261026100322.16720-1-kapoorarnav43@gmail.com/
> https://lore.kernel.org/all/20261026100408.16874-1-kapoorarnav43@gmail.com/
> https://lore.kernel.org/all/20261026100450.17023-1-kapoorarnav43@gmail.com/
>
> Compile-tested only (W=1); I don't have the hardware and haven't
> reproduced a failing suspend.
The code seems good, would be great if someone could test this.
Reviewed-by: Joshua Crofts <joshua.crofts1@gmail.com>
--
Kind regards,
Joshua Crofts
prev parent reply other threads:[~2026-10-26 14:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-26 11:23 Arnav Kapoor
2026-10-26 11:23 ` [PATCH v2 1/3] iio: proximity: sx9310: " Arnav Kapoor
2026-10-26 14:58 ` Andy Shevchenko
2026-10-26 11:23 ` [PATCH v2 2/3] iio: proximity: sx9324: " Arnav Kapoor
2026-10-26 11:23 ` [PATCH v2 3/3] iio: proximity: sx9360: " Arnav Kapoor
2026-10-26 14:21 ` Joshua Crofts [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261026152136.0000047d@gmail.com \
--to=joshua.crofts1@gmail.com \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=gwendal@chromium.org \
--cc=jic23@kernel.org \
--cc=kapoorarnav43@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®