From: Aldo Ariel Panzardo <qwe.aldo@gmail.com>
To: Yu Zhang <yuz08559@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Massimo Toscanelli <massimo.toscanelli@leica-geosystems.com>,
Neill Kapron <nkapron@google.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Aldo Ariel Panzardo <qwe.aldo@gmail.com>
Subject: Re: [PATCH] usb: gadget: f_ecm: serialize notification state with a spinlock
Date: Mon, 26 Oct 2026 13:44:51 -0300 [thread overview]
Message-ID: <20261026164451.548670-1-qwe.aldo@gmail.com> (raw)
In-Reply-To: <20261026060031.60582-1-yuz08559@gmail.com>
The locking itself looks right -- matches what f_ncm already does,
and dropping the lock around usb_ep_queue() avoids the re-entrant
completion deadlock.
Note this conflicts with [1] which removes the ecm_notify() call
from ecm_set_alt(). If [1] lands first, drop the lock/unlock pair
around that call from this patch.
[1] https://lore.kernel.org/linux-usb/20261023-ncm-ecm-lpm-v1-2-d01e81fbf460@leica-geosystems.com/
Reviewed-by: Aldo Ariel Panzardo <qwe.aldo@gmail.com>
prev parent reply other threads:[~2026-10-26 16:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-26 6:00 Yu Zhang
2026-10-26 16:44 ` Aldo Ariel Panzardo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261026164451.548670-1-qwe.aldo@gmail.com \
--to=qwe.aldo@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=massimo.toscanelli@leica-geosystems.com \
--cc=nkapron@google.com \
--cc=yuz08559@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®