mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Christian Ruppert <arc@gmx.li>
To: perex@perex.cz, tiwai@suse.com, linux-kernel@vger.kernel.org,
	linux-sound@vger.kernel.org
Cc: arc@gmx.li, mrwillporter@gmail.com
Subject: [PATCH 2/4] ALSA: mixer_evo: Add missing snd_usb_lock calls
Date: Mon, 26 Oct 2026 18:44:24 +0100	[thread overview]
Message-ID: <20261026174427.24947-3-arc@gmx.li> (raw)
In-Reply-To: <20261026174427.24947-1-arc@gmx.li>

Bugfix: Add missing snd_usb_lock_shutdown calls to mixer_evo.c.

Signed-off-by: Christian Ruppert <arc@gmx.li>
---
 sound/usb/mixer_evo.c | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/sound/usb/mixer_evo.c b/sound/usb/mixer_evo.c
index 26846108a3e1..1fbcbe61b708 100644
--- a/sound/usb/mixer_evo.c
+++ b/sound/usb/mixer_evo.c
@@ -275,6 +275,10 @@ static int snd_ctl_evo_boolean_get(struct snd_kcontrol *kctl,
 
 	int i;
 
+	CLASS(snd_usb_lock, pm)(mixer->chip);
+	if (pm.err < 0)
+		return pm.err;
+
 	for (i = 0; i < hwchan; i++) {
 		u32 buf;
 		int ret;
@@ -312,6 +316,10 @@ static int snd_ctl_evo_boolean_set(struct snd_kcontrol *kctl,
 	int changed = 0;
 	int i;
 
+	CLASS(snd_usb_lock, pm)(mixer->chip);
+	if (pm.err < 0)
+		return pm.err;
+
 	for (i = 0; i < hwchan; i++) {
 		u32 rbuf;
 		u32 buf = cpu_to_le32(ctl_val->value.integer.value[i] ? 1 : 0);
@@ -352,6 +360,10 @@ static int snd_ctl_evo_integer_get(struct snd_kcontrol *kctl,
 
 	int i;
 
+	CLASS(snd_usb_lock, pm)(mixer->chip);
+	if (pm.err < 0)
+		return pm.err;
+
 	for (i = 0; i < hwchan; i++) {
 		u16 buf;
 		s16 val;
@@ -386,6 +398,10 @@ static int snd_ctl_evo_integer_set(struct snd_kcontrol *kctl,
 	int changed = 0;
 	int i;
 
+	CLASS(snd_usb_lock, pm)(mixer->chip);
+	if (pm.err < 0)
+		return pm.err;
+
 	for (i = 0; i < hwchan; i++) {
 		s16 rbuf;
 		s16 buf = cpu_to_le16(ctl_val->value.integer.value[i]);
-- 
2.56.0


  parent reply	other threads:[~2026-10-26 17:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-26 17:44 [PATCH 0/4] ALSA: mixer_evo: minor fixes and tlv addition Christian Ruppert
2026-10-26 17:44 ` [PATCH 1/4] ALSA: mixer_evo: Remove double end marker device list Christian Ruppert
2026-10-26 17:44 ` Christian Ruppert [this message]
2026-10-26 17:44 ` [PATCH 3/4] ALSA: mixer_evo: Fix endianness of boolean inversion Christian Ruppert
2026-10-26 17:44 ` [PATCH 4/4] ALSA: mixer_evo: Add tlv for mixer channels Christian Ruppert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261026174427.24947-3-arc@gmx.li \
    --to=arc@gmx.li \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=mrwillporter@gmail.com \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®