From: Florian Fainelli <florian.fainelli@broadcom.com>
To: netdev@vger.kernel.org
Cc: "Florian Fainelli" <florian.fainelli@broadcom.com>,
"Jonas Gorski" <jonas.gorski@gmail.com>,
"Andrew Lunn" <andrew@lunn.ch>,
"Vladimir Oltean" <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@kernel.org>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Rafał Miłecki" <rafal@milecki.pl>,
"Broadcom internal kernel review list"
<bcm-kernel-feedback-list@broadcom.com>,
"Jon Mason" <jon.mason@broadcom.com>,
"Arnd Bergmann" <arnd@arndb.de>,
linux-kernel@vger.kernel.org (open list)
Subject: [PATCH net v3 0/2] Fix TCP retransmissions on NS/NSP SoCs
Date: Mon, 26 Oct 2026 13:37:40 -0700 [thread overview]
Message-ID: <20261026203742.3198673-1-florian.fainelli@broadcom.com> (raw)
On Northstar and Northstar Plus SoCs we would see about 1000 TCP
retransmissions per second due to a rate mismatch between bgmac and b53,
make sure that we run at the same speed on both side to avoid dropping
packets on the floor.
This issue was found during testing on a Northstar Plus reference board
(BCM958625HR) while running iperf3 to a test machine and noticing
retranmsisions:
# iperf3 -c 192.168.3.1
Connecting to host 192.168.3.1, port 5201
[ 4] local 192.168.3.204 port 49856 connected to 192.168.3.1 port 5201
[ ID] Interval Transfer Bitrate Retr Cwnd
[ 4] 0.00-1.00 sec 111 MBytes 933 Mbits/sec 915 99.0 KBytes
[ 4] 1.00-2.00 sec 111 MBytes 928 Mbits/sec 909 109 KBytes
[ 4] 2.00-3.00 sec 110 MBytes 925 Mbits/sec 1097 99.0 KBytes
[ 4] 3.00-4.00 sec 111 MBytes 928 Mbits/sec 814 58.0 KBytes
[ 4] 4.00-5.00 sec 111 MBytes 930 Mbits/sec 1187 109 KBytes
[ 4] 5.00-6.00 sec 110 MBytes 923 Mbits/sec 893 72.1 KBytes
[ 4] 6.00-7.00 sec 111 MBytes 929 Mbits/sec 843 67.9 KBytes
[ 4] 7.00-8.00 sec 111 MBytes 928 Mbits/sec 920 79.2 KBytes
[ 4] 8.00-9.00 sec 111 MBytes 929 Mbits/sec 1109 66.5 KBytes
[ 4] 9.00-10.00 sec 111 MBytes 930 Mbits/sec 1055 63.6 KBytes
- - - - - - - - - - - - - - - - - - - - - - - - -
[ ID] Interval Transfer Bitrate Retr
[ 4] 0.00-10.00 sec 1.09 GBytes 933 Mbits/sec 9742
sender
[ 4] 0.00-10.01 sec 1.09 GBytes 933 Mbits/sec
receiver
Changes in v3:
- correct commend in the second patch about what is being forced
on the CPU port, it's not just flow control, it's also speed
Changes in v2:
- make it apply cleanly to net/main
Florian Fainelli (2):
net: ethernet: bgmac: preserve forced 2.5 Gbps link speed
net: dsa: b53: restore the NSP IMP port 2 Gbps mode
drivers/net/dsa/b53/b53_common.c | 12 +++++++++---
drivers/net/ethernet/broadcom/bgmac.c | 8 ++++++--
2 files changed, 15 insertions(+), 5 deletions(-)
--
2.53.0
next reply other threads:[~2026-10-26 21:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-26 20:37 Florian Fainelli [this message]
2026-10-26 20:37 ` [PATCH net v3 1/2] net: ethernet: bgmac: preserve forced 2.5 Gbps link speed Florian Fainelli
2026-10-26 20:37 ` [PATCH net v3 2/2] net: dsa: b53: restore the NSP IMP port 2 Gbps mode Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261026203742.3198673-1-florian.fainelli@broadcom.com \
--to=florian.fainelli@broadcom.com \
--cc=andrew@lunn.ch \
--cc=arnd@arndb.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=jon.mason@broadcom.com \
--cc=jonas.gorski@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=rafal@milecki.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®