mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Linus Walleij <linusw@kernel.org>
Cc: Dan Scally <dan.scally@ideasonboard.com>,
	Li Youhong <dayou5941@163.com>,
	Jacopo Mondi <jacopo.mondi@ideasonboard.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Hans Verkuil <hverkuil+cisco@kernel.org>,
	Nayden Kanchev <nayden.kanchev@arm.com>,
	linux-media@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: media: mali-c55: Allow wakeup source
Date: Mon, 26 Oct 2026 16:59:39 -0500	[thread overview]
Message-ID: <20261026215939.GA3881111-robh@kernel.org> (raw)
In-Reply-To: <CAD++jLnP1+aV99QkVRUX=7L67z10WuUSfqvxDZ8d44FJcVZ-Qw@mail.gmail.com>

On Thu, Oct 08, 2026 at 03:22:18PM +0200, Linus Walleij wrote:
> On Wed, Oct 7, 2026 at 11:29 AM Dan Scally <dan.scally@ideasonboard.com> wrote:
> 
> > On 29/09/2026 13:02, Linus Walleij wrote:
> > > The Mali-C55 interrupt can be wired as a wake source on platforms that
> > > support it. Use the standard wakeup-source property.
> >
> > That's interesting! How's that work, though? In the RZ/V2H particularly the ISP is in an offline
> > mode, so I'm struggling to see how one could trigger the interrupt whilst the device is suspended,
> > since you'd need to instruct the IVC to queue a frame.
> 
> The implementation is IP-neutral and doesn't really ask this question.
> 
> The typical silicon solution would be if the IP was synthesized into
> and always-on power domain on the chip. This means the CPU
> which runs Linux is powered off, while the ISP is still powered
> on, and could generate a wakeup IRQ. This is how e.g. GPIO
> units that can wake up the system work: they are always
> powered in some sense.

In that sense, anything that uses 'interrupts' should accept 
'wakeup-source'. And we could implicitly allow that if that's the rule 
rather than the exception.

> 
> I don't know if that makes any *sense* from a system engineering
> point of view, but it is something that can be done.

But I don't see how it makes sense for an ISP. 'wakeup-source' is for 
system level suspend. When we're powering off idle cores and need a 
wakeup from an interrupt, that's a different, implicit mechanism. For 
example, we don't put wakeup-source on (tick) timers.

Rob

  reply	other threads:[~2026-10-26 21:59 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-29 12:02 [PATCH 0/3] media: mali-c55: Fix IRQ lifetime and wake handling Linus Walleij
2026-09-29 12:02 ` [PATCH 1/3] dt-bindings: media: mali-c55: Allow wakeup source Linus Walleij
2026-10-07  9:28   ` Dan Scally
2026-10-08 13:22     ` Linus Walleij
2026-10-26 21:59       ` Rob Herring [this message]
2026-09-29 12:02 ` [PATCH 2/3] media: mali-c55: Keep IRQ requested during suspend Linus Walleij
2026-10-07 10:12   ` Dan Scally
2026-09-29 12:02 ` [PATCH 3/3] media: mali-c55: Keep ISP powered while IRQ wake is armed Linus Walleij
2026-10-06 11:43 ` [PATCH 0/3] media: mali-c55: Fix IRQ lifetime and wake handling Lad, Prabhakar
2026-10-08  9:26   ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261026215939.GA3881111-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=dan.scally@ideasonboard.com \
    --cc=dayou5941@163.com \
    --cc=devicetree@vger.kernel.org \
    --cc=hverkuil+cisco@kernel.org \
    --cc=jacopo.mondi@ideasonboard.com \
    --cc=krzk+dt@kernel.org \
    --cc=linusw@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=nayden.kanchev@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®