mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Bhargav Joshi <j.bhargav.u@gmail.com>
Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Santosh Shilimkar <santosh.shilimkar@ti.com>,
	Sricharan R <r.sricharan@ti.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	goledhruva@gmail.com, m-chawdhry@ti.com, daniel.baluta@gmail.com,
	simona.toaca@nxp.com
Subject: Re: [PATCH] dt-bindings: arm: omap-l3-noc: Convert to DT schema
Date: Mon, 26 Oct 2026 17:22:31 -0500	[thread overview]
Message-ID: <20261026222231.GA4050519-robh@kernel.org> (raw)
In-Reply-To: <20261003-ti-l3-noc-v1-1-9bd18cac33e9@gmail.com>

On Sat, Oct 03, 2026 at 12:28:32AM +0530, Bhargav Joshi wrote:
> Convert TI L3 NoC binding from text to DT schema format. Older OMAP3
> uses the SMX variant which also acts as a bus parent with simple-bus
> compatible so child nodes are allowed using patternproperties. Mark
> ti,hwmods deprecated as it is no longer needed and only used by older
> omap3-l3-smx.
> 
> Signed-off-by: Bhargav Joshi <j.bhargav.u@gmail.com>
> ---
>  .../devicetree/bindings/arm/omap/l3-noc.txt        |  23 ----
>  .../bindings/arm/omap/ti,omap-l3-noc.yaml          | 149 +++++++++++++++++++++

This should move to bindings/soc/ti/ or bindings/bus/ perhaps.

>  2 files changed, 149 insertions(+), 23 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/arm/omap/l3-noc.txt b/Documentation/devicetree/bindings/arm/omap/l3-noc.txt
> deleted file mode 100644
> index 161448da959d2..0000000000000
> --- a/Documentation/devicetree/bindings/arm/omap/l3-noc.txt
> +++ /dev/null
> @@ -1,23 +0,0 @@
> -* TI - L3 Network On Chip (NoC)
> -
> -This version is an implementation of the generic NoC IP
> -provided by Arteris.
> -
> -Required properties:
> -- compatible : Should be "ti,omap3-l3-smx" for OMAP3 family
> -               Should be "ti,omap4-l3-noc" for OMAP4 family
> -               Should be "ti,omap5-l3-noc" for OMAP5 family
> -	       Should be "ti,dra7-l3-noc" for DRA7 family
> -               Should be "ti,am4372-l3-noc" for AM43 family
> -- reg:	Contains L3 register address range for each noc domain.
> -- ti,hwmods: "l3_main_1", ... One hwmod for each noc domain.
> -
> -Examples:
> -
> -ocp {
> -	compatible = "ti,omap4-l3-noc", "simple-bus";
> -	#address-cells = <1>;
> -	#size-cells = <1>;
> -	ranges;
> -	ti,hwmods = "l3_main_1", "l3_main_2", "l3_main_3";
> -};
> diff --git a/Documentation/devicetree/bindings/arm/omap/ti,omap-l3-noc.yaml b/Documentation/devicetree/bindings/arm/omap/ti,omap-l3-noc.yaml
> new file mode 100644
> index 0000000000000..a72a0f4e64332
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/arm/omap/ti,omap-l3-noc.yaml
> @@ -0,0 +1,149 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/arm/omap/ti,omap-l3-noc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: TI OMAP L3 Network On Chip (NoC) Interconnect
> +
> +maintainers:
> +  - Santosh Shilimkar <santosh.shilimkar@ti.com>
> +  - Sricharan R <r.sricharan@ti.com>
> +
> +description:
> +  The L3 interconnect is an implementation of the generic NoC IP provided by
> +  Arteris. OMAP3 uses the SMX variant while OMAP4/5, DRA7, and AM4372 use the
> +  NoC variant.
> +
> +properties:
> +  compatible:
> +    oneOf:
> +      - items:
> +          - const: ti,omap3-l3-smx
> +          - const: simple-bus
> +      - enum:
> +          - ti,omap4-l3-noc
> +          - ti,omap5-l3-noc
> +          - ti,dra7-l3-noc
> +          - ti,am4372-l3-noc
> +
> +  reg:
> +    minItems: 1
> +    maxItems: 3

Need to define what each region is.

> +
> +  interrupts:
> +    minItems: 2
> +    maxItems: 2

Need to define what each interrupt is.

> +
> +  ti,hwmods:
> +    description: hwmod names for each NoC domain.
> +    $ref: /schemas/types.yaml#/definitions/string-array
> +    deprecated: true
> +
> +  "#address-cells":
> +    const: 1
> +
> +  "#size-cells":
> +    const: 1
> +
> +  ranges: true
> +
> +patternProperties:
> +  "^(.*@[0-9a-fA-F]+|regulator-abb-mpu)$":

I suspect that regulator-abb-mpu should be moved out of this node.

A-F is generally not used for unit-addresses. Do we need it?

Rob

      reply	other threads:[~2026-10-26 22:22 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-02 18:58 Bhargav Joshi
2026-10-26 22:22 ` Rob Herring [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261026222231.GA4050519-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=daniel.baluta@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=goledhruva@gmail.com \
    --cc=j.bhargav.u@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m-chawdhry@ti.com \
    --cc=r.sricharan@ti.com \
    --cc=santosh.shilimkar@ti.com \
    --cc=simona.toaca@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®