From: Tristan Madani <tristmd@gmail.com>
To: Johannes Berg <johannes@sipsolutions.net>,
Christian Lamparter <chunkeey@googlemail.com>,
Stanislaw Gruszka <stf_xl@wp.pl>
Cc: Ivo van Doorn <ivdoorn@gmail.com>,
"John W . Linville" <linville@tuxdriver.com>,
Kees Cook <kees@kernel.org>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org, tristan@talencesecurity.com
Subject: [PATCH v2 wireless 0/3] wifi: replace open-coded IE searches with cfg80211_find_ie()
Date: Mon, 26 Oct 2026 22:31:52 +0000 [thread overview]
Message-ID: <20261026223153.2087218-1-tristan@talencesecurity.com> (raw)
Three wireless drivers (carl9170, rt2x00, p54) each hand-roll their own
TIM IE search function. Replace them with cfg80211_find_ie(), which
already provides a correct and well-tested IE search.
Changes in v2:
- Replace the entire open-coded functions with cfg80211_find_ie()
instead of only tightening the loop condition, per Johannes Berg.
- Add pre-subtraction length guards in p54 to prevent unsigned
underflow on truncated beacon frames.
Tristan Madani (3):
wifi: carl9170: replace open-coded IE search with cfg80211_find_ie()
wifi: rt2x00: replace open-coded IE search with cfg80211_find_ie()
wifi: p54: replace open-coded IE search with cfg80211_find_ie()
drivers/net/wireless/ath/carl9170/rx.c | 27 ++++-------------
drivers/net/wireless/intersil/p54/lmac.h | 3 --
drivers/net/wireless/intersil/p54/main.c | 30 +++++--------------
drivers/net/wireless/intersil/p54/txrx.c | 12 ++++++--
.../net/wireless/ralink/rt2x00/rt2x00dev.c | 30 +++++--------------
5 files changed, 29 insertions(+), 73 deletions(-)
--
2.47.3
next reply other threads:[~2026-10-26 22:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-26 22:31 Tristan Madani [this message]
2026-10-27 6:04 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261026223153.2087218-1-tristan@talencesecurity.com \
--to=tristmd@gmail.com \
--cc=chunkeey@googlemail.com \
--cc=ivdoorn@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=stable@vger.kernel.org \
--cc=stf_xl@wp.pl \
--cc=tristan@talencesecurity.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®