mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jim Cromie via B4 Relay <devnull+jim.cromie.gmail.com@kernel.org>
To: "Jason Baron" <jbaron@akamai.com>,
	"Shuah Khan" <shuah@kernel.org>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
	"Maxime Ripard" <mripard@kernel.org>,
	"Thomas Zimmermann" <tzimmermann@suse.de>,
	"David Airlie" <airlied@gmail.com>,
	"Simona Vetter" <simona@ffwll.ch>,
	"Arnd Bergmann" <arnd@arndb.de>,
	"Luis Chamberlain" <mcgrof@kernel.org>,
	"Petr Pavlu" <petr.pavlu@suse.com>,
	"Daniel Gomez" <da.gomez@kernel.org>,
	"Sami Tolvanen" <samitolvanen@google.com>,
	"Aaron Tomlin" <atomlin@atomlin.com>,
	"Jonathan Corbet" <corbet@net.net>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Nathan Chancellor" <nathan@kernel.org>,
	"Nicolas Schier" <nsc@kernel.org>,
	"Shuah Khan" <skhan@linuxfoundation.org>,
	"Randy Dunlap" <rdunlap@infradead.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	"Pavel Machek" <pavel@kernel.org>, "Len Brown" <lenb@kernel.org>,
	"Jonathan Corbet" <corbet@lwn.net>,
	"Petr Mladek" <pmladek@suse.com>,
	"Steven Rostedt" <rostedt@goodmis.org>,
	"John Ogness" <john.ogness@linutronix.de>,
	"Sergey Senozhatsky" <senozhatsky@chromium.org>,
	"Thomas Weißschuh" <linux@weissschuh.net>,
	"Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
	 dri-devel@lists.freedesktop.org, linux-arch@vger.kernel.org,
	 linux-modules@vger.kernel.org, linux-doc@vger.kernel.org,
	 linux-kbuild@vger.kernel.org, linux-pm@vger.kernel.org,
	 Jason Baron <jbaron@redhat.com>,
	Jim Cromie <jim.cromie@gmail.com>,
	 Louis Chauvet <louis.chauvet@bootlin.com>
Subject: [PATCH v13 11/39] dyndbg: drop NUM_TYPE_ARGS
Date: Tue, 27 Oct 2026 14:22:11 -0600	[thread overview]
Message-ID: <20261027-dd-cmap-part2-clean-v13-11-9267923be612@gmail.com> (raw)
In-Reply-To: <20261027-dd-cmap-part2-clean-v13-0-9267923be612@gmail.com>

From: Jim Cromie <jim.cromie@gmail.com>

ARRAY_SIZE almost works here, since array decl is complete.
But define it locally, named __DDEBUG_ARRAY_SIZE, to avoid
include conflicts with  boot/<something> on some arch.

no functional change

Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
Reviewed-by: Louis Chauvet <louis.chauvet@bootlin.com>
---
v7: actually use macro
v5: drop include, it causes redefined probs in /boot/* for some arch.
v2: include linux/array_size.h, correct commit subject, review after sob
---
 include/linux/dynamic_debug.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/include/linux/dynamic_debug.h b/include/linux/dynamic_debug.h
index 9607121c3072..baf5c0853f45 100644
--- a/include/linux/dynamic_debug.h
+++ b/include/linux/dynamic_debug.h
@@ -8,6 +8,8 @@
 
 #include <linux/build_bug.h>
 
+#define __DDEBUG_ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0]))
+
 /*
  * An instance of this structure is created in a special
  * ELF section at every dynamic debug callsite.  At runtime,
@@ -122,11 +124,9 @@ struct ddebug_class_param {
 		.mod_name = KBUILD_MODNAME,				\
 		.base = _base,						\
 		.map_type = _maptype,					\
-		.length = NUM_TYPE_ARGS(char*, __VA_ARGS__),		\
 		.class_names = _var##_classnames,			\
+		.length = __DDEBUG_ARRAY_SIZE(_var##_classnames),	\
 	}
-#define NUM_TYPE_ARGS(eltype, ...)				\
-	(sizeof((eltype[]) {__VA_ARGS__}) / sizeof(eltype))
 
 extern __printf(2, 3)
 void __dynamic_pr_debug(struct _ddebug *descriptor, const char *fmt, ...);

-- 
2.56.0



  parent reply	other threads:[~2026-10-27 20:22 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-27 20:22 [PATCH v13 00/39] dyndbg: Fix classmaps API for subsystems, query extensions, selftests Jim Cromie via B4 Relay
2026-10-27 20:22 ` [PATCH v13 01/39] selftests/dyndbg: Add kselftest script to verify dynamic-debug Jim Cromie via B4 Relay
2026-10-27 20:22 ` [PATCH v13 02/39] vmlinux.lds.h: refactor BOUNDED_SECTION_* macros into bounded_sections.lds.h Jim Cromie via B4 Relay
2026-10-27 20:22 ` [PATCH v13 03/39] vmlinux.lds.h: drop unused HEADERED_SECTION* macros Jim Cromie via B4 Relay
2026-10-27 20:22 ` [PATCH v13 04/39] vmlinux.lds.h: Fix ALIGN(8) omission causing NULL ptr on i386 Jim Cromie via B4 Relay
2026-10-27 20:22 ` [PATCH v13 05/39] vmlinux.lds.h: remove redundant ALIGN(8) directives Jim Cromie via B4 Relay
2026-10-27 20:22 ` [PATCH v13 06/39] dyndbg.lds.S: fix lost dyndbg sections in modules Jim Cromie via B4 Relay
2026-10-27 20:22 ` [PATCH v13 07/39] dyndbg: factor ddebug_match_desc out from ddebug_change Jim Cromie via B4 Relay
2026-10-27 20:22 ` [PATCH v13 08/39] dyndbg: add stub macro for DECLARE_DYNDBG_CLASSMAP Jim Cromie via B4 Relay
2026-10-27 20:22 ` [PATCH v13 09/39] dyndbg: reword "class unknown," to "class:_UNKNOWN_" Jim Cromie via B4 Relay
2026-10-27 20:22 ` [PATCH v13 10/39] dyndbg-API: remove DD_CLASS_TYPE_(DISJOINT|LEVEL)_NAMES and code Jim Cromie via B4 Relay
2026-10-27 20:22 ` Jim Cromie via B4 Relay [this message]
2026-10-27 20:22 ` [PATCH v13 12/39] dyndbg: bump num-tokens in a query-cmd from 9 to 15 Jim Cromie via B4 Relay
2026-10-27 20:22 ` [PATCH v13 13/39] dyndbg: reduce verbose/debug clutter Jim Cromie via B4 Relay
2026-10-27 20:22 ` [PATCH v13 14/39] dyndbg: refactor param_set_dyndbg_classes and below Jim Cromie via B4 Relay
2026-10-27 20:22 ` [PATCH v13 15/39] dyndbg: tighten fn-sig of ddebug_apply_class_bitmap Jim Cromie via B4 Relay
2026-10-27 20:22 ` [PATCH v13 16/39] dyndbg: replace classmap list with an array-slice Jim Cromie via B4 Relay
2026-10-27 20:22 ` [PATCH v13 17/39] dyndbg: macrofy a 2-index for-loop pattern Jim Cromie via B4 Relay
2026-10-27 20:22 ` [PATCH v13 18/39] dyndbg: reduce class param storage to u32 Jim Cromie via B4 Relay
2026-10-27 20:22 ` [PATCH v13 19/39] dyndbg,module: make proper substructs in _ddebug_info Jim Cromie via B4 Relay
2026-10-27 20:22 ` [PATCH v13 20/39] dyndbg: move mod_name down from struct ddebug_table to _ddebug_info Jim Cromie via B4 Relay
2026-10-27 20:22 ` [PATCH v13 21/39] dyndbg: hoist classmap-filter-by-modname up to ddebug_add_module Jim Cromie via B4 Relay
2026-10-27 20:22 ` [PATCH v13 22/39] dyndbg-API: replace DECLARE_DYNDBG_CLASSMAP Jim Cromie via B4 Relay
2026-10-27 20:22 ` [PATCH v13 23/39] selftests/dyndbg: add FT_classmap_inheritance Jim Cromie via B4 Relay
2026-10-27 20:22 ` [PATCH v13 24/39] dyndbg: detect class_id reservation conflicts Jim Cromie via B4 Relay
2026-10-27 20:22 ` [PATCH v13 25/39] dyndbg: check DYNAMIC_DEBUG_CLASSMAP_{DEFINE,USE_} args at compile-time Jim Cromie via B4 Relay
2026-10-27 20:22 ` [PATCH v13 26/39] dyndbg-test: add do_bulk testpoint, rename do_prints to do_classes Jim Cromie via B4 Relay
2026-10-27 20:22 ` [PATCH v13 27/39] dyndbg-API: promote DYNAMIC_DEBUG_CLASSMAP_PARAM to API Jim Cromie via B4 Relay
2026-10-27 20:22 ` [PATCH v13 28/39] dyndbg: control-parser: treat comma as a token separator Jim Cromie via B4 Relay
2026-10-27 20:22 ` [PATCH v13 29/39] selftests: enable comma-terminator tests Jim Cromie via B4 Relay
2026-10-27 20:22 ` [PATCH v13 30/39] dyndbg: split multi-query strings with @ Jim Cromie via B4 Relay
2026-10-27 20:22 ` [PATCH v13 31/39] dyndbg: resolve "protection" of class'd pr_debug Jim Cromie via B4 Relay
2026-10-27 20:22 ` [PATCH v13 32/39] docs/dyndbg: add classmap info to howto Jim Cromie via B4 Relay
2026-10-27 20:22 ` [PATCH v13 33/39] dyndbg: add epilogue to dynamic_debug/control file Jim Cromie via B4 Relay
2026-10-27 20:22 ` [PATCH v13 34/39] dyndbg: fix attempt to modify an RO string Jim Cromie via B4 Relay
2026-10-27 20:22 ` [PATCH v13 35/39] dyndbg: add +c flag to count pr_debug calls without printing Jim Cromie via B4 Relay
2026-10-27 20:22 ` [PATCH v13 36/39] dyndbg: add DEBUG-biased fallback stubs for _dynamic_func_call_cls Jim Cromie via B4 Relay
2026-10-27 20:22 ` [PATCH v13 37/39] selftests/dyndbg: Add FT_count_calls to test +c flag Jim Cromie via B4 Relay
2026-10-27 20:22 ` [PATCH v13 38/39] printk.h: fix overzealous pr_fmt in pr_debug_ratelimited Jim Cromie via B4 Relay
2026-10-27 20:22 ` [PATCH v13 39/39] drm: Mark __drm_debug as __read_mostly Jim Cromie via B4 Relay

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261027-dd-cmap-part2-clean-v13-11-9267923be612@gmail.com \
    --to=devnull+jim.cromie.gmail.com@kernel.org \
    --cc=Jason@zx2c4.com \
    --cc=airlied@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=arnd@arndb.de \
    --cc=atomlin@atomlin.com \
    --cc=corbet@lwn.net \
    --cc=corbet@net.net \
    --cc=da.gomez@kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jbaron@akamai.com \
    --cc=jbaron@redhat.com \
    --cc=jim.cromie@gmail.com \
    --cc=john.ogness@linutronix.de \
    --cc=lenb@kernel.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-modules@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux@weissschuh.net \
    --cc=louis.chauvet@bootlin.com \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mcgrof@kernel.org \
    --cc=mripard@kernel.org \
    --cc=nathan@kernel.org \
    --cc=nsc@kernel.org \
    --cc=pavel@kernel.org \
    --cc=petr.pavlu@suse.com \
    --cc=pmladek@suse.com \
    --cc=rafael@kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=samitolvanen@google.com \
    --cc=senozhatsky@chromium.org \
    --cc=shuah@kernel.org \
    --cc=simona@ffwll.ch \
    --cc=skhan@linuxfoundation.org \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®