From: "David Hildenbrand (Arm)" <david@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>,
Gregory Price <gourry@gourry.net>, Zi Yan <ziy@nvidia.com>,
Joshua Hahn <joshua.hahnjy@gmail.com>,
Rakie Kim <rakie.kim@sk.com>,
Ying Huang <ying.huang@linux.alibaba.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Vladimir Davydov <vdavydov.dev@gmail.com>,
Michal Hocko <mhocko@suse.com>, Hugh Dickins <hughd@google.com>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
Lukas Czerner <lczerner@redhat.com>,
Carlos Maiolino <cmaiolino@redhat.com>,
Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>,
Daniel Verkamp <dverkamp@chromium.org>,
Jeff Xu <jeffxu@google.com>, Muchun Song <muchun.song@linux.dev>,
Oscar Salvador <osalvador@suse.de>,
David Stevens <stevensd@chromium.org>,
"Matthew Wilcox (Oracle)" <willy@infradead.org>,
William Kucharski <william.kucharski@oracle.com>,
Chris Li <chrisl@kernel.org>, Kairui Song <kasong@tencent.com>,
Nhat Pham <nphamcs@gmail.com>, Miaohe Lin <linmiaohe@huawei.com>,
Naoya Horiguchi <nao.horiguchi@gmail.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
"David Hildenbrand (Arm)" <david@kernel.org>,
Eva Kurchatova <eva.kurchatova@virtuozzo.com>,
stable@vger.kernel.org, Pedro Falcato <pfalcato@suse.de>,
"Kiryl Shutsemau (Meta)" <kas@kernel.org>
Subject: [PATCH v2 05/14] hugetlbfs: enforce F_SEAL_EXEC in setattr
Date: Tue, 27 Oct 2026 14:03:10 +0100 [thread overview]
Message-ID: <20261027-fixes_shmem-v2-5-86a00952acb9@kernel.org> (raw)
In-Reply-To: <20261027-fixes_shmem-v2-0-86a00952acb9@kernel.org>
From: Eva Kurchatova <eva.kurchatova@virtuozzo.com>
F_SEAL_EXEC is enforced by shmem_setattr(), but hugetlbfs_setattr() does
not check it. As a result, fchmod() can change the execute bits of a
sealed hugetlbfs memfd.
Use memfd_check_seals_mode() in hugetlbfs_setattr() to reject changes
to execute bits when F_SEAL_EXEC is set.
This also fixes the memfd_test hugetlbfs SEAL-EXEC subtest, where
fchmod() incorrectly succeeded after applying F_SEAL_EXEC.
Fixes: 6fd7353829ca ("mm/memfd: add F_SEAL_EXEC")
Cc: stable@vger.kernel.org
Signed-off-by: Eva Kurchatova <eva.kurchatova@virtuozzo.com>
Link: https://patch.msgid.link/20260629180247.2343229-1-eva.kurchatova@virtuozzo.com
Acked-by: Pedro Falcato <pfalcato@suse.de>
Acked-by: Kiryl Shutsemau (Meta) <kas@kernel.org>
Acked-by: Zi Yan <ziy@nvidia.com>
Tested-by: Gregory Price (Meta) <gourry@gourry.net>
[ david: use common helper; fixup Fixes:; check only regular files ]
Signed-off-by: David Hildenbrand (Arm) <david@kernel.org>
---
fs/hugetlbfs/inode.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c
index ab1e4dec3f77b..1fa05b4d26531 100644
--- a/fs/hugetlbfs/inode.c
+++ b/fs/hugetlbfs/inode.c
@@ -28,6 +28,7 @@
#include <linux/folio_batch.h>
#include <linux/fs_parser.h>
#include <linux/mman.h>
+#include <linux/memfd.h>
#include <linux/slab.h>
#include <linux/dnotify.h>
#include <linux/statfs.h>
@@ -840,6 +841,13 @@ static int hugetlbfs_setattr(struct mnt_idmap *idmap,
if (error)
return error;
+ if (S_ISREG(inode->i_mode) && (ia_valid & ATTR_MODE)) {
+ error = memfd_check_seals_mode(info->seals, inode->i_mode,
+ attr->ia_mode);
+ if (error)
+ return error;
+ }
+
trace_hugetlbfs_setattr(inode, dentry, attr);
if (ia_valid & ATTR_SIZE) {
--
2.43.0
next prev parent reply other threads:[~2026-10-27 13:04 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-27 13:03 [PATCH v2 00/14] mm/shmem: various (urgent?) fixes David Hildenbrand (Arm)
2026-10-27 13:03 ` [PATCH v2 01/14] mm/mempolicy: charge shared policy nodes David Hildenbrand (Arm)
2026-10-27 13:03 ` [PATCH v2 02/14] tmpfs: keep the quota soft limits of an unused id David Hildenbrand (Arm)
2026-10-27 13:03 ` [PATCH v2 03/14] tmpfs: preserve explicitly disabled quota limits David Hildenbrand (Arm)
2026-10-27 13:03 ` [PATCH v2 04/14] mm/shmem: honour F_SEAL_EXEC when an ACL is set David Hildenbrand (Arm)
2026-10-27 17:34 ` Pratyush Yadav
2026-10-27 13:03 ` David Hildenbrand (Arm) [this message]
2026-10-27 13:16 ` [PATCH v2 05/14] hugetlbfs: enforce F_SEAL_EXEC in setattr Muchun Song
2026-10-27 13:03 ` [PATCH v2 06/14] mm/shmem: stop retrying folios that cannot be split David Hildenbrand (Arm)
2026-10-27 21:06 ` Zi Yan
2026-10-27 13:03 ` [PATCH v2 07/14] mm/shmem: preserve data in clean folios when splitting fails David Hildenbrand (Arm)
2026-10-27 13:03 ` [PATCH v2 08/14] mm/shmem: discard whole new large folios on fallocate rollback David Hildenbrand (Arm)
2026-10-27 13:03 ` [PATCH v2 09/14] mm/shmem: rescan after nonuniform folio splitting David Hildenbrand (Arm)
2026-10-27 21:07 ` Zi Yan
2026-10-27 13:03 ` [PATCH v2 10/14] mm/shmem: fix truncate hang in large swap entry David Hildenbrand (Arm)
2026-10-27 13:03 ` [PATCH v2 11/14] mm/shmem: preserve allocation errors when swapping in large entries David Hildenbrand (Arm)
2026-10-27 13:03 ` [PATCH v2 12/14] mm/shmem: fix truncate loop after boundary swapin failure David Hildenbrand (Arm)
2026-10-28 1:30 ` Baolin Wang
2026-10-27 13:03 ` [PATCH v2 13/14] mm/shmem: fix accounting of swapin-error markers David Hildenbrand (Arm)
2026-10-28 2:07 ` Baolin Wang
2026-10-27 13:03 ` [PATCH v2 14/14] mm/shmem: fix truncation of files containing only " David Hildenbrand (Arm)
2026-10-28 2:19 ` Baolin Wang
2026-10-27 13:20 ` [PATCH v2 00/14] mm/shmem: various (urgent?) fixes Baolin Wang
2026-10-27 13:27 ` David Hildenbrand (Arm)
2026-10-27 13:30 ` David Hildenbrand (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261027-fixes_shmem-v2-5-86a00952acb9@kernel.org \
--to=david@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=brauner@kernel.org \
--cc=chrisl@kernel.org \
--cc=cmaiolino@redhat.com \
--cc=dverkamp@chromium.org \
--cc=eva.kurchatova@virtuozzo.com \
--cc=gourry@gourry.net \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=jack@suse.cz \
--cc=jeffxu@google.com \
--cc=joshua.hahnjy@gmail.com \
--cc=kas@kernel.org \
--cc=kasong@tencent.com \
--cc=lczerner@redhat.com \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=muchun.song@linux.dev \
--cc=nao.horiguchi@gmail.com \
--cc=nphamcs@gmail.com \
--cc=osalvador@suse.de \
--cc=pfalcato@suse.de \
--cc=rakie.kim@sk.com \
--cc=stable@vger.kernel.org \
--cc=stevensd@chromium.org \
--cc=vdavydov.dev@gmail.com \
--cc=william.kucharski@oracle.com \
--cc=willy@infradead.org \
--cc=ying.huang@linux.alibaba.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®