Re: [PATCH v7 08/11] dt-bindings: input: Document hid-over-spi DT schema

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 3891 bytes --]

On Sat, Oct 24, 2026 at 12:51:42AM +0000, Jingyuan Liang wrote:
> From: Dmitry Antipov <dmanti@microsoft.com>
> 
> Documentation describes the required and optional properties for
> implementing Device Tree for a Microsoft G6 Touch Digitizer that
> supports HID over SPI Protocol 1.0 specification.
> 
> Signed-off-by: Dmitry Antipov <dmanti@microsoft.com>
> Signed-off-by: Jarrett Schultz <jaschultz@microsoft.com>
> Signed-off-by: Jingyuan Liang <jingyliang@chromium.org>

Personally I prefer how this is done now, but definitely worth those who
approved the previous iteration taking a look at this because it has
changed significantly and no longer contains any of the properties that
cover the timings etc anymore.

Worth noting that this changed since the previous version after I
pointed out that the second hid-over-spi device did not make use of them
at all and needed specific handling in the driver.

> ---
>  .../devicetree/bindings/input/hid-over-spi.yaml    | 75 ++++++++++++++++++++++
>  1 file changed, 75 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/input/hid-over-spi.yaml b/Documentation/devicetree/bindings/input/hid-over-spi.yaml

Typically this would need to match a compatible, but I think this is okay
provided other hid-over-spi devices actually get added here - the series
adding the second hid-over-spi device didn't do so but should be able to
I think?

Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

Thanks,
Conor.

> new file mode 100644
> index 000000000000..bed0746f004c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/input/hid-over-spi.yaml
> @@ -0,0 +1,75 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/input/hid-over-spi.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: HID over SPI Devices
> +
> +maintainers:
> +  - Benjamin Tissoires <bentiss@kernel.org>
> +  - Jiri Kosina <jikos@kernel.org>
> +  - Jingyuan Liang <jingyliang@chromium.org>
> +
> +description: |+
> +  HID over SPI provides support for various Human Interface Devices over the
> +  SPI bus. These devices can be for example touchpads, keyboards, touch screens
> +  or sensors.
> +
> +  The specification has been written by Microsoft and is currently available
> +  here: https://www.microsoft.com/en-us/download/details.aspx?id=103325
> +
> +allOf:
> +  - $ref: /schemas/input/touchscreen/touchscreen.yaml#
> +  - $ref: /schemas/spi/spi-peripheral-props.yaml#
> +
> +properties:
> +  compatible:
> +    enum:
> +      - microsoft,g6-touch-digitizer
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  reset-gpios:
> +    maxItems: 1
> +    description:
> +      GPIO specifier for the device's reset line. The HID over SPI
> +      specification requires a dedicated, host-driven, active-low reset
> +      line. The line must be flagged with GPIO_ACTIVE_LOW.
> +
> +  vdd-supply:
> +    description:
> +      Regulator for the VDD supply voltage.
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - reset-gpios
> +  - vdd-supply
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +    #include <dt-bindings/gpio/gpio.h>
> +
> +    spi {
> +      #address-cells = <1>;
> +      #size-cells = <0>;
> +
> +      hid@0 {
> +        compatible = "microsoft,g6-touch-digitizer";
> +        reg = <0x0>;
> +        interrupts-extended = <&gpio 42 IRQ_TYPE_EDGE_FALLING>;
> +        reset-gpios = <&gpio 27 GPIO_ACTIVE_LOW>;
> +        vdd-supply = <&pm8350c_l3>;
> +        pinctrl-names = "default";
> +        pinctrl-0 = <&ts_d6_int_bias>;
> +      };
> +    };
> 
> -- 
> 2.56.0.257.gf7497c7d27-goog
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]