Re: [PATCH v3 1/2] dt-bindings: interconnect: qcom: Add SM7250 RPMh NoC

[Krzysztof Kozlowski <krzk@kernel.org>]

On Mon, Oct 26, 2026 at 11:18:17PM +0530, Ishu Brar wrote:
> +properties:
> +  compatible:
> +    enum:
> +      - qcom,sm7250-aggre1-noc
> +      - qcom,sm7250-aggre2-noc
> +      - qcom,sm7250-compute-noc
> +      - qcom,sm7250-config-noc
> +      - qcom,sm7250-dc-noc
> +      - qcom,sm7250-gem-noc
> +      - qcom,sm7250-mc-virt
> +      - qcom,sm7250-mmss-noc
> +      - qcom,sm7250-npu-noc
> +      - qcom,sm7250-qup-virt
> +      - qcom,sm7250-system-noc
> +
> +  reg:
> +    maxItems: 1

So no children? Why? Your previous version said they cannot act
independently and need regmap from the parent. I did not ask to remove
children, but to remove pointless comment. Mind where the reviewer
comments are placed.

Also, where are the clocks?

> +
> +required:
> +  - compatible
> +
> +allOf:
> +  - $ref: qcom,rpmh-common.yaml#
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - qcom,sm7250-compute-noc
> +              - qcom,sm7250-mc-virt
> +              - qcom,sm7250-qup-virt
> +    then:
> +      properties:
> +        reg: false
> +    else:
> +      required:
> +        - reg
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    interconnect-0 {
> +        compatible = "qcom,sm7250-qup-virt";
> +        #interconnect-cells = <2>;
> +        qcom,bcm-voters = <&apps_bcm_voter>;
> +    };
> +
> +    interconnect-1 {
> +        compatible = "qcom,sm7250-mc-virt";
> +        #interconnect-cells = <2>;
> +        qcom,bcm-voters = <&apps_bcm_voter>;
> +    };

Drop node, redundant, because you have exactly same example
(interconnect-0).

> +
> +    interconnect@1620000 {
> +        compatible = "qcom,sm7250-system-noc";
> +        reg = <0x01620000 0x19200>;
> +        #interconnect-cells = <2>;
> +        qcom,bcm-voters = <&apps_bcm_voter>;
> +    };

Best regards,
Krzysztof