mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andreas Gabriel-Platschek <andi.platschek@gmail.com>
To: vkoul@kernel.org
Cc: Frank.Li@kernel.org, dmaengine@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Andreas Gabriel-Platschek <andi.platschek@gmail.com>
Subject: [PATCH] dmaengine: pl08x: mark slave channels as DMA_PRIVATE
Date: Tue, 27 Oct 2026 08:00:37 +0100	[thread overview]
Message-ID: <20261027070037.1809112-1-andi.platschek@gmail.com> (raw)

The pl08x slave engine channels are only ever handed out through
explicit requests: DT clients go via pl08x_of_xlate() and the
platform-data path uses dma_request_channel() with a filter, both of
which end up in dma_get_slave_channel(). They are not meant to be
published in the general-purpose channel table.

Mark the slave device with DMA_PRIVATE at probe time so the dmaengine
core treats it as always-private. Without this, if a dmaengine client
is already active when the device is registered,
dma_async_device_register() takes a reference on every channel, and
the subsequent dma_get_slave_channel() from pl08x_of_xlate() fails
because the channel is no longer free (client_count != 0), leaving DT
slave clients unable to acquire channels.

The memcpy engine stays public as it is intended to be shared through
the per-CPU channel table.

Signed-off-by: Andreas Gabriel-Platschek <andi.platschek@gmail.com>
---
 drivers/dma/amba-pl08x.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/dma/amba-pl08x.c b/drivers/dma/amba-pl08x.c
index 543c2eb8cfa8..06881d3f29a9 100644
--- a/drivers/dma/amba-pl08x.c
+++ b/drivers/dma/amba-pl08x.c
@@ -2775,6 +2775,7 @@ static int pl08x_probe(struct amba_device *adev, const struct amba_id *id)
 		pl08x->has_slave = true;
 		dma_cap_set(DMA_SLAVE, pl08x->slave.cap_mask);
 		dma_cap_set(DMA_CYCLIC, pl08x->slave.cap_mask);
+		dma_cap_set(DMA_PRIVATE, pl08x->slave.cap_mask);
 		pl08x->slave.dev = &adev->dev;
 		pl08x->slave.device_free_chan_resources =
 			pl08x_free_chan_resources;
-- 
2.47.3


             reply	other threads:[~2026-10-27  7:00 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-27  7:00 Andreas Gabriel-Platschek [this message]
2026-10-27 14:39 ` Frank Li
2026-10-27 18:28   ` Andreas Gabriel-Platschek
     [not found]   ` <CAGdJsvY6BfOG4gS7qDfgqNERWPGQ9_Y33CmFO3NFcsGGqD8viA@mail.gmail.com>
2026-10-27 20:07     ` Frank Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261027070037.1809112-1-andi.platschek@gmail.com \
    --to=andi.platschek@gmail.com \
    --cc=Frank.Li@kernel.org \
    --cc=dmaengine@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®