From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=124.126.103.232 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793086135; b=4+yEzR3/nx0kPGp7cCOpUKNO0vxbdcUFx8WXq4oBMSSajeggqC4K0dvj0/0OgUWJl5o3 9zaRph09clWs4usGK883avWy73tR0tRQ0wrqTTHxiqVH7GCUYWbECXwj+czB4jOIi5Yno 2pmG6zO+cEDPswOrSSjUJkThKAx8ZtRMzVyvNuoV9QlW4zMyLFgsAIevAy8TePzxU3vbh 3U9Pk32K7MJv4C00pDbbGiDIyKRHG9WeDt+U8K8Ko6lOwVY2N4kofYeXEb7Z9cPFU3tjW ax6T/4PWgN4oR7wSPKXr9yIjcSmpqP2xizhOZSqKsdu6O+UF3CSNGzQ80UASZaExypg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793086135; h=DMARC-Filter:X-UUID:X-CID-P-RULE:X-CID-O-INFO:X-CID-META:X-CID-BVR: X-CID-BAS:X-CID-FACTOR:X-CID-RHF:X-UUID:X-User:Received:From:To:Cc: Subject:Date:Message-Id:X-Mailer:MIME-Version: Content-Transfer-Encoding; bh=NOLME5xKcndUKb5onVS7BWOsbt8WAO9ChA/WQiidILk=; b=Q2qGbtpWl5lv1g1mAh3Lzo9egMjWp6m8y4+OFVQIPlvDhiXABTWVUy7G0lL9ftoan4YF L4olvIwvbIUJpad30IBg4x+/2TsfyPTw3lSuXWOgCpehz654+j6/E9KzrM7181KfV1o4c xER4OK2KXqxTj3qCoPlpmjRWcaT8hakF8mEypL5A8f1C24se64FII791jYOWB/19LNDkW ZF1xijgACthm+Jpq/obhxaS004N1nnquKS1+ikaBGy827mpq3vtPM3p3Rf2DohCXoI4VS YtIhL/YqPiHycXoca6jn7aaA3lpnv1+v4VXmcojY1ShnI8mGElZhdUir/HPx7Os5RRQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none header.from=kylinos.cn; spf=pass smtp.mailfrom=kylinos.cn; arc=none smtp.remote-ip=124.126.103.232 Received: from mailgw.kylinos.cn (mailgw.kylinos.cn [124.126.103.232]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 94FC6606A31A for ; Tue, 27 Oct 2026 07:28:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 94FC6606A31A Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kylinos.cn X-UUID: 07145588d1d811f19a56ed5b684f684d-20261027 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.3.19,REQID:ce452872-38f0-4fad-881b-9a5c9b5fef8a,IP:0,U RL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION: release,TS:0 X-CID-META: VersionHash:7db8b62,CLOUDID:c066c0c5d9c46fd0921ee33665050b4c,BulkI D:nil,BulkQuantity:0,SF:102|123|136|850|865|898,TC:nil,Content:0|15|50|99, EDM:-3|-100,IP:nil,URL:0,File:nil,RT:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI :0,OSA:0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0,ARC:0 X-CID-BVR: 2,SSN|SDN X-CID-BAS: 2,SSN|SDN,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR X-CID-RHF: D41D8CD98F00B204E9800998ECF8427E X-UUID: 07145588d1d811f19a56ed5b684f684d-20261027 X-User: yaolu@kylinos.cn Received: from localhost.localdomain [(10.44.16.150)] by mailgw.kylinos.cn (envelope-from ) (Generic MTA with TLSv1.3 TLS_AES_256_GCM_SHA384 256/256) with ESMTP id 1676477084; Tue, 27 Oct 2026 15:28:38 +0800 From: yaolu@kylinos.cn To: jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com, tursulin@ursulin.net Cc: simona@ffwll.ch, chris@chris-wilson.co.uk, lionel.g.landwerlin@intel.com, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Lu Yao Subject: [PATCH] drm/i915/gem: Reset err for each fence entry Date: Tue, 27 Oct 2026 15:28:32 +0800 Message-Id: <20261027072832.726435-1-yaolu@kylinos.cn> X-Mailer: git-send-email 2.25.1 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Lu Yao If dma_fence_chain_find_seqno() failed once, 'err' will store val in the following loop. May causing returns '-EINVAL' even though that entry never called dma_fence_chain_find_seqno() at all. Fixes: 13149e8bafc4 ("drm/i915: add syncobj timeline support") Signed-off-by: Lu Yao --- drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c index 1b7f5bf13e50..c41e1b9a40bc 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c +++ b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c @@ -2805,7 +2805,6 @@ add_timeline_fence_array(struct i915_execbuffer *eb, u64 __user *user_values; struct eb_fence *f; u64 nfences; - int err = 0; nfences = timeline_fences->fence_count; if (!nfences) @@ -2843,6 +2842,7 @@ add_timeline_fence_array(struct i915_execbuffer *eb, struct drm_syncobj *syncobj; struct dma_fence *fence = NULL; u64 point; + int err = 0; if (__copy_from_user(&user_fence, user_fences++, -- 2.25.1