mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Vornholt <dv@etik.com>
To: Mark Pearson <mpearson-lenovo@squebb.ca>,
	Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	David Vornholt <david@vornholt.online>,
	stable@vger.kernel.org
Subject: Re: [PATCH v2] usb: typec: ucsi: Stop a power level change notification storm
Date: Tue, 27 Oct 2026 09:17:31 +0100	[thread overview]
Message-ID: <20261027081731.122513-1-dv@etik.com> (raw)
In-Reply-To: <e22cf1da-89f7-4c98-a90d-357b18687df7@app.fastmail.com>

Hi Mark,

On Mon, Oct 26, 2026 at 04:01:32PM -0400, Mark Pearson wrote:
> I need to read through the patch properly - but the X1 Carbon is
> quite popular and used by lots of people. Have we been able to rule
> out it being the E273m on another machine?

No, I haven't tried the E273m on another machine.

On this X1, though, I've only seen it with the E273m. The X1 has been
running v2 since the 10th, and up to the 16th its warning fired 14
times, every time with the E273m connected, on either port. The
monitor hasn't been connected since the 16th, and the warning hasn't
fired since, although the X1 has been charging over USB-C on most
days.

Right now the same port has a 20 V PD contract (the source offers up
to 20 V/5 A and PPS) with the notification enabled. The warning
hasn't fired, and GPE 0x6E stays at a few per second.

So it seems to take this EC and the E273m together. From the UCSI
side I can't tell what the EC is reacting to.

> I've created internal ticket LO-4728 so we can see if we can
> reproduce and get input from the FW team on why so many
> notifications would be generated - generated so many seems quite
> wrong.

Thank you. If it would help the FW team, I can capture the ucsi trace
events or an acpidump with the monitor connected.

> I've only skim read the proposed patch, but I'm also hesitant to say
> this is X1 C13 specific.

Agreed. This X1 is the only machine I've tested. If LO-4728 shows
that other platforms have the same problem, their board names could
go into the quirk too.

> As anote, if you do end doing a quirk then that field is bad as
> there are two different variants of the X1 Carbon 13 - ARL and LNL.
> Better to use DMI checks on the BOARD_NAME - there are two per
> platform, and I believe you're on Lunarlake so would be 21NS and
> 21NT.

Thanks. Yes, the board name here is 21NTS4EE00. If we go with the
quirk, v3 will match "21NS" and "21NT" on DMI_BOARD_NAME.

Thanks,
David

      reply	other threads:[~2026-10-27  8:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-10 18:39 David Vornholt
2026-10-26  9:58 ` Heikki Krogerus
2026-10-26 18:09   ` David Vornholt
2026-10-26 20:01     ` Mark Pearson
2026-10-27  8:17       ` David Vornholt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261027081731.122513-1-dv@etik.com \
    --to=dv@etik.com \
    --cc=david@vornholt.online \
    --cc=gregkh@linuxfoundation.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mpearson-lenovo@squebb.ca \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®