From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=203.254.224.25 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793089906; b=dAtySKPjPq78Rdna41qGzTPnN1ygBkM+Ck3dOrPIwtxM/QZSOX9NAL/2JqRKz+ux4Ong cQF/Uadlenj+/ZduRROoy7NbqMj2X1goCKKnKUGdUy94kbC6hlB63uBVrhieCOYruNYar 12rCMMho8vd9+cYtyfoiyskZOmtoaDtI5Aoq7mxWDb0wkdzS32wDRGgzmL5U6BloRiyEB Dwc/thpTw2HRa9Lc506vqbyWLsbkTmqEKbPryiR7rZwxIpWc2PiYX3T3Vsgogxc/7czNk npmspFNj32W480vchvYv7APq0BbQeLg1hRvbHOS0YSpKRfYFoycZzmXlTIsBFYQeMYw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793089906; h=DMARC-Filter:Received:DKIM-Filter:DKIM-Signature:Received:Received: Mime-Version:Subject:Reply-To:Sender:From:To:CC:X-Priority: X-Content-Kind-Code:In-Reply-To:X-CPGS-Detection:X-Drm-Type: X-Msg-Generator:X-Msg-Type:X-Reply-Demand:Message-ID:Date: X-CMS-MailID:Content-Transfer-Encoding:Content-Type:X-Sendblock-Type: CMS-TYPE:X-CPGSPASS:X-CPGSPASS:cpgsPolicy:X-CFilter-Loop: X-CMS-RootMailID:References; bh=P1MNsw8Rzo4tDNmS4iyrSef2YaeHjBn+VyXBlrSW+E8=; b=w/Uk77Uytj2+1lTPRYpgtcTyQl/ZM96X5G9DfbBFzsY9VWYM72sKJElZ5X749UMWrpif PJG113tTiYsr+3TUg+jx8wkmHwt9fp7a+SIx0FGmYFJUiwLfGnUhiRShozFgz3laHoR4g RJQ8HKKO9HF18lxrDZAUAxFPxsNtDwjzrl9QLGJv9wu+n6jQKtIkShME7TczES41ZNpI1 MqcaHx+dcxOP+UsdPPpdio50M9G4erJZeVFys7ji6We1NR1dx4hQZSPvFBr5I+d5KOpsl s/BeWAzLzMG6C4ydxE/p47d56hQUwa6kuwQoVH+UpkduAXRWpQhd2kQO/k3ED6GEwJQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=samsung.com; spf=pass smtp.mailfrom=samsung.com; dkim=pass header.d=samsung.com header.i=@samsung.com header.a=rsa-sha256 header.s=mail20170921 header.b=Zxk8Qhls; arc=none smtp.remote-ip=203.254.224.25 Received: from mailout2.samsung.com (mailout2.samsung.com [203.254.224.25]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 992E5606A31A for ; Tue, 27 Oct 2026 08:31:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 992E5606A31A Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=samsung.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=samsung.com header.i=@samsung.com header.a=rsa-sha256 header.s=mail20170921 header.b=Zxk8Qhls Received: from epcas2p3.samsung.com (unknown [182.195.41.55]) by mailout2.samsung.com (KnoxPortal) with ESMTP id 20261027083136epoutp02224cb1cb1575908e389179be7f3de9d0~iVcKyk7sx0854208542epoutp02R for ; Tue, 27 Oct 2026 08:31:36 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.samsung.com 20261027083136epoutp02224cb1cb1575908e389179be7f3de9d0~iVcKyk7sx0854208542epoutp02R DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1793089896; bh=P1MNsw8Rzo4tDNmS4iyrSef2YaeHjBn+VyXBlrSW+E8=; h=Subject:Reply-To:From:To:CC:In-Reply-To:Date:References:From; b=Zxk8Qhls8BBg+NPsUF50iS7ZHqaxG91eqx3BUrQD9bv9ZourUO+zG+3mTBtkBBqBF uSDL5Tzb5FwIXahv4DleJC6VhHvmEi4y5+ZSLUOO23U87u+d8kTJtxT3M1Kq1GEnHz 6J5ZkcALnOk1539NHIQSiwZGj4cxdZTJfcbGw57U= Received: from epsnrtp03.localdomain (unknown [182.195.42.155]) by epcas2p4.samsung.com (KnoxPortal) with ESMTPS id 20261027083135epcas2p4540c5ad7f4d5bc2c255d423e1283d4e7~iVcKWU0-x1805918059epcas2p4C; Tue, 27 Oct 2026 08:31:35 +0000 (GMT) Received: from epcas2p4.samsung.com (unknown [182.195.38.205]) by epsnrtp03.localdomain (Postfix) with ESMTP id 4jDNxz4gM3z3hhT3; Tue, 27 Oct 2026 08:31:35 +0000 (GMT) X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 Subject: RE:(2) [PATCH v4 2/9] xfs: add a flag to convert unwritten extents without allocating blocks Reply-To: daejun7.park@samsung.com Sender: Daejun Park From: Daejun Park To: "Pankaj Raghav (Samsung)" CC: Carlos Maiolino , "linux-xfs@vger.kernel.org" , Christoph Hellwig , "Darrick J. Wong" , Dave Chinner , Chuck Lever , Jeff Layton , Dai Ngo , Sergey Bashirov , Andrey Albershteyn , "linux-nfs@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" , Daejun Park X-Priority: 3 X-Content-Kind-Code: NORMAL In-Reply-To: X-CPGS-Detection: blocking_info_exchange X-Drm-Type: N,general X-Msg-Generator: Mail X-Msg-Type: PERSONAL X-Reply-Demand: N Message-ID: <20261027083135epcms2p81a1eecd6f9277131d458bd28ebe80ec4@epcms2p8> Date: Tue, 27 Oct 2026 17:31:35 +0900 X-CMS-MailID: 20261027083135epcms2p81a1eecd6f9277131d458bd28ebe80ec4 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" X-Sendblock-Type: AUTO_CONFIDENTIAL CMS-TYPE: 102P X-CPGSPASS: Y X-CPGSPASS: Y cpgsPolicy: CPGSC10-223,Y X-CFilter-Loop: Reflected X-CMS-RootMailID: 20261022124400epcas2p11d97ce2b0b9b4009ba8cabe1068b58e8 References: <20261020-xfs-pnfs-batch-v4-0-9230fa2ca4a4@samsung.com> <20261020-xfs-pnfs-batch-v4-2-9230fa2ca4a4@samsung.com> On Thu, Oct 22, 2026 at 02:43:50PM +0200, Pankaj Raghav wrote: > Minor nit: > > The following might be more explicit here: > > ASSERT((flags & XFS_BMAPI_CONVERT_ONLY) ? bma.nallocs == 0 : > bma.nallocs >= *nmap); Thanks, that is clearer, and it holds: with XFS_BMAPI_CONVERT_ONLY the loop stops before xfs_bmapi_allocate(), the only place that counts an allocation. I'll use it in v5. Daejun