From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=203.254.224.25 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793090106; b=xCMvN+0DzWcaPPZOOM1h25cMvsDzSwrcFyf8dRg0g/06zqVMIAG5ZYAsn8tqWd+OAaI4 CLa6c1RrGbAcOoCDIMIqsM8tx41YQ5GNS3jr3wJCZYnjPrFV1SYu+xzACGplUjGlgZTPB ACw56qCZocZxWchSR0tEGD9tPFS2M3476+DhQRmj/vphBOPRvtpnIOPWbS8dObV6ps2vP kZlLyqKzjp0nE+0vxAAWBNGt6OalBAWz3X7Ca9PMYYwWrtYWeaheQYvfcYQKoBTg3JS1u dMZWoJbwm5ANiQbPPWsiCDFkNDcIQx2D7dP4NPmqOjFwSUjKiJbr/jvG3WHKWjeqYiw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793090106; h=DMARC-Filter:Received:DKIM-Filter:DKIM-Signature:Received:Received: Mime-Version:Subject:Reply-To:Sender:From:To:CC:X-Priority: X-Content-Kind-Code:In-Reply-To:X-CPGS-Detection:X-Drm-Type: X-Msg-Generator:X-Msg-Type:X-Reply-Demand:Message-ID:Date: X-CMS-MailID:Content-Transfer-Encoding:Content-Type:X-Sendblock-Type: CMS-TYPE:X-CPGSPASS:X-CPGSPASS:cpgsPolicy:X-CFilter-Loop: X-CMS-RootMailID:References; bh=5bahGxfUN75E2T3mOHUJ9Zz0leyIiVRMhMYoQV+Rpgs=; b=x0uYXytUFi4bDj43xFr0GT9ouuFLvbqVZzo1FPVExUK2xFy+Q7gQg2tenh1/6YA5MXHE D0Ul06jLCYlJbjbuFQqWLsWHeqDhjLK3SyncdWD5YcHy55SCqWmeUMF5PTz+EKVANcXCp 7rub6X/6yKqTjDUNU23STIDCD6TkH7PhtfdGCSRsmAwbPE0av4I2I0USOKGGppqRmuKfh 7sBgpdqeaj0zGjXRX6ISB4iWZyRlc+01DVnsCejPmp9nPcsSqKSBH1rubG67I22UK9hKX UzNHfpPIyUAep3FZCyU+Q6wf8VWuwxUwahSowNypEPCSFJXkDoqa57AYFNWs9WJgWGA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=samsung.com; spf=pass smtp.mailfrom=samsung.com; dkim=pass header.d=samsung.com header.i=@samsung.com header.a=rsa-sha256 header.s=mail20170921 header.b=L4lEPNd+; arc=none smtp.remote-ip=203.254.224.25 Received: from mailout2.samsung.com (mailout2.samsung.com [203.254.224.25]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 97DC8606A31A for ; Tue, 27 Oct 2026 08:35:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 97DC8606A31A Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=samsung.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=samsung.com header.i=@samsung.com header.a=rsa-sha256 header.s=mail20170921 header.b=L4lEPNd+ Received: from epcas2p1.samsung.com (unknown [182.195.41.53]) by mailout2.samsung.com (KnoxPortal) with ESMTP id 20261027083503epoutp02f228f7f3546ec4fe3304f8dd4d1ac1f3~iVfL8-zQk1440014400epoutp02b for ; Tue, 27 Oct 2026 08:35:03 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.samsung.com 20261027083503epoutp02f228f7f3546ec4fe3304f8dd4d1ac1f3~iVfL8-zQk1440014400epoutp02b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1793090103; bh=5bahGxfUN75E2T3mOHUJ9Zz0leyIiVRMhMYoQV+Rpgs=; h=Subject:Reply-To:From:To:CC:In-Reply-To:Date:References:From; b=L4lEPNd+F7ee8P3N/mHT/N1cn74Bk23jtK73oJvSICLDsyxIDUNmFDbFox9TiE9+x ADQgI+Kd7P6lLh55lo/7d7+/uivKwLd3FhCIpos1hwluRZoNZuiJTwo7wna/3uI5WM RB8L7kn8gWQ3LAMMrLPijurzgNnNQ3qzhXraLJ+s= Received: from epsnrtp04.localdomain (unknown [182.195.42.156]) by epcas2p4.samsung.com (KnoxPortal) with ESMTPS id 20261027083503epcas2p494af9311ba030f4f9573dc589ba17ada~iVfLXfW_z1990719907epcas2p4J; Tue, 27 Oct 2026 08:35:03 +0000 (GMT) Received: from epcas2p4.samsung.com (unknown [182.195.38.208]) by epsnrtp04.localdomain (Postfix) with ESMTP id 4jDP1y6RkCz6B9mR; Tue, 27 Oct 2026 08:35:02 +0000 (GMT) X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 Subject: RE:(2) [PATCH v4 5/9] xfs: limit the count of a pNFS write allocation to one extent Reply-To: daejun7.park@samsung.com Sender: Daejun Park From: Daejun Park To: "Pankaj Raghav (Samsung)" CC: Carlos Maiolino , "linux-xfs@vger.kernel.org" , Christoph Hellwig , "Darrick J. Wong" , Dave Chinner , Chuck Lever , Jeff Layton , Dai Ngo , Sergey Bashirov , Andrey Albershteyn , "linux-nfs@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" , Daejun Park X-Priority: 3 X-Content-Kind-Code: NORMAL In-Reply-To: X-CPGS-Detection: blocking_info_exchange X-Drm-Type: N,general X-Msg-Generator: Mail X-Msg-Type: PERSONAL X-Reply-Demand: N Message-ID: <20261027083502epcms2p736b8c20d8a66bdc43b1f68e5cde0fc24@epcms2p7> Date: Tue, 27 Oct 2026 17:35:02 +0900 X-CMS-MailID: 20261027083502epcms2p736b8c20d8a66bdc43b1f68e5cde0fc24 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" X-Sendblock-Type: AUTO_CONFIDENTIAL CMS-TYPE: 102P X-CPGSPASS: Y X-CPGSPASS: Y cpgsPolicy: CPGSC10-223,Y X-CFilter-Loop: Reflected X-CMS-RootMailID: 20261022130241epcas2p22506b749cfa884fea92c554d34d3df19 References: <20261020-xfs-pnfs-batch-v4-0-9230fa2ca4a4@samsung.com> <20261020-xfs-pnfs-batch-v4-5-9230fa2ca4a4@samsung.com> On Thu, Oct 22, 2026 at 03:02:30PM +0200, Pankaj Raghav wrote: > Isn't it better we add this in xfs_direct_write_iomap_begin() instead of > adding it in pnfs? [...] > + count_fsb = min_t(xfs_filblks_t, count_fsb, XFS_MAX_BMBT_EXTLEN); Thanks. That works for pNFS as well, as xfs_fs_map_blocks() passes the same count to xfs_iomap_write_direct(). I put the cap in xfs_fs_map_blocks() because it relies on the caller asking again for the rest of the range, which nfsd does, and the other caller, xfs_direct_write_iomap_begin(), already limits a mapping to 1024 pages. Daejun