From: Lee Jones <lee@kernel.org>
To: lee@kernel.org, Binbin Zhou <zhoubinbin@loongson.cn>,
Chong Qiao <qiaochong@loongson.cn>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Corey Minyard <corey@minyard.net>,
Huacai Chen <chenhuacai@kernel.org>,
mfd@lists.linux.dev, linux-kernel@vger.kernel.org
Cc: stable@vger.kernel.org
Subject: [PATCH v2 03/27] mfd: ls2kbmc: Cancel reset work on teardown via devm_work_autocancel()
Date: Tue, 27 Oct 2026 09:30:32 +0000 [thread overview]
Message-ID: <20261027093306.2812695-4-lee@kernel.org> (raw)
In-Reply-To: <20261027093306.2812695-1-lee@kernel.org>
ls2k_bmc_init() initialises bmc_reset_work with INIT_WORK() and
immediately requests the PCIe and GPIO interrupts via devm_request_irq().
If an interrupt fires and schedules bmc_reset_work before a subsequent
step in ls2k_bmc_probe() fails, or when the device is unbound, devres
frees ddata whilst bmc_reset_work remains queued, leading to a
use-after-free in ls2k_bmc_events_fn().
Initialise bmc_reset_work with devm_work_autocancel() before requesting
the interrupts so that devres cancels any pending work after the
interrupts are freed and before ddata is released.
Fixes: d952bba3fbb5 ("mfd: ls2kbmc: Add Loongson-2K BMC reset function support")
Closes: https://sashiko.dev/#/bug/linux-3089d131-9fcf-4753-b183-eebe0a6e020e
Cc: stable@vger.kernel.org
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Binbin Zhou <zhoubinbin@loongson.cn>
Signed-off-by: Lee Jones <lee@kernel.org>
---
drivers/mfd/ls2k-bmc-core.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/mfd/ls2k-bmc-core.c b/drivers/mfd/ls2k-bmc-core.c
index 23c774a09842..e245bdee8226 100644
--- a/drivers/mfd/ls2k-bmc-core.c
+++ b/drivers/mfd/ls2k-bmc-core.c
@@ -12,6 +12,7 @@
#include <linux/aperture.h>
#include <linux/bitfield.h>
#include <linux/delay.h>
+#include <linux/devm-helpers.h>
#include <linux/errno.h>
#include <linux/init.h>
#include <linux/iopoll.h>
@@ -376,7 +377,9 @@ static int ls2k_bmc_init(struct ls2k_bmc_ddata *ddata)
ls2k_bmc_save_pci_data(pdev, ddata);
- INIT_WORK(&ddata->bmc_reset_work, ls2k_bmc_events_fn);
+ ret = devm_work_autocancel(ddata->dev, &ddata->bmc_reset_work, ls2k_bmc_events_fn);
+ if (ret)
+ return ret;
ret = devm_request_irq(&pdev->dev, pdev->irq, ls2k_bmc_interrupt,
IRQF_SHARED | IRQF_TRIGGER_FALLING, "ls2kbmc pcie", ddata);
--
2.56.0.307.g5fe7bd680c-goog
next prev parent reply other threads:[~2026-10-27 10:36 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-27 9:30 [PATCH v2 00/27] mfd: Assorted resource lifetime, teardown, and error-handling fixes Lee Jones
2026-10-27 9:30 ` [PATCH v2 01/27] mfd: nct6694: Allocate USB DMA buffers with kzalloc_obj() Lee Jones
2026-10-27 9:30 ` [PATCH v2 02/27] mfd: ls2kbmc: Unregister GPIO GSI via devm_add_action_or_reset() Lee Jones
2026-10-27 9:30 ` Lee Jones [this message]
2026-10-27 9:30 ` [PATCH v2 04/27] mfd: ls2kbmc: Allocate simplefb platform_data on the heap Lee Jones
2026-10-27 9:30 ` [PATCH v2 05/27] mfd: bd96801: Allocate watchdog IRQ resource " Lee Jones
2026-10-27 9:30 ` [PATCH v2 06/27] mfd: ti_am335x_tscadc: Retrieve parent driver data via dev_get_drvdata() Lee Jones
2026-10-27 9:30 ` [PATCH v2 07/27] mfd: db8500-prcmu: Make AB8500 cell and IRQ resource static Lee Jones
2026-10-27 9:30 ` [PATCH v2 08/27] mfd: nct6694: Do not resubmit interrupt URB on endpoint stall (-EPIPE) Lee Jones
2026-10-27 9:30 ` [PATCH v2 09/27] mfd: ioc3: Request parent IRQ via request_irq() and free before domain removal Lee Jones
2026-10-27 9:30 ` [PATCH v2 10/27] mfd: intel-lpss: Remove registered MFD child devices on probe failure Lee Jones
2026-10-27 9:30 ` [PATCH v2 11/27] mfd: max8907: Manage power-off handler via devm_register_sys_off_handler() Lee Jones
2026-10-27 9:30 ` [PATCH v2 12/27] mfd: twl-core: Clear pm_power_off callback in twl_remove() Lee Jones
2026-10-27 9:30 ` [PATCH v2 13/27] mfd: twl-core: Clear twl_priv pointer on teardown and probe failure Lee Jones
2026-10-28 15:50 ` Andreas Kemnade
2026-10-27 9:30 ` [PATCH v2 14/27] mfd: loongson-se: Check return value of dma_set_mask_and_coherent() Lee Jones
2026-10-27 9:30 ` [PATCH v2 15/27] mfd: loongson-se: Zero-initialise controller command structures Lee Jones
2026-10-27 9:30 ` [PATCH v2 16/27] mfd: loongson-se: Reinitialise completions and wait uninterruptibly for commands Lee Jones
2026-10-27 9:30 ` [PATCH v2 17/27] mfd: loongson-se: Zero-allocate driver data and initialise engine completions in probe Lee Jones
2026-10-27 9:30 ` [PATCH v2 18/27] mfd: loongson-se: Prevent out-of-bounds engine access in se_irq_handler() Lee Jones
2026-10-27 9:30 ` [PATCH v2 19/27] mfd: loongson-se: Stop controller and mask interrupts on teardown and shutdown Lee Jones
2026-10-27 9:30 ` [PATCH v2 20/27] mfd: loongson-se: Validate engine ID, DMA buffer size, and IRQ registration Lee Jones
2026-10-27 9:30 ` [PATCH v2 21/27] mfd: abx500-core: Unregister device ops on devm release Lee Jones
2026-10-27 9:30 ` [PATCH v2 22/27] mfd: ab8500-core: Register sysfs attribute groups via devm_device_add_group() Lee Jones
2026-10-27 9:30 ` [PATCH v2 23/27] mfd: tps65217: Manage IRQ domain teardown via devres Lee Jones
2026-10-27 9:30 ` [PATCH v2 24/27] mfd: mt6397: Manage IRQ domain lifecycle with devres Lee Jones
2026-10-28 3:45 ` Chen-Yu Tsai
2026-10-27 9:30 ` [PATCH v2 25/27] mfd: mt6397: Unregister PM notifier on probe failure and unbind Lee Jones
2026-10-28 4:15 ` Chen-Yu Tsai
2026-10-27 9:30 ` [PATCH v2 26/27] i2c: cgbc: Propagate hardware errors when polling read status Lee Jones
2026-10-27 9:30 ` [PATCH v2 27/27] mfd: ti_am335x_tscadc: Remove redundant ti_tscadc_dev_get() helper Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261027093306.2812695-4-lee@kernel.org \
--to=lee@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=chenhuacai@kernel.org \
--cc=corey@minyard.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mfd@lists.linux.dev \
--cc=qiaochong@loongson.cn \
--cc=stable@vger.kernel.org \
--cc=zhoubinbin@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®