From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=91.218.175.47 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793098196; b=OIcysaZ4zRI/f5tkoGcQwkVJE/kNCEEjTJGhykBB/4TY/3ycwtSHfzFAtYi794rvfe4i L49FAMXN2VVhqExB+hdfB9G5yodXbS1DdSJW814V1fEasRsZ2M4tr9YaC+mh/exsqoR80 rz2lEoP7uxJQZkTicC91uKfcuQUq4y51w/bJ2lQYaE/RLIWMgFLEIZR4YWdk3B3F/husf dNsFsi7vhOQIQYCh6kRnOoMAvGS0YpQJVRFFnlQXL+iXq9tiFpmzeNPrAiMkBUJSGrK3v Ljlto4cz9W+XXOe2eRlqLegFznkrtka59bJDnvyxHB1H0/tvfFA+Lc1K67cj1nq0/ew== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793098196; h=DMARC-Filter:X-Envelope-To:DKIM-Signature:X-Envelope-To:Received: X-Mizu-Trace-ID:X-Migadu-Flow:From:To:Cc:Subject:Date:Message-ID: X-Mailer:In-Reply-To:References:MIME-Version: Content-Transfer-Encoding; bh=4cd290/hCDZXSksTs3VLb/cx7uk78JWkwG4fhmkLm44=; b=N1jKPFzr15K+04tULtoUb0u/qIwPhTlOP9zQdWbvlmLPoozIFQde8RYLG//FgHrMZGQD 8gXpONPZbI6lOLpoCSPAI9UHgDw/J2D3vFbczlSqQhQvhkHd5KKa9g168pFI/c/ppjkbu ViQS8H5tXtg0bPnW1rZaszUrE2bHwMzv9RJn4qFyDq/U1kYqRVLVJcsD5hw6hRWafzxRh 1trgdVTZ1K6V7cej28ZdXsmu5TRBhzU8xR86jAVlF9s9ZsdGkfd6vhx8cEqeO8xFzRZ2D R8PhKdjykky/FSMI1fZ4wIC5xr1nic2tOp3mEdKKo3jIHmZS1TEpC1bmUbvP0Iv5Niw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=i9izXbtE; arc=none smtp.remote-ip=91.218.175.47 Received: from mta0.migadu.com (out-47.mta0.migadu.com [91.218.175.47]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D8312606A31F for ; Tue, 27 Oct 2026 10:49:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org D8312606A31F Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=i9izXbtE X-Envelope-To: linux-kernel@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=vElP7gZrx8hmg4iu0mOX+TL4K8uCIHcaNc8ObARhgME=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1793098194; v=1; x=1793702994; b=i9izXbtErQZrxXakk7ayQH2RyzR5ByQO72pfR4WBGpU5F+wsv2SajiEaLkA1iKCZbzc1Y9NF dx5WntbphxtV7HD8XKcDX/ZwxINsBGFWc1E94F9KUCcpjdj1lOaiBJPJ6rxRIY4Id6BiWfIiVHL qV8nt1fziM0jG3yr6UdmMgwQ= X-Envelope-To: linux-kernel@vger.kernel.org Received: by smtp.migadu.com with ESMTPS id b85a0bc185fd1fb5; Tue, 27 Oct 2026 10:49:53 +0000 X-Mizu-Trace-ID: b85a0bc185fd1fb5 X-Migadu-Flow: FLOW_OUT From: Jiayuan Chen To: netdev@vger.kernel.org Cc: Jiayuan Chen , stable@vger.kernel.org, Joel Granados , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Jonathan Corbet , Shuah Khan , Randy Dunlap , David Ahern , Ido Schimmel , Thomas Gleixner , Petr Pavlu , Kuniyuki Iwashima , Fernando Fernandez Mancera , Willem de Bruijn , Maoyi Xie , Gerd Rausch , Zhan Xusheng , Oleg Nesterov , Chia-Yu Chang , Yung Chih Su , Wyatt Feng , Hannes Frederic Sowa , Flavio Leitner , Petr Mladek , "Paul E. McKenney" , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net v2 5/5] net: restrict message_cost and message_burst to non-negative values Date: Tue, 27 Oct 2026 18:45:33 +0800 Message-ID: <20261027104701.296240-6-jiayuan.chen@linux.dev> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261027104701.296240-1-jiayuan.chen@linux.dev> References: <20261027104701.296240-1-jiayuan.chen@linux.dev> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit net.core.message_cost and net.core.message_burst feed the interval and burst of net_ratelimit_state, but neither rejects negative values: message_burst uses plain proc_dointvec, and message_cost uses proc_dointvec_jiffies, which happily stores -1 second as -HZ jiffies. Since commit a940d145cc38 ("ratelimit: Warn if ->interval or ->burst are negative"), ___ratelimit() splats on such values, so the next net_ratelimit() caller warns, e.g. a martian source log: Negative interval (-250) or burst (10): Uninitialized ratelimit_state structure? WARNING: lib/ratelimit.c:43 at ___ratelimit+0x56e/0x960, CPU#1: ping/3218 RIP: 0010:___ratelimit+0x578/0x960 Call Trace: net_ratelimit+0x1c/0x30 ip_handle_martian_source+0x1bb/0x340 ip_route_input_slow+0x1057/0x3650 ip_route_input_noref+0x104/0x260 arp_process+0x109b/0x2510 arp_rcv+0x381/0x460 __netif_receive_skb_one_core+0x173/0x1c0 __netif_receive_skb+0x21/0x150 process_backlog+0x37e/0x1200 __napi_poll.constprop.0+0xa5/0x5e0 net_rx_action+0x4c0/0xf70 handle_softirqs+0x204/0x9b0 __do_softirq+0x10/0x18 do_softirq.part.0+0x49/0xd0 Negative values never meant anything here: 0 already expresses both "no limit" (interval) and "suppress everything" (burst). Reject them at write time. message_burst can simply use proc_dointvec_minmax with extra1 = 0. proc_dointvec_jiffies has no minmax variant, so add proc_dointvec_jiffies_minmax(), mirroring proc_dointvec_ms_jiffies_minmax(), and use it for message_cost with extra1 = 0. Note that like the ms variant, extra1/extra2 are compared against the converted jiffies value. Fixes: a940d145cc38 ("ratelimit: Warn if ->interval or ->burst are negative") Cc: stable@vger.kernel.org Suggested-by: Joel Granados Signed-off-by: Jiayuan Chen --- include/linux/jiffies.h | 2 ++ kernel/time/jiffies.c | 40 ++++++++++++++++++++++++++++++++++++++ net/core/sysctl_net_core.c | 6 ++++-- 3 files changed, 46 insertions(+), 2 deletions(-) diff --git a/include/linux/jiffies.h b/include/linux/jiffies.h index bbd57061802cd..de12920f8e94b 100644 --- a/include/linux/jiffies.h +++ b/include/linux/jiffies.h @@ -646,6 +646,8 @@ extern unsigned long nsecs_to_jiffies(u64 n); struct ctl_table; int proc_dointvec_jiffies(const struct ctl_table *table, int dir, void *buffer, size_t *lenp, loff_t *ppos); +int proc_dointvec_jiffies_minmax(const struct ctl_table *table, int dir, + void *buffer, size_t *lenp, loff_t *ppos); int proc_dointvec_ms_jiffies_minmax(const struct ctl_table *table, int dir, void *buffer, size_t *lenp, loff_t *ppos); int proc_dointvec_userhz_jiffies(const struct ctl_table *table, int dir, diff --git a/kernel/time/jiffies.c b/kernel/time/jiffies.c index 9b3487d40cd6a..22a70caa58bc1 100644 --- a/kernel/time/jiffies.c +++ b/kernel/time/jiffies.c @@ -165,6 +165,14 @@ static int do_proc_int_conv_jiffies(bool *negp, ulong *u_ptr, int *k_ptr, sysctl_u2k_int_conv_hz, sysctl_k2u_int_conv_hz); } +static int do_proc_int_conv_jiffies_minmax(bool *negp, ulong *u_ptr, + int *k_ptr, int dir, + const struct ctl_table *tbl) +{ + return proc_int_conv(negp, u_ptr, k_ptr, dir, tbl, true, + sysctl_u2k_int_conv_hz, sysctl_k2u_int_conv_hz); +} + static int do_proc_int_conv_userhz_jiffies(bool *negp, ulong *u_ptr, int *k_ptr, int dir, const struct ctl_table *tbl) @@ -213,6 +221,13 @@ static int do_proc_int_conv_jiffies(bool *negp, ulong *u_ptr, int *k_ptr, return -ENOSYS; } +static int do_proc_int_conv_jiffies_minmax(bool *negp, ulong *u_ptr, + int *k_ptr, int dir, + const struct ctl_table *tbl) +{ + return -ENOSYS; +} + static int do_proc_int_conv_userhz_jiffies(bool *negp, ulong *u_ptr, int *k_ptr, int dir, const struct ctl_table *tbl) @@ -263,6 +278,31 @@ int proc_dointvec_jiffies(const struct ctl_table *table, int dir, } EXPORT_SYMBOL(proc_dointvec_jiffies); +/** + * proc_dointvec_jiffies_minmax - read a vector of integers as seconds with min/max values + * @table: the sysctl table + * @dir: %TRUE if this is a write to the sysctl file + * @buffer: the user buffer + * @lenp: the size of the user buffer + * @ppos: file position + * + * Reads/writes up to table->maxlen/sizeof(unsigned int) integer + * values from/to the user buffer, treated as an ASCII string. + * The values read are assumed to be in seconds, and are converted into + * jiffies. The converted values are checked against the optional + * table->extra1 (min) and table->extra2 (max) bounds, in jiffies; + * a value outside the range is rejected with -EINVAL. + * + * Returns 0 on success. + */ +int proc_dointvec_jiffies_minmax(const struct ctl_table *table, int dir, + void *buffer, size_t *lenp, loff_t *ppos) +{ + return proc_dointvec_conv(table, dir, buffer, lenp, ppos, + do_proc_int_conv_jiffies_minmax); +} +EXPORT_SYMBOL(proc_dointvec_jiffies_minmax); + /** * proc_dointvec_userhz_jiffies - read a vector of integers as 1/USER_HZ seconds * @table: the sysctl table diff --git a/net/core/sysctl_net_core.c b/net/core/sysctl_net_core.c index 473c162736d69..9226b96f2e89b 100644 --- a/net/core/sysctl_net_core.c +++ b/net/core/sysctl_net_core.c @@ -544,14 +544,16 @@ static struct ctl_table net_core_table[] = { .data = &net_ratelimit_state.interval, .maxlen = sizeof(int), .mode = 0644, - .proc_handler = proc_dointvec_jiffies, + .proc_handler = proc_dointvec_jiffies_minmax, + .extra1 = SYSCTL_ZERO, }, { .procname = "message_burst", .data = &net_ratelimit_state.burst, .maxlen = sizeof(int), .mode = 0644, - .proc_handler = proc_dointvec, + .proc_handler = proc_dointvec_minmax, + .extra1 = SYSCTL_ZERO, }, #ifdef CONFIG_RPS { -- 2.43.0