mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ulf Hansson <ulf.hansson@oss.qualcomm.com>
To: linux-mmc@vger.kernel.org, Ulf Hansson <ulfh@kernel.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>,
	Kamal Dasu <kamal.dasu@broadcom.com>,
	Florian Fainelli <florian.fainelli@broadcom.com>,
	Wolfram Sang <wsa+renesas@sang-engineering.com>,
	Oleksij Rempel <o.rempel@pengutronix.de>,
	Ulf Hansson <ulf.hansson@oss.qualcomm.com>,
	linux-kernel@vger.kernel.org
Subject: [PATCH v10 5/6] mmc: core: Move reset functions for eMMC
Date: Tue, 27 Oct 2026 15:40:43 +0100	[thread overview]
Message-ID: <20261027144051.249211-6-ulf.hansson@oss.qualcomm.com> (raw)
In-Reply-To: <20261027144051.249211-1-ulf.hansson@oss.qualcomm.com>

To prepare for a subsequent change and to simplify review, let's move the
function for resetting the eMMC card a few lines up in the file.

Signed-off-by: Ulf Hansson <ulf.hansson@oss.qualcomm.com>
---
 drivers/mmc/core/mmc.c | 66 +++++++++++++++++++++---------------------
 1 file changed, 33 insertions(+), 33 deletions(-)

diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c
index c936272bcd81..d4bf0f25bd74 100644
--- a/drivers/mmc/core/mmc.c
+++ b/drivers/mmc/core/mmc.c
@@ -2271,6 +2271,39 @@ static int mmc_shutdown(struct mmc_host *host)
 	return err;
 }
 
+static bool mmc_card_can_reset(struct mmc_card *card)
+{
+	u8 rst_n_function;
+
+	rst_n_function = card->ext_csd.rst_n_function;
+	return ((rst_n_function & EXT_CSD_RST_N_EN_MASK) == EXT_CSD_RST_N_ENABLED);
+}
+
+static int _mmc_hw_reset(struct mmc_host *host)
+{
+	struct mmc_card *card = host->card;
+
+	/*
+	 * In the case of recovery, we can't expect flushing the cache to work
+	 * always, but we have a go and ignore errors.
+	 */
+	_mmc_flush_cache(host);
+
+	if ((host->caps & MMC_CAP_HW_RESET) && host->ops->card_hw_reset &&
+	     mmc_card_can_reset(card)) {
+		/* If the card accept RST_n signal, send it. */
+		mmc_set_clock(host, host->f_init);
+		host->ops->card_hw_reset(host);
+		/* Set initial state and call mmc_set_ios */
+		mmc_set_initial_state(host);
+	} else {
+		/* Do a brute force power cycle */
+		mmc_power_cycle(host, card->ocr);
+		mmc_pwrseq_reset(host);
+	}
+	return mmc_init_card(host, card->ocr, card);
+}
+
 /*
  * Callback for resume.
  */
@@ -2319,39 +2352,6 @@ static int mmc_runtime_resume(struct mmc_host *host)
 	return 0;
 }
 
-static bool mmc_card_can_reset(struct mmc_card *card)
-{
-	u8 rst_n_function;
-
-	rst_n_function = card->ext_csd.rst_n_function;
-	return ((rst_n_function & EXT_CSD_RST_N_EN_MASK) == EXT_CSD_RST_N_ENABLED);
-}
-
-static int _mmc_hw_reset(struct mmc_host *host)
-{
-	struct mmc_card *card = host->card;
-
-	/*
-	 * In the case of recovery, we can't expect flushing the cache to work
-	 * always, but we have a go and ignore errors.
-	 */
-	_mmc_flush_cache(host);
-
-	if ((host->caps & MMC_CAP_HW_RESET) && host->ops->card_hw_reset &&
-	     mmc_card_can_reset(card)) {
-		/* If the card accept RST_n signal, send it. */
-		mmc_set_clock(host, host->f_init);
-		host->ops->card_hw_reset(host);
-		/* Set initial state and call mmc_set_ios */
-		mmc_set_initial_state(host);
-	} else {
-		/* Do a brute force power cycle */
-		mmc_power_cycle(host, card->ocr);
-		mmc_pwrseq_reset(host);
-	}
-	return mmc_init_card(host, card->ocr, card);
-}
-
 /**
  * _mmc_handle_undervoltage - Handle an undervoltage event for MMC/eMMC devices
  * @host: MMC host structure
-- 
2.43.0


  parent reply	other threads:[~2026-10-27 14:41 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-27 14:40 [PATCH v10 0/6] mmc: core: Keep the card powered across suspend when firmware needs it live Ulf Hansson
2026-10-27 14:40 ` [PATCH v10 1/6] dt-bindings: mmc: Extend keep-power-in-suspend beyond SDIO Ulf Hansson
2026-10-27 15:01   ` Shawn Lin
2026-10-27 19:46     ` Ulf Hansson
2026-10-28  0:36       ` Shawn Lin
2026-10-28 10:43         ` Ulf Hansson
2026-10-28 12:08           ` Shawn Lin
2026-10-27 15:33   ` Krzysztof Kozlowski
2026-10-27 19:48     ` Ulf Hansson
2026-10-27 20:31       ` Kamal Dasu
2026-10-28 10:36         ` Ulf Hansson
2026-10-28 15:46         ` Ulf Hansson
2026-10-27 14:40 ` [PATCH v10 2/6] dt-bindings: mmc: Add reset-card-at-resume property Ulf Hansson
2026-10-27 15:33   ` Krzysztof Kozlowski
2026-10-27 14:40 ` [PATCH v10 3/6] mmc: core: Add option to keep an eMMC powered on at system suspend Ulf Hansson
2026-10-27 15:19   ` Shawn Lin
2026-10-27 14:40 ` [PATCH v10 4/6] mmc: core: Split sdio_set_host_pm_flags() Ulf Hansson
2026-10-27 15:12   ` Shawn Lin
2026-10-27 19:43     ` Ulf Hansson
2026-10-27 14:40 ` Ulf Hansson [this message]
2026-10-27 15:19   ` [PATCH v10 5/6] mmc: core: Move reset functions for eMMC Shawn Lin
2026-10-27 14:40 ` [PATCH v10 6/6] mmc: core: Add support for resetting an eMMC at system resume Ulf Hansson
2026-10-27 15:20   ` Shawn Lin
2026-10-27 20:00     ` Kamal Dasu
2026-10-27 19:53 ` [PATCH v10 0/6] mmc: core: Keep the card powered across suspend when firmware needs it live Kamal Dasu
2026-10-28  9:35   ` Ulf Hansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261027144051.249211-6-ulf.hansson@oss.qualcomm.com \
    --to=ulf.hansson@oss.qualcomm.com \
    --cc=adrian.hunter@intel.com \
    --cc=florian.fainelli@broadcom.com \
    --cc=kamal.dasu@broadcom.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=o.rempel@pengutronix.de \
    --cc=ulfh@kernel.org \
    --cc=wsa+renesas@sang-engineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®