From: paritoshpotukuchi@gmail.com
To: mlombard@arkamax.eu
Cc: linux-nvme@lists.infradead.org, justin.tee@broadcom.com,
nareshgottumukkala83@gmail.com, paul.ely@broadcom.com,
hch@lst.de, sagi@grimberg.me, kch@nvidia.com,
linux-kernel@vger.kernel.org,
syzbot+df0058a8d0bdce7c4059@syzkaller.appspotmail.com
Subject: Re: [PATCH] nvmet-fc: extend critical section in nvmet_fc_remove_port()
Date: Tue, 27 Oct 2026 15:54:18 +0000 [thread overview]
Message-ID: <20261027155418.2005768-1-paritoshpotukuchi@gmail.com> (raw)
In-Reply-To: <DMFPJJEAQDER.1LTPXDFP8FYUG@arkamax.eu>
> I don't think this safe.
> nvmet_fc_tgtport_put() can end up calling fcloop_targetport_delete()
> which calls flush_work(), therefore you call a blocking function while
> in atomic context
Thanks for pointing that out.
The current implementation of nvmet_fc_portentry_unbind calls
nvmet_fc_tgtport_put() while holding a spinlock.
From what we understand, this seems to be a design flaw,
since flush_work() is still being called while holding a spinlock.
Paritosh
prev parent reply other threads:[~2026-10-27 15:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-27 14:43 paritoshpotukuchi
2026-10-27 14:58 ` Maurizio Lombardi
2026-10-27 15:54 ` paritoshpotukuchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261027155418.2005768-1-paritoshpotukuchi@gmail.com \
--to=paritoshpotukuchi@gmail.com \
--cc=hch@lst.de \
--cc=justin.tee@broadcom.com \
--cc=kch@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=mlombard@arkamax.eu \
--cc=nareshgottumukkala83@gmail.com \
--cc=paul.ely@broadcom.com \
--cc=sagi@grimberg.me \
--cc=syzbot+df0058a8d0bdce7c4059@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®